[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993559#comment-15993559
 ] 

ASF GitHub Bot commented on BEAM-1402:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2774


> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Reuven Lax
>  Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989724#comment-15989724
 ] 

ASF GitHub Bot commented on BEAM-1402:
--

GitHub user jkff opened a pull request:

https://github.com/apache/beam/pull/2778

[BEAM-1402] AvroIO should comply with PTransform style guide

Migration guide:
- AvroIO.Read.from(...).withSchema(Foo.class) -> 
AvroIO.read(Foo.class).from(...)
- AvroIO.Read.from(...).withSchema(Schema or String) -> 
AvroIO.readGenericRecords(String).from(...)
- Likewise for AvroIO.Write

This is the last PR in https://issues.apache.org/jira/browse/BEAM-1353 !

R: @reuvenlax 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jkff/incubator-beam avro-style

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2778


commit b91f2b7291eccc1845e2e42eae36c8fa0acec25d
Author: Eugene Kirpichov 
Date:   2017-04-29T01:05:00Z

Moves AvroSink to upper level

commit a9f7f1b474fda41fc663d94147e0d9fa94fe619b
Author: Eugene Kirpichov 
Date:   2017-04-29T01:19:21Z

Removes AvroIO.Read.Bound

commit 7237c80bfa16716559e3d157481db55e8b025683
Author: Eugene Kirpichov 
Date:   2017-04-29T01:36:20Z

Adds AvroIO.readGenericRecords()

commit c1a4d9bccc988c2b89d5501fe912d64e3832a98c
Author: Eugene Kirpichov 
Date:   2017-04-29T01:37:49Z

Converts AvroIO.Read to AutoValue

commit ce17f5c39c4c0110db020922662b62b26e7f73ef
Author: Eugene Kirpichov 
Date:   2017-04-29T01:59:03Z

Removes AvroIO.Write.Bound

commit 5a3f2c1ceac1528deef73fa21ad9db2e25bd3f96
Author: Eugene Kirpichov 
Date:   2017-04-29T02:03:25Z

Moves AvroIO.Read.withSchema into read()

commit 8e883f02ff6f3b3abe0978e07a773f97e1b0d960
Author: Eugene Kirpichov 
Date:   2017-04-29T02:21:15Z

Converts AvroIO.Write to AutoValue; adds writeGenericRecords()

commit 70fa3bd96d84a4e879a4fa05a188677311e93a24
Author: Eugene Kirpichov 
Date:   2017-04-29T02:25:45Z

Moves AvroIO.write().withSchema into write()




> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Reuven Lax
>  Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989668#comment-15989668
 ] 

ASF GitHub Bot commented on BEAM-1402:
--

GitHub user jkff opened a pull request:

https://github.com/apache/beam/pull/2774

[BEAM-1402] Makes TextIO comply with PTransform style guide

Migration guide: TextIO.Read.from() -> TextIO.read().from; 
TextIO.Write.to() -> TextIO.write().to()

Also converts both to AutoValue and moves some utility classes to upper 
level to declutter TextIO.java.

Each individual commit should be trivial to review.

R: @reuvenlax   

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jkff/incubator-beam text-style

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2774


commit 2421f80eb46525d18ffa4af1dd0dc398db278b61
Author: Eugene Kirpichov 
Date:   2017-04-29T00:14:29Z

Removes leftover no-op withoutValidation methods

commit 98526274d69ed4665f34108b46e678ecf850b561
Author: Eugene Kirpichov 
Date:   2017-04-29T00:06:46Z

Removes TextIO.Read.Bound

commit cb18481b034f1b47f47e6f749b73c4395cb9684d
Author: Eugene Kirpichov 
Date:   2017-04-29T00:16:14Z

Converts TextIO.Read to AutoValue

commit ed28a1e8a3eca34ddc278b2facbef61cf3dd37f5
Author: Eugene Kirpichov 
Date:   2017-04-29T00:28:06Z

Removes TextIO.Write.Bound

commit 51208cd05f0cbf43776772092909da2afaafb1d8
Author: Eugene Kirpichov 
Date:   2017-04-29T00:39:01Z

Converts TextIO.Write to AutoValue

commit e5eb565522885b7dae78d45db0cdd4a447cfb14f
Author: Eugene Kirpichov 
Date:   2017-04-29T00:46:44Z

Moves TextSource and TextSink to top level




> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Reuven Lax
>  Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[Aviem Zur (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857408#comment-15857408
 ] 

Aviem Zur commented on BEAM-1402:
-

OK. Created sub-task BEAM-1433 and PR.

> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Reuven Lax
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[Aviem Zur (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857339#comment-15857339
 ] 

Aviem Zur commented on BEAM-1402:
-

I've started working on some of what [~jkff] mentioned in BEAM-1354
Namely, I've removed coder from {{TextIO}} in 
https://github.com/aviemzur/beam/commit/2b07ad168c58755cad3a12aceed19df814e9904b
Can this effort be merged?

> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Reuven Lax
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[Eugene Kirpichov (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856841#comment-15856841
 ] 

Eugene Kirpichov commented on BEAM-1402:


More specifically, the necessary changes are:

- Specify type parameters explicitly: TextIO.read() etc.
- Get rid of classes like TextIO.Read.Bound - instead, TextIO.Read should be 
the transform class itself
- Get rid of static builder-like .withBlah() methods - everything should be 
built using non-static methods on top of .read(), .write() and alike
- Remove coders from the TextIO API
- (optional) use AutoValue

The PR already does the first 3 of these items.

> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Davor Bonaci
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1402) Make TextIO and AvroIO use best-practice types.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853672#comment-15853672
 ] 

ASF GitHub Bot commented on BEAM-1402:
--

GitHub user reuvenlax opened a pull request:

https://github.com/apache/beam/pull/1927

[BEAM-1402] Remove static Read/Write classes from TextIO and AvroIO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/reuvenlax/incubator-beam refactor_source_sink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/1927.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1927


commit 601b9ab45f11d7c1aa3296c002c5697b217b54f2
Author: Reuven Lax 
Date:   2016-11-14T04:29:31Z

Add PubSub attributes support to PubsubIO.

commit 58055e43044f731ea13719673554aa9e9602dc1d
Author: Reuven Lax 
Date:   2017-01-25T03:19:36Z

Fix TextIO and AvroIO to use new read() write() methods instead of static 
Read and Write classes.

commit af1b8854213fc9e5a436a131e83d7b4a545e77ad
Author: Reuven Lax 
Date:   2017-01-25T03:25:19Z

Remove unrelated change




> Make TextIO and AvroIO use best-practice types.
> ---
>
> Key: BEAM-1402
> URL: https://issues.apache.org/jira/browse/BEAM-1402
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Reuven Lax
>Assignee: Davor Bonaci
>
> Replace static Read/Write classes with type-instantiated classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)