[jira] [Commented] (BEAM-1572) Add per-stage matching of scope in metrics for the DirectRunner

2017-02-27 Thread Aviem Zur (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887219#comment-15887219
 ] 

Aviem Zur commented on BEAM-1572:
-

Please note that this relates to https://issues.apache.org/jira/browse/BEAM-1344
The ultimate goal is to have a uniform querying logic across all runners.

> Add per-stage matching of scope in metrics for the DirectRunner
> ---
>
> Key: BEAM-1572
> URL: https://issues.apache.org/jira/browse/BEAM-1572
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>
> e.g. Metrics with scope "Top/Outer/Inner" should be matched by queries with 
> "Top/Outer" scope.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1572) Add per-stage matching of scope in metrics for the DirectRunner

2017-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887030#comment-15887030
 ] 

ASF GitHub Bot commented on BEAM-1572:
--

GitHub user pabloem opened a pull request:

https://github.com/apache/beam/pull/2122

[BEAM-1572] Adding per-stage level matching of metrics filters.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---
Also fixed a bug in Python metrics.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pabloem/incubator-beam metrics-filter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2122


commit bc2a99354406981f75e60b86fd9776d572cb0159
Author: Pablo 
Date:   2017-02-28T01:28:26Z

Adding per-stage level matching of metrics filters.




> Add per-stage matching of scope in metrics for the DirectRunner
> ---
>
> Key: BEAM-1572
> URL: https://issues.apache.org/jira/browse/BEAM-1572
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>
> e.g. Metrics with scope "Top/Outer/Inner" should be matched by queries with 
> "Top/Outer" scope.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1572) Add per-stage matching of scope in metrics for the DirectRunner

2017-02-27 Thread Davor Bonaci (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886885#comment-15886885
 ] 

Davor Bonaci commented on BEAM-1572:


Thanks [~pabloem].

> Add per-stage matching of scope in metrics for the DirectRunner
> ---
>
> Key: BEAM-1572
> URL: https://issues.apache.org/jira/browse/BEAM-1572
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>
> e.g. Metrics with scope "Top/Outer/Inner" should be matched by queries with 
> "Top/Outer" scope.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)