[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031221#comment-16031221 ] Jean-Baptiste Onofré commented on BEAM-1717: I found that the {{maven-shade-plugin}} is the source of the problem: https://github.com/gatling/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L537 As the shade plugin attach the test artifact, and do as well, it explains why we have two artifacts attached to the module. I'm evaluating two possible solutions: 1. filter/exclude the test artifact in the {{maven-shade-plugin}} configuration 2. don't attach the test artifact in our {{pom.xml}} and let the shade plugin does it > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Jean-Baptiste Onofré >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997789#comment-15997789 ] Jean-Baptiste Onofré commented on BEAM-1717: Thanks Davor ! > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Jean-Baptiste Onofré >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997041#comment-15997041 ] Davor Bonaci commented on BEAM-1717: CC: [~jbonofre], [~ksalant] from the duplicate bug. I'm unmarking this from the first stable release, since it is a build process issue. [~jbonofre] offered help, so I'm gratefully assigning it ;-) > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Davor Bonaci >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944168#comment-15944168 ] Davor Bonaci commented on BEAM-1717: Thanks! (I'll let you know if I get a little bit of time and find something obvious.) > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > Fix For: First stable release > > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943698#comment-15943698 ] Amit Sela commented on BEAM-1717: - [~davor] {{beam-sdks-java-core}} is OK now, but now the release fails on duplicate in the Dataflow runner module, I'll dig back in later this week but maybe you could also take a look there and see if something catches your attention. We're working our way through this one nicely module-by-module, just a little bit more effort and we'll get there ;) > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > Fix For: First stable release > > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943677#comment-15943677 ] Davor Bonaci commented on BEAM-1717: [~amitsela], is this fixed, or are there any other outstanding duplicates? > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > Fix For: First stable release > > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938702#comment-15938702 ] ASF GitHub Bot commented on BEAM-1717: -- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/2303 > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938385#comment-15938385 ] ASF GitHub Bot commented on BEAM-1717: -- GitHub user amitsela opened a pull request: https://github.com/apache/beam/pull/2303 [BEAM-1717] maven-javadoc-plugin execution id should match the id in … …apache parent. Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/amitsela/beam change-javadoc-execution-id Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2303 commit c910d09cf85a40edca4cae24a0b30f7190923859 Author: Amit Sela Date: 2017-03-23T14:13:00Z [BEAM-1717] maven-javadoc-plugin execution id should match the id in apache parent. > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938372#comment-15938372 ] Amit Sela commented on BEAM-1717: - Looks like https://github.com/apache/beam/pull/2261 and the patch I described above fix the issues in {{beam-sdks-java-core}}. Now there's a similar issue in dataflow-runner, I'll keep digging. > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924819#comment-15924819 ] Amit Sela commented on BEAM-1717: - Once this worked-out, I noticed a duplicate {{test}} jar in {{beam-sdks-java-core}}. Not sure what's the issue here, but running maven in debug mode shows that in the execution of {{maven-install-plugin}} the {{attachedArtifacts}} contain both {{org.apache.beam:beam-sdks-java-core:test-jar:tests}} and {{org.apache.beam:beam-sdks-java-core:jar:tests}} which seem to cause the duplication. While the {{default-test-jar}} execution id (jar plugin) calls the {{test-jar}} goal, I wonder if the {{jar}} goal also creates a {{tests}} jar. > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1717) Maven release/deploy tries to uploads some artifacts more than once
[ https://issues.apache.org/jira/browse/BEAM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924812#comment-15924812 ] Amit Sela commented on BEAM-1717: - Seems that there is more than one issue here. First one is with {{beam-sdks-common-fn-api}} which produces the {{javadoc}} jar twice. This seemed to be resolved by changing the execution id of {{maven-javadoc-plugin}} in {{beam-parent.xml}} from {{javadoc}} to {{attach-javadocs}} like this: {code} ... release org.apache.maven.plugins maven-javadoc-plugin attach-javadocs package jar ... {code} > Maven release/deploy tries to uploads some artifacts more than once > > > Key: BEAM-1717 > URL: https://issues.apache.org/jira/browse/BEAM-1717 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Amit Sela >Assignee: Amit Sela >Priority: Minor > > Running maven {{release}} or {{deploy}} causes some artifacts to deploy more > than once which fails deployments to release Nexus. > While this is not an issue for the Apache release process (because it uses a > staging Nexus), this affects users who wish to deploy their own fork. -- This message was sent by Atlassian JIRA (v6.3.15#6346)