[jira] [Commented] (BEAM-1738) DataflowRunner should override Reshuffle transform

2017-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943942#comment-15943942
 ] 

ASF GitHub Bot commented on BEAM-1738:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2269


> DataflowRunner should override Reshuffle transform
> --
>
> Key: BEAM-1738
> URL: https://issues.apache.org/jira/browse/BEAM-1738
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Thomas Groh
> Fix For: Not applicable
>
>
> Verify that the code works, and then remove the reification of windows for 
> the Dataflow Runner since it handles Reshufle specially and doesn't need the 
> explicit reification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1738) DataflowRunner should override Reshuffle transform

2017-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930884#comment-15930884
 ] 

ASF GitHub Bot commented on BEAM-1738:
--

GitHub user tgroh opened a pull request:

https://github.com/apache/beam/pull/2269

[BEAM-1738] Do not reify timestamps in Reshuffle in Dataflow

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---
Dataflow has special handling of the ReshuffleTrigger that outputs
elements with their original timestamps.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tgroh/beam dataflow_reshuffle_override

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2269


commit 5bc1bfaf13d8bfdb67ce7bacd006a75512c1696a
Author: Thomas Groh 
Date:   2017-03-17T23:21:27Z

Do not reify timestamps in Reshuffle in Dataflow

Dataflow has special handling of the ReshuffleTrigger that outputs
elements with their original timestamps.




> DataflowRunner should override Reshuffle transform
> --
>
> Key: BEAM-1738
> URL: https://issues.apache.org/jira/browse/BEAM-1738
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Thomas Groh
>
> Verify that the code works, and then remove the reification of windows for 
> the Dataflow Runner since it handles Reshufle specially and doesn't need the 
> explicit reification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1738) DataflowRunner should override Reshuffle transform

2017-03-17 Thread Thomas Groh (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930236#comment-15930236
 ] 

Thomas Groh commented on BEAM-1738:
---

Dataflow internally does no buffering and outputs elements with their original 
timestamps when a ReshuffleTrigger is assigned to the GroupByKey. It doesn't 
need to reify the timestamps explicitly.

The new tests that Reshuffle maintains timestamps should still apply.

> DataflowRunner should override Reshuffle transform
> --
>
> Key: BEAM-1738
> URL: https://issues.apache.org/jira/browse/BEAM-1738
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Thomas Groh
>
> Verify that the code works, and then remove the reification of windows for 
> the Dataflow Runner since it handles Reshufle specially and doesn't need the 
> explicit reification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)