[jira] [Commented] (BEAM-1805) a new option `asInnerJoin` for CoGroupByKey

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994134#comment-15994134
 ] 

ASF GitHub Bot commented on BEAM-1805:
--

Github user XuMingmin closed the pull request at:

https://github.com/apache/beam/pull/2339


> a new option `asInnerJoin` for CoGroupByKey
> ---
>
> Key: BEAM-1805
> URL: https://issues.apache.org/jira/browse/BEAM-1805
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
> Fix For: Not applicable
>
>
> {{CoGroupByKey}} joins multiple PCollection>, act as full-outer join.
> Option {{asInnerJoin()}} restrict the output to convert to an inner-join 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1805) a new option `asInnerJoin` for CoGroupByKey

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944017#comment-15944017
 ] 

ASF GitHub Bot commented on BEAM-1805:
--

GitHub user XuMingmin opened a pull request:

https://github.com/apache/beam/pull/2339

[BEAM-1805] a new option `asInnerJoin` for CoGroupByKey

*INNER_JOIN* is available with 
[Join](https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java).
 However it's limited to two `PCollection`s, it's helpful to add it to 
`CoGroupByKey` for the case with multiple `PCollection` joined.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/XuMingmin/beam BEAM-1805

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2339


commit 09df9b5c15dd5b409d9da937225caa073a663255
Author: XuMingmin 
Date:   2017-03-15T21:45:17Z

Merge pull request #3 from apache/master

sync-up code

commit 93929873179a04fb0038400d57b55b3779d7b085
Author: XuMingmin 
Date:   2017-03-24T23:17:00Z

Merge pull request #4 from apache/master

sync up code

commit 62ff6bd83725414aa2ca11d30a5bd7776afe99fa
Author: XuMingmin 
Date:   2017-03-27T18:30:44Z

Merge pull request #5 from apache/master

sync-up code

commit 6f087a085094bd2520094ca0c5c540ae74b31542
Author: mingmxu 
Date:   2017-03-27T20:38:45Z

initial commit




> a new option `asInnerJoin` for CoGroupByKey
> ---
>
> Key: BEAM-1805
> URL: https://issues.apache.org/jira/browse/BEAM-1805
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
>
> {{CoGroupByKey}} joins multiple PCollection>, act as full-outer join.
> Option {{asInnerJoin()}} restrict the output to convert to an inner-join 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1805) a new option `asInnerJoin` for CoGroupByKey

[Xu Mingmin (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943615#comment-15943615
 ] 

Xu Mingmin commented on BEAM-1805:
--

[~aviemzur] thanks to point it, I only noticed CoGroupByKey and GroupByKey 
before, will try join-library first.

> a new option `asInnerJoin` for CoGroupByKey
> ---
>
> Key: BEAM-1805
> URL: https://issues.apache.org/jira/browse/BEAM-1805
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
>
> {{CoGroupByKey}} joins multiple PCollection>, act as full-outer join.
> Option {{asInnerJoin()}} restrict the output to convert to an inner-join 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1805) a new option `asInnerJoin` for CoGroupByKey

[Aviem Zur (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942640#comment-15942640
 ] 

Aviem Zur commented on BEAM-1805:
-

Have you taken a look at 
[join-library|https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java]?

> a new option `asInnerJoin` for CoGroupByKey
> ---
>
> Key: BEAM-1805
> URL: https://issues.apache.org/jira/browse/BEAM-1805
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
>
> {{CoGroupByKey}} joins multiple PCollection>, act as full-outer join.
> Option {{asInnerJoin()}} restrict the output to convert to an inner-join 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)