[jira] [Commented] (BEAM-1865) Input Coder of GroupByKey should be a KV Coder in the Python SDK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963584#comment-15963584
 ] 

ASF GitHub Bot commented on BEAM-1865:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2470


> Input Coder of GroupByKey should be a KV Coder in the Python SDK
> 
>
> Key: BEAM-1865
> URL: https://issues.apache.org/jira/browse/BEAM-1865
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Vikas Kedigehalli
>Assignee: Vikas Kedigehalli
>
> `Any` type is consistent with `KV` in python. The coder for `Any` type is a 
> fallback coder or a `FastPrimitivesCoder`, but for a `GroupByKey` operation 
> this needs to be a `TupleCoder` to ensure that the generated pipeline 
> representation is runnable on a runner in a different language (in the Fn API 
> world)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1865) Input Coder of GroupByKey should be a KV Coder in the Python SDK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961645#comment-15961645
 ] 

ASF GitHub Bot commented on BEAM-1865:
--

GitHub user vikkyrk opened a pull request:

https://github.com/apache/beam/pull/2470

[BEAM-1865]: Fix GroupByKeyInputVisitor for Direct Runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).

---

- Also handle `None` input types which is the case when 
`TypeOptions.pipeline_type_check` is disabled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vikkyrk/incubator-beam py_gbk_type_check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2470


commit c7f1a44dc5259164f326bef23ff4620b4ffbcb77
Author: Vikas Kedigehalli 
Date:   2017-04-08T02:22:27Z

Fix GroupByKeyInputVisitor for Direct Runner




> Input Coder of GroupByKey should be a KV Coder in the Python SDK
> 
>
> Key: BEAM-1865
> URL: https://issues.apache.org/jira/browse/BEAM-1865
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Vikas Kedigehalli
>Assignee: Vikas Kedigehalli
>
> `Any` type is consistent with `KV` in python. The coder for `Any` type is a 
> fallback coder or a `FastPrimitivesCoder`, but for a `GroupByKey` operation 
> this needs to be a `TupleCoder` to ensure that the generated pipeline 
> representation is runnable on a runner in a different language (in the Fn API 
> world)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1865) Input Coder of GroupByKey should be a KV Coder in the Python SDK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958088#comment-15958088
 ] 

ASF GitHub Bot commented on BEAM-1865:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2409


> Input Coder of GroupByKey should be a KV Coder in the Python SDK
> 
>
> Key: BEAM-1865
> URL: https://issues.apache.org/jira/browse/BEAM-1865
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Vikas Kedigehalli
>Assignee: Vikas Kedigehalli
>
> `Any` type is consistent with `KV` in python. The coder for `Any` type is a 
> fallback coder or a `FastPrimitivesCoder`, but for a `GroupByKey` operation 
> this needs to be a `TupleCoder` to ensure that the generated pipeline 
> representation is runnable on a runner in a different language (in the Fn API 
> world)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1865) Input Coder of GroupByKey should be a KV Coder in the Python SDK

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954017#comment-15954017
 ] 

ASF GitHub Bot commented on BEAM-1865:
--

GitHub user vikkyrk opened a pull request:

https://github.com/apache/beam/pull/2409

[BEAM-1865]: Replace Any type with a KV type for inputs of a GroupByKey step

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

- Relying on existing tests to ensure nothing breaks. For proper coverage I 
will defer to BEAM-115 being fixed, which allows the pipeline representation 
testing in a runner independent way. 

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vikkyrk/incubator-beam runner_gbk_coder

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2409


commit 9cad8884e350eb9332f2677f99de5cb646d11c06
Author: Vikas Kedigehalli 
Date:   2017-04-03T03:46:55Z

Replace Any type with a KV type for inputs of a GroupByKey step




> Input Coder of GroupByKey should be a KV Coder in the Python SDK
> 
>
> Key: BEAM-1865
> URL: https://issues.apache.org/jira/browse/BEAM-1865
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Vikas Kedigehalli
>Assignee: Vikas Kedigehalli
>
> `Any` type is consistent with `KV` in python. The coder for `Any` type is a 
> fallback coder or a `FastPrimitivesCoder`, but for a `GroupByKey` operation 
> this needs to be a `TupleCoder` to ensure that the generated pipeline 
> representation is runnable on a runner in a different language (in the Fn API 
> world)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)