[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983810#comment-15983810
]
ASF GitHub Bot commented on BEAM-1988:
--
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2665
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981981#comment-15981981
]
ASF GitHub Bot commented on BEAM-1988:
--
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2665
[BEAM-1988] Add FileSystems Interface for accessing underlying FS
…rectly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @chamikaramj @aaltay PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-1988-filesystems-interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2665
commit ec3b30feb58914aec03ef5d1d10e373c96dc7b4e
Author: Sourabh Bajaj
Date: 2017-04-24T21:57:09Z
[BEAM-1988] Add FileSystems Interface for accessing underlying FS correctly
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980517#comment-15980517
]
ASF GitHub Bot commented on BEAM-1988:
--
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2643
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979608#comment-15979608
]
ASF GitHub Bot commented on BEAM-1988:
--
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2643
[BEAM-1988] Migrate from utils.path to BFS
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @chamikaramj PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-1988-path-join-filesystem-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2643
commit 75719dc0d91089ecb29622c2a4f68db644ae500a
Author: Sourabh Bajaj
Date: 2017-04-21T23:39:34Z
[BEAM-1988] Migrate from utils.path to BFS
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979559#comment-15979559
]
ASF GitHub Bot commented on BEAM-1988:
--
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2585
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
> Fix For: First stable release
>
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-1988) utils.path.join does not correctly handle GCS bucket roots
[
https://issues.apache.org/jira/browse/BEAM-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973713#comment-15973713
]
ASF GitHub Bot commented on BEAM-1988:
--
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/2585
[BEAM-1988] Add join operation to the filesystem
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @chamikaramj PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-1988-path-join-filesystem
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2585
commit 882ec31503aff88614b368e65da7b5ed67488fb7
Author: Sourabh Bajaj
Date: 2017-04-18T23:18:38Z
[BEAM-1988] Add join operation to the filesystem
> utils.path.join does not correctly handle GCS bucket roots
> --
>
> Key: BEAM-1988
> URL: https://issues.apache.org/jira/browse/BEAM-1988
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
>Reporter: Ahmet Altay
>Assignee: Sourabh Bajaj
>
> Here:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22
> Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results
> in invalid 'gs://mybucket//myfile', notice the double // between mybucket and
> myfile. (It actually does not handle anything that already ends with {{/}}
> correctly)
> [~sb2nov] could you take this one? Also, should the `join` operation move to
> a BeamFileSystem level code.
> (cc: [~chamikara])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
