[jira] [Commented] (BEAM-2015) Dataflow PostCommit has been failing since build #2814

2017-04-19 Thread Luke Cwik (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975390#comment-15975390
 ] 

Luke Cwik commented on BEAM-2015:
-

Tests are now passing again:
https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2883/

> Dataflow PostCommit has been failing since build #2814
> --
>
> Key: BEAM-2015
> URL: https://issues.apache.org/jira/browse/BEAM-2015
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Affects Versions: First stable release
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2814/
> The issue is the runners/core-java is inheriting the maven profile which is 
> being activated by the specification of the validatesRunnerPipelineOptions 
> system property.
> This issue had not been a problem in the past because the dependency order 
> had made the runners/google-cloud-dataflow-java part of the classpath.
> There was an assumption that runners/ would only have runner modules and that 
> all submodules would want to have the shared definition. This is no longer 
> the case.
> {code}
> Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.046 sec <<< 
> FAILURE! - in org.apache.beam.runners.core.SplittableParDoTest
> testCheckpointsAfterNumOutputs(org.apache.beam.runners.core.SplittableParDoTest)
>   Time elapsed: 0.003 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Unknown 'runner' specified 
> 'org.apache.beam.runners.dataflow.testing.TestDataflowRunner', supported 
> pipeline runners [RegisteredTestRunner]
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.parseObjects(PipelineOptionsFactory.java:1609)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.access$400(PipelineOptionsFactory.java:104)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory$Builder.as(PipelineOptionsFactory.java:289)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.testingPipelineOptions(TestPipeline.java:392)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.create(TestPipeline.java:257)
>   at 
> org.apache.beam.runners.core.SplittableParDoTest.(SplittableParDoTest.java:149)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
>   at 
>

[jira] [Commented] (BEAM-2015) Dataflow PostCommit has been failing since build #2814

2017-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975320#comment-15975320
 ] 

ASF GitHub Bot commented on BEAM-2015:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2592


> Dataflow PostCommit has been failing since build #2814
> --
>
> Key: BEAM-2015
> URL: https://issues.apache.org/jira/browse/BEAM-2015
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Affects Versions: First stable release
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2814/
> The issue is the runners/core-java is inheriting the maven profile which is 
> being activated by the specification of the validatesRunnerPipelineOptions 
> system property.
> This issue had not been a problem in the past because the dependency order 
> had made the runners/google-cloud-dataflow-java part of the classpath.
> There was an assumption that runners/ would only have runner modules and that 
> all submodules would want to have the shared definition. This is no longer 
> the case.
> {code}
> Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.046 sec <<< 
> FAILURE! - in org.apache.beam.runners.core.SplittableParDoTest
> testCheckpointsAfterNumOutputs(org.apache.beam.runners.core.SplittableParDoTest)
>   Time elapsed: 0.003 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Unknown 'runner' specified 
> 'org.apache.beam.runners.dataflow.testing.TestDataflowRunner', supported 
> pipeline runners [RegisteredTestRunner]
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.parseObjects(PipelineOptionsFactory.java:1609)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.access$400(PipelineOptionsFactory.java:104)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory$Builder.as(PipelineOptionsFactory.java:289)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.testingPipelineOptions(TestPipeline.java:392)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.create(TestPipeline.java:257)
>   at 
> org.apache.beam.runners.core.SplittableParDoTest.(SplittableParDoTest.java:149)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
>   at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
>   at 
>

[jira] [Commented] (BEAM-2015) Dataflow PostCommit has been failing since build #2814

2017-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974983#comment-15974983
 ] 

ASF GitHub Bot commented on BEAM-2015:
--

GitHub user lukecwik opened a pull request:

https://github.com/apache/beam/pull/2592

[BEAM-2015] Remove shared profile in runners/pom.xml and fix Dataflow 
ValidatesRunner PostCommit

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).

---
Diff'd effective poms to compare changes and find all inherited properties 
in sub runner modules.

I was limited by the seed job failing to make some other minor changes in 
clean-up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lukecwik/incubator-beam dataflow_post_commit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2592.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2592


commit ece72d42bdda512eadc78cfcf8e9dfe7b117a41c
Author: Luke Cwik 
Date:   2017-04-19T16:10:39Z

[BEAM-2015] Remove shared profile in runners/pom.xml and fix Dataflow 
ValidatesRunner PostCommit




> Dataflow PostCommit has been failing since build #2814
> --
>
> Key: BEAM-2015
> URL: https://issues.apache.org/jira/browse/BEAM-2015
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Affects Versions: First stable release
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2814/
> The issue is the runners/core-java is inheriting the maven profile which is 
> being activated by the specification of the validatesRunnerPipelineOptions 
> system property.
> This issue had not been a problem in the past because the dependency order 
> had made the runners/google-cloud-dataflow-java part of the classpath.
> There was an assumption that runners/ would only have runner modules and that 
> all submodules would want to have the shared definition. This is no longer 
> the case.
> {code}
> Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.046 sec <<< 
> FAILURE! - in org.apache.beam.runners.core.SplittableParDoTest
> testCheckpointsAfterNumOutputs(org.apache.beam.runners.core.SplittableParDoTest)
>   Time elapsed: 0.003 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Unknown 'runner' specified 
> 'org.apache.beam.runners.dataflow.testing.TestDataflowRunner', supported 
> pipeline runners [RegisteredTestRunner]
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.parseObjects(PipelineOptionsFactory.java:1609)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory.access$400(PipelineOptionsFactory.java:104)
>   at 
> org.apache.beam.sdk.options.PipelineOptionsFactory$Builder.as(PipelineOptionsFactory.java:289)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.testingPipelineOptions(TestPipeline.java:392)
>   at 
> org.apache.beam.sdk.testing.TestPipeline.create(TestPipeline.java:257)
>   at 
> org.apache.beam.runners.core.SplittableParDoTest.(SplittableParDoTest.java:149)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at