[jira] [Commented] (BEAM-2730) make BeamRecord an immutable type

2017-08-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119406#comment-16119406
 ] 

ASF GitHub Bot commented on BEAM-2730:
--

Github user XuMingmin closed the pull request at:

https://github.com/apache/beam/pull/3692


> make BeamRecord an immutable type
> -
>
> Key: BEAM-2730
> URL: https://issues.apache.org/jira/browse/BEAM-2730
> Project: Beam
>  Issue Type: Sub-task
>  Components: dsl-sql
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
>  Labels: dsl_sql_merge, dsl_sql_review
>
> Refer to discussion 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTnbIjE



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (BEAM-2730) make BeamRecord an immutable type

2017-08-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115044#comment-16115044
 ] 

ASF GitHub Bot commented on BEAM-2730:
--

GitHub user XuMingmin opened a pull request:

https://github.com/apache/beam/pull/3692

[BEAM-2730] make BeamRecord an immutable type

@robertwb 

Ps, some lines are expected to delete with #3691 and #3689

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/XuMingmin/beam BEAM-2730

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3692.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3692


commit ca0663d48fe82c20600966dd2d2852e27d6ca5ed
Author: mingmxu 
Date:   2017-08-04T22:29:10Z

make BeamRecord an immutable type




> make BeamRecord an immutable type
> -
>
> Key: BEAM-2730
> URL: https://issues.apache.org/jira/browse/BEAM-2730
> Project: Beam
>  Issue Type: Improvement
>  Components: dsl-sql
>Reporter: Xu Mingmin
>Assignee: Xu Mingmin
>  Labels: dsl_sql_merge, dsl_sql_review
>
> Refer to discussion 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTnbIjE



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)