[
https://issues.apache.org/jira/browse/BEAM-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119723#comment-16119723
]
ASF GitHub Bot commented on BEAM-2740:
--
GitHub user xumingming opened a pull request:
https://github.com/apache/beam/pull/3708
[BEAM-2740] introduce the new InnerBeamSqlEnv/BeamSqlEnv
Summary:
* Simplified `BeamSqlEnv`: now you can only register UDF/UDAF in
`BeamSqlEnv`, and `BeamSqlEnv` just record the udfName -> udfClass mapping,
actually work will be done by `InnerBeamSqlEnv`.
* `BeamSqlEnv` is only used by the surface API classes.
* `InnerBeamSqlEnv` is actually the old `BeamSqlEnv`, it holds schema and
planner.
* `InnerBeamSqlEnv` is only used by the implementation classes.
* `BeamSqlEnv` is converted to `InnerBeamSqlEnv` automatically in `BeamSql`
and `BeamSqlCli`.
* `BeamSqlEnv` and `InnerBeamSqlEnv` are quite different, so can not share
the same interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xumingming/beam BEAM-2740
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3708
commit 80491a26456e1a4a1ffc0e4e00290de63b9617e4
Author: James Xu
Date: 2017-08-09T10:54:54Z
[BEAM-2740] introduce InnerBeamSqlEnv to extract implementation related
logic from BeamSqlEnv
commit 5074f830347e07ef0ba8396bc9a464a37eb089ec
Author: James Xu
Date: 2017-08-09T11:04:46Z
add licence declaration for BeamRelTest
> update exposed methods in BeamSqlEnv
>
>
> Key: BEAM-2740
> URL: https://issues.apache.org/jira/browse/BEAM-2740
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
>Reporter: Xu Mingmin
>Assignee: James Xu
> Labels: dsl_sql_merge, dsl_sql_review
>
> Refer to
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTmFcis
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTmFciw
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
