[jira] [Commented] (BEAM-2744) rename size() in BeamRecordType

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122950#comment-16122950
 ] 

ASF GitHub Bot commented on BEAM-2744:
--

Github user xumingming closed the pull request at:

https://github.com/apache/beam/pull/3702


> rename size() in BeamRecordType
> ---
>
> Key: BEAM-2744
> URL: https://issues.apache.org/jira/browse/BEAM-2744
> Project: Beam
>  Issue Type: Sub-task
>  Components: dsl-sql
>Reporter: Xu Mingmin
>Assignee: James Xu
>  Labels: dsl_sql_merge, dsl_sql_review
> Fix For: Not applicable
>
>
> refer to 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTrrtwc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-2744) rename size() in BeamRecordType

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117995#comment-16117995
 ] 

ASF GitHub Bot commented on BEAM-2744:
--

GitHub user xumingming opened a pull request:

https://github.com/apache/beam/pull/3702

[BEAM-2744] rename BeamRecordType#size()

Summary:

* BeamRecord.size() -> BeamRecord.getFieldCount()
* BeamRecordType.size() -> BeamRecordType.getFieldCount()
* remove BeamRecord.valueInString()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xumingming/beam 
BEAM-2744-rename-BeamRecordType-size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3702.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3702


commit 6466a9fcfa0dcc4c73d05a98ffd8727584d190b4
Author: James Xu 
Date:   2017-08-08T07:15:59Z

[BEAM-2744] rename BeamRecordType#size()

commit ff10e1a5a64e9b7c607b965a9b5bc318465f1995
Author: James Xu 
Date:   2017-08-08T07:27:48Z

remove BeamRecord#valueInString()




> rename size() in BeamRecordType
> ---
>
> Key: BEAM-2744
> URL: https://issues.apache.org/jira/browse/BEAM-2744
> Project: Beam
>  Issue Type: Sub-task
>  Components: dsl-sql
>Reporter: Xu Mingmin
>Assignee: James Xu
>  Labels: dsl_sql_merge, dsl_sql_review
>
> refer to 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=BTrrtwc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)