[jira] [Commented] (BEAM-3018) Remove duplicated methods in StructuredCoder

2017-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192697#comment-16192697
 ] 

ASF GitHub Bot commented on BEAM-3018:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3947


> Remove duplicated methods in StructuredCoder
> 
>
> Key: BEAM-3018
> URL: https://issues.apache.org/jira/browse/BEAM-3018
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>
> StructuredCoder has several methods that are totally the same as its parent. 
> We should remove these.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (BEAM-3018) Remove duplicated methods in StructuredCoder

2017-10-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192448#comment-16192448
 ] 

ASF GitHub Bot commented on BEAM-3018:
--

GitHub user CaoManhDat opened a pull request:

https://github.com/apache/beam/pull/3947

[BEAM-3018] Remove duplicated methods in StructuredCoder

Removed `consistentWithEquals(), structuralValue() and 
getEncodedTypeDescriptor()` in `StructuredCoder`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CaoManhDat/beam master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3947.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3947


commit 8d8a213f0ba2f1cceec8e53bba01c8d2a55c8863
Author: Cao Manh Dat 
Date:   2017-10-05T04:28:35Z

[BEAM-3018] Remove duplicated methods in StructuredCoder




> Remove duplicated methods in StructuredCoder
> 
>
> Key: BEAM-3018
> URL: https://issues.apache.org/jira/browse/BEAM-3018
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Cao Manh Dat
>Assignee: Cao Manh Dat
>
> StructuredCoder has several methods that are totally the same as its parent. 
> We should remove these.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)