[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301822#comment-16301822 ] Ahmet Altay commented on BEAM-3070: --- https://github.com/apache/beam/pull/3817 is merged, the work on this issue can resume. > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim >Assignee: Vilhelm von Ehrenheim > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279141#comment-16279141 ] Vilhelm von Ehrenheim commented on BEAM-3070: - Ok, I guess that makes sense. Ill wait until I see the result then. > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim >Assignee: Vilhelm von Ehrenheim > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278890#comment-16278890 ] Eugene Kirpichov commented on BEAM-3070: Thanks! However, I strongly recommend to wait until https://github.com/apache/beam/pull/3817 lands, and recommend to mimic the (simpler and more general) design of that instead. > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim >Assignee: Vilhelm von Ehrenheim > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278786#comment-16278786 ] Vilhelm von Ehrenheim commented on BEAM-3070: - Sure! I'd be happy to. Might need some pointers though. Maybe I'll ask for help in slack in that case. > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1620#comment-1620 ] Ahmet Altay commented on BEAM-3070: --- [~while] I do not believe this is duplicated. Are you still interested in taking this? > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208307#comment-16208307 ] Ahmet Altay commented on BEAM-3070: --- Thank you [~while]. cc: [~chamikara] > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim >Assignee: Ahmet Altay > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK
[ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208296#comment-16208296 ] Vilhelm von Ehrenheim commented on BEAM-3070: - [~altay] Just reported this. I couldn't find any ticket addressing this issue. If duplicated let me know. If not I would be happy to start contributing on this if you think it is suitable. > Add support for windowed filenames in Python SDK > > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Vilhelm von Ehrenheim >Assignee: Ahmet Altay > > The Python SDK's FilebasedSink does not support windowed filenames. Currently > the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The > python SDk only has a somewhat more simple implementation using a text > template and `FileBasedSink._template_to_format()` which does not support > windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
