[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-12-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274396#comment-16274396
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-348495513
 
 
   Thanks @aljoscha !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
> Fix For: 2.3.0
>
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-12-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274394#comment-16274394
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia closed pull request #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/runners/flink/pom.xml b/runners/flink/pom.xml
index a6ab44bcea5..7840c328c9a 100644
--- a/runners/flink/pom.xml
+++ b/runners/flink/pom.xml
@@ -87,10 +87,6 @@
   test
 
 
-  
-  
-
org.apache.beam.sdk.transforms.ParDoLifecycleTest
-  
   org.apache.beam.sdk.testing.ValidatesRunner
   
 org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders,
diff --git 
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
 
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
index d203ffb67dc..fcee0549706 100644
--- 
a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
+++ 
b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
@@ -361,6 +361,16 @@ public void onProcessingTime(long timestamp) throws 
Exception {
 SimplePushbackSideInputDoFnRunner.create(doFnRunner, sideInputs, 
sideInputHandler);
   }
 
+  @Override
+  public void dispose() throws Exception {
+try {
+  super.dispose();
+  checkFinishBundleTimer.cancel(true);
+} finally {
+  doFnInvoker.invokeTeardown();
+}
+  }
+
   @Override
   public void close() throws Exception {
 super.close();
@@ -379,8 +389,6 @@ public void close() throws Exception {
 }
   }
 }
-checkFinishBundleTimer.cancel(true);
-doFnInvoker.invokeTeardown();
   }
 
   private long getPushbackWatermarkHold() {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-12-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274242#comment-16274242
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-348464495
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-12-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274243#comment-16274243
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-348079004
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272147#comment-16272147
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347794162
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272146#comment-16272146
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347901817
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272145#comment-16272145
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-348079004
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270971#comment-16270971
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347901817
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270972#comment-16270972
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347902031
 
 
   Addressed remarks, waiting for CI to be happy before merge, thanks !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270892#comment-16270892
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

aljoscha commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347884926
 
 
   This LGTM and you can also move the timer cleanup code.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270891#comment-16270891
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

aljoscha commented on a change in pull request #4174: [BEAM-3244] Ensure 
execution of teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#discussion_r153809786
 
 

 ##
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
 ##
 @@ -380,7 +386,6 @@ public void close() throws Exception {
   }
 }
 checkFinishBundleTimer.cancel(true);
 
 Review comment:
   yes, you're right. This can also be moved to `dispose()`.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270697#comment-16270697
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347853776
 
 
   @aljoscha It should be ok now, please take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268995#comment-16268995
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-347579364
 
 
   Waiting for #4170 to be merged with the enabled tests before rebasing this 
one and that we can go ahead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-28 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268984#comment-16268984
 ] 

Ismaël Mejía commented on BEAM-3244:


Just for reference the tests break only in streaming mode.

> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265467#comment-16265467
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on a change in pull request #4174: [BEAM-3244] Ensure 
execution of teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#discussion_r153012280
 
 

 ##
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
 ##
 @@ -380,7 +386,6 @@ public void close() throws Exception {
   }
 }
 checkFinishBundleTimer.cancel(true);
 
 Review comment:
   @aljoscha I had the doubt if this one should be moved to dispose too, given 
that close can eventually not be called. WDYT ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265465#comment-16265465
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia commented on issue #4174: [BEAM-3244] Ensure execution of teardown 
method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#issuecomment-346875689
 
 
   Run Flink ValidatesRunner


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265463#comment-16265463
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

GitHub user iemejia opened a pull request:

https://github.com/apache/beam/pull/4174

[BEAM-3244] Ensure execution of teardown method on Flink's DoFnOperator

Follow this checklist to help us incorporate your contribution quickly and 
easily:

 - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
 - [x] Each commit in the pull request should have a meaningful subject 
line and body.
 - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
 - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
 - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
 - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/iemejia/beam BEAM-3244-dofn-flink

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/4174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4174


commit c72084d3f08e92ddb7adb5199ed3fb757fc344cf
Author: Ismaël Mejía 
Date:   2017-11-24T17:31:51Z

[BEAM-3244] Ensure execution of teardown method on Flink's DoFnOperator




> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (BEAM-3244) Flink runner does not respect ParDo's lifecycle on case of exceptions

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265462#comment-16265462
 ] 

ASF GitHub Bot commented on BEAM-3244:
--

iemejia opened a new pull request #4174: [BEAM-3244] Ensure execution of 
teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> -
>
> Key: BEAM-3244
> URL: https://issues.apache.org/jira/browse/BEAM-3244
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 2.2.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>
> The lifecycle of the DoFn is not respected in case of exception in any of the 
> lifecycle methods after setup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)