[jira] [Commented] (BEAM-3654) Port FilterExamplesTest off DoFnTester

2018-08-22 Thread Tim Robertson (JIRA) 


[ 
https://issues.apache.org/jira/browse/BEAM-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588659#comment-16588659
 ] 

Tim Robertson commented on BEAM-3654:
-

My apologies for the Kudu error.

I have lodged and will fix https://issues.apache.org/jira/browse/BEAM-5193 now 
which was simply a mistake.

> Port FilterExamplesTest off DoFnTester
> --
>
> Key: BEAM-3654
> URL: https://issues.apache.org/jira/browse/BEAM-3654
> Project: Beam
>  Issue Type: Sub-task
>  Components: examples-java
>Reporter: Kenneth Knowles
>Assignee: Mikhail
>Priority: Major
>  Labels: beginner, newbie, starter
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BEAM-3654) Port FilterExamplesTest off DoFnTester

2018-08-10 Thread Mikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/BEAM-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576504#comment-16576504
 ] 

Mikhail commented on BEAM-3654:
---

Also I found out that 
{quote}./gradlew build{quote}
is failing for me on *KuduIOTest#testWrite*. 
It passes with the following code but I didn't try to figure out the reason of 
failure deeply:

{code:java}
for (int i = 1; i <= targetParallelism; i++) {
  expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, 
i));
  expectedWriteLogs.verifyDebug(
  String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
  expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, 
i));
}
// verify all entries written
for (int n = 0; n < numberRecords; n++) {
  expectedWriteLogs.verifyDebug(
  String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per 
writer
}
{code}

I made changes in 2 fors.


> Port FilterExamplesTest off DoFnTester
> --
>
> Key: BEAM-3654
> URL: https://issues.apache.org/jira/browse/BEAM-3654
> Project: Beam
>  Issue Type: Sub-task
>  Components: examples-java
>Reporter: Kenneth Knowles
>Priority: Major
>  Labels: beginner, newbie, starter
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (BEAM-3654) Port FilterExamplesTest off DoFnTester

2018-08-09 Thread Mikhail (JIRA) 


[ 
https://issues.apache.org/jira/browse/BEAM-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574855#comment-16574855
 ] 

Mikhail commented on BEAM-3654:
---

Can I pick this task?  

I have already created PR (https://github.com/apache/beam/pull/6194) for it.

> Port FilterExamplesTest off DoFnTester
> --
>
> Key: BEAM-3654
> URL: https://issues.apache.org/jira/browse/BEAM-3654
> Project: Beam
>  Issue Type: Sub-task
>  Components: examples-java
>Reporter: Kenneth Knowles
>Priority: Major
>  Labels: beginner, newbie, starter
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)