[jira] [Commented] (BEAM-3725) Add a test rule which remembers and resets the thread context class loader

2018-02-21 Thread Luke Cwik (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371728#comment-16371728
 ] 

Luke Cwik commented on BEAM-3725:
-

Not urgent.

> Add a test rule which remembers and resets the thread context class loader
> --
>
> Key: BEAM-3725
> URL: https://issues.apache.org/jira/browse/BEAM-3725
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Priority: Minor
>  Labels: newbie, starter
>
> We have several tests that ensure the proper usage of the TCCL but they can 
> be brittle if the test is written improperly.
>  
> This task is to create a JUnit test rule and to replace the existing 
> remember/reset TCCL usages in our tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3725) Add a test rule which remembers and resets the thread context class loader

2018-02-21 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371725#comment-16371725
 ] 

Romain Manni-Bucau commented on BEAM-3725:
--

[~lcwik] if not urgent (like can wait 1 or 2 weeks) sure

> Add a test rule which remembers and resets the thread context class loader
> --
>
> Key: BEAM-3725
> URL: https://issues.apache.org/jira/browse/BEAM-3725
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Priority: Minor
>  Labels: newbie, starter
>
> We have several tests that ensure the proper usage of the TCCL but they can 
> be brittle if the test is written improperly.
>  
> This task is to create a JUnit test rule and to replace the existing 
> remember/reset TCCL usages in our tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3725) Add a test rule which remembers and resets the thread context class loader

2018-02-21 Thread Luke Cwik (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371719#comment-16371719
 ] 

Luke Cwik commented on BEAM-3725:
-

[~rmannibucau], I thought you might be interested in doing this since you have 
been working the most lately in improving the classloader usage.

> Add a test rule which remembers and resets the thread context class loader
> --
>
> Key: BEAM-3725
> URL: https://issues.apache.org/jira/browse/BEAM-3725
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Priority: Minor
>  Labels: newbie, starter
>
> We have several tests that ensure the proper usage of the TCCL but they can 
> be brittle if the test is written improperly.
>  
> This task is to create a JUnit test rule and to replace the existing 
> remember/reset TCCL usages in our tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)