[jira] [Commented] (BEAM-3816) [nexmark] Something is slightly off with Query 6
[
https://issues.apache.org/jira/browse/BEAM-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394939#comment-16394939
]
Etienne Chauchot commented on BEAM-3816:
Good catch!
When I submitted the first Nexmark PR I did a quick doc to ease the review in
which there is pseudo code for each query. It could be quicker for you than
reading the code. Here it is
[https://docs.google.com/document/d/1VgnGiVu8vSfm7Et-xAtQYv0PlEpqeyfmhpQUNPmWRJs/edit#heading=h.wvl8pjxbcudc]
Besides in the nexmark presentation we did at the ApacheCon there is also a
schema for query 6 in slide 29:
https://drive.google.com/open?id=0ByTW9khE9-fVNzhlUUhYN0hWdEk
> [nexmark] Something is slightly off with Query 6
>
>
> Key: BEAM-3816
> URL: https://issues.apache.org/jira/browse/BEAM-3816
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
>Reporter: Andrew Pilloud
>Priority: Major
> Labels: easyfix, newbie, nexmark, test
> Time Spent: 50m
> Remaining Estimate: 0h
>
> java.lang.AssertionError: Query6/Query6.Stamp/ParMultiDo(Anonymous).output:
> wrong pipeline output Expected: <[\{"seller":1048,"price":83609648},
> \{"seller":1052,"price":61788353}, \{"seller":1086,"price":33744823},
> \{"seller":1078,"price":19876735}, \{"seller":1058,"price":50692833},
> \{"seller":1044,"price":6719489}, \{"seller":1096,"price":31287415},
> \{"seller":1095,"price":37004879}, \{"seller":1082,"price":22528654},
> \{"seller":1006,"price":57288736}, \{"seller":1051,"price":3967261},
> \{"seller":1084,"price":6394160}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1000,"price":28257749},
> \{"seller":1055,"price":17087173}, \{"seller":1072,"price":45662210},
> \{"seller":1057,"price":4568399}, \{"seller":1025,"price":29008970},
> \{"seller":1064,"price":85810641}, \{"seller":1040,"price":99819658},
> \{"seller":1014,"price":11256690}, \{"seller":1098,"price":97259323},
> \{"seller":1011,"price":20447800}, \{"seller":1092,"price":77520938},
> \{"seller":1010,"price":53323687}, \{"seller":1060,"price":70032044},
> \{"seller":1062,"price":29076960}, \{"seller":1075,"price":19451464},
> \{"seller":1087,"price":27669185}, \{"seller":1009,"price":22951354},
> \{"seller":1065,"price":71875611}, \{"seller":1063,"price":87596779},
> \{"seller":1021,"price":62918185}, \{"seller":1034,"price":18472448},
> \{"seller":1028,"price":68556008}, \{"seller":1070,"price":92550447}]> but:
> was <[\{"seller":1048,"price":83609648}, \{"seller":1052,"price":61788353},
> \{"seller":1086,"price":33744823}, \{"seller":1078,"price":19876735},
> \{"seller":1058,"price":50692833}, \{"seller":1044,"price":6719489},
> \{"seller":1096,"price":31287415}, \{"seller":1095,"price":37004879},
> \{"seller":1082,"price":22528654}, \{"seller":1006,"price":57288736},
> \{"seller":1051,"price":3967261}, \{"seller":1084,"price":6394160},
> \{"seller":1000,"price":34395558}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1055,"price":17087173},
> \{"seller":1072,"price":45662210}, \{"seller":1057,"price":4568399},
> \{"seller":1025,"price":29008970}, \{"seller":1064,"price":85810641},
> \{"seller":1040,"price":99819658}, \{"seller":1014,"price":11256690},
> \{"seller":1098,"price":97259323}, \{"seller":1011,"price":20447800},
> \{"seller":1092,"price":77520938}, \{"seller":1010,"price":53323687},
> \{"seller":1060,"price":70032044}, \{"seller":1062,"price":29076960},
> \{"seller":1075,"price":19451464}, \{"seller":1087,"price":27669185},
> \{"seller":1009,"price":22951354}, \{"seller":1065,"price":71875611},
> \{"seller":1063,"price":87596779}, \{"seller":1021,"price":62918185},
> \{"seller":1034,"price":18472448}, \{"seller":1028,"price":68556008},
> \{"seller":1070,"price":92550447}]>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-3816) [nexmark] Something is slightly off with Query 6
[
https://issues.apache.org/jira/browse/BEAM-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393146#comment-16393146
]
Andrew Pilloud commented on BEAM-3816:
--
The Query 6 model never worked. The model test hasn't been producing enough
data to actually run a meaningful test. Query 6 requires at least 10 auctions
from the same seller before it does anything interesting. When I increased the
number of events used in the model test to make sure that happened the test
started to hard fail because the model was broken. I rewrote the model to match
what I understood the query to be doing, now the test flaps. When I run it
locally it always passes. The PR that made the model changes is here:
https://github.com/apache/beam/pull/4745
> [nexmark] Something is slightly off with Query 6
>
>
> Key: BEAM-3816
> URL: https://issues.apache.org/jira/browse/BEAM-3816
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
>Reporter: Andrew Pilloud
>Priority: Major
> Labels: easyfix, newbie, nexmark, test
> Time Spent: 50m
> Remaining Estimate: 0h
>
> java.lang.AssertionError: Query6/Query6.Stamp/ParMultiDo(Anonymous).output:
> wrong pipeline output Expected: <[\{"seller":1048,"price":83609648},
> \{"seller":1052,"price":61788353}, \{"seller":1086,"price":33744823},
> \{"seller":1078,"price":19876735}, \{"seller":1058,"price":50692833},
> \{"seller":1044,"price":6719489}, \{"seller":1096,"price":31287415},
> \{"seller":1095,"price":37004879}, \{"seller":1082,"price":22528654},
> \{"seller":1006,"price":57288736}, \{"seller":1051,"price":3967261},
> \{"seller":1084,"price":6394160}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1000,"price":28257749},
> \{"seller":1055,"price":17087173}, \{"seller":1072,"price":45662210},
> \{"seller":1057,"price":4568399}, \{"seller":1025,"price":29008970},
> \{"seller":1064,"price":85810641}, \{"seller":1040,"price":99819658},
> \{"seller":1014,"price":11256690}, \{"seller":1098,"price":97259323},
> \{"seller":1011,"price":20447800}, \{"seller":1092,"price":77520938},
> \{"seller":1010,"price":53323687}, \{"seller":1060,"price":70032044},
> \{"seller":1062,"price":29076960}, \{"seller":1075,"price":19451464},
> \{"seller":1087,"price":27669185}, \{"seller":1009,"price":22951354},
> \{"seller":1065,"price":71875611}, \{"seller":1063,"price":87596779},
> \{"seller":1021,"price":62918185}, \{"seller":1034,"price":18472448},
> \{"seller":1028,"price":68556008}, \{"seller":1070,"price":92550447}]> but:
> was <[\{"seller":1048,"price":83609648}, \{"seller":1052,"price":61788353},
> \{"seller":1086,"price":33744823}, \{"seller":1078,"price":19876735},
> \{"seller":1058,"price":50692833}, \{"seller":1044,"price":6719489},
> \{"seller":1096,"price":31287415}, \{"seller":1095,"price":37004879},
> \{"seller":1082,"price":22528654}, \{"seller":1006,"price":57288736},
> \{"seller":1051,"price":3967261}, \{"seller":1084,"price":6394160},
> \{"seller":1000,"price":34395558}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1055,"price":17087173},
> \{"seller":1072,"price":45662210}, \{"seller":1057,"price":4568399},
> \{"seller":1025,"price":29008970}, \{"seller":1064,"price":85810641},
> \{"seller":1040,"price":99819658}, \{"seller":1014,"price":11256690},
> \{"seller":1098,"price":97259323}, \{"seller":1011,"price":20447800},
> \{"seller":1092,"price":77520938}, \{"seller":1010,"price":53323687},
> \{"seller":1060,"price":70032044}, \{"seller":1062,"price":29076960},
> \{"seller":1075,"price":19451464}, \{"seller":1087,"price":27669185},
> \{"seller":1009,"price":22951354}, \{"seller":1065,"price":71875611},
> \{"seller":1063,"price":87596779}, \{"seller":1021,"price":62918185},
> \{"seller":1034,"price":18472448}, \{"seller":1028,"price":68556008},
> \{"seller":1070,"price":92550447}]>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-3816) [nexmark] Something is slightly off with Query 6
[
https://issues.apache.org/jira/browse/BEAM-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392593#comment-16392593
]
Etienne Chauchot commented on BEAM-3816:
Strange, it was running fine something like 3 days ago. A git bisect could
identify what changed. This query uses a specialized combiner. Maybe something
changed in the Combine in direct runner. Need to take a look.
> [nexmark] Something is slightly off with Query 6
>
>
> Key: BEAM-3816
> URL: https://issues.apache.org/jira/browse/BEAM-3816
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
>Reporter: Andrew Pilloud
>Priority: Major
> Labels: easyfix, newbie, test
> Time Spent: 50m
> Remaining Estimate: 0h
>
> java.lang.AssertionError: Query6/Query6.Stamp/ParMultiDo(Anonymous).output:
> wrong pipeline output Expected: <[\{"seller":1048,"price":83609648},
> \{"seller":1052,"price":61788353}, \{"seller":1086,"price":33744823},
> \{"seller":1078,"price":19876735}, \{"seller":1058,"price":50692833},
> \{"seller":1044,"price":6719489}, \{"seller":1096,"price":31287415},
> \{"seller":1095,"price":37004879}, \{"seller":1082,"price":22528654},
> \{"seller":1006,"price":57288736}, \{"seller":1051,"price":3967261},
> \{"seller":1084,"price":6394160}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1000,"price":28257749},
> \{"seller":1055,"price":17087173}, \{"seller":1072,"price":45662210},
> \{"seller":1057,"price":4568399}, \{"seller":1025,"price":29008970},
> \{"seller":1064,"price":85810641}, \{"seller":1040,"price":99819658},
> \{"seller":1014,"price":11256690}, \{"seller":1098,"price":97259323},
> \{"seller":1011,"price":20447800}, \{"seller":1092,"price":77520938},
> \{"seller":1010,"price":53323687}, \{"seller":1060,"price":70032044},
> \{"seller":1062,"price":29076960}, \{"seller":1075,"price":19451464},
> \{"seller":1087,"price":27669185}, \{"seller":1009,"price":22951354},
> \{"seller":1065,"price":71875611}, \{"seller":1063,"price":87596779},
> \{"seller":1021,"price":62918185}, \{"seller":1034,"price":18472448},
> \{"seller":1028,"price":68556008}, \{"seller":1070,"price":92550447}]> but:
> was <[\{"seller":1048,"price":83609648}, \{"seller":1052,"price":61788353},
> \{"seller":1086,"price":33744823}, \{"seller":1078,"price":19876735},
> \{"seller":1058,"price":50692833}, \{"seller":1044,"price":6719489},
> \{"seller":1096,"price":31287415}, \{"seller":1095,"price":37004879},
> \{"seller":1082,"price":22528654}, \{"seller":1006,"price":57288736},
> \{"seller":1051,"price":3967261}, \{"seller":1084,"price":6394160},
> \{"seller":1000,"price":34395558}, \{"seller":1020,"price":3871757},
> \{"seller":1007,"price":185293}, \{"seller":1031,"price":11840889},
> \{"seller":1080,"price":26896442}, \{"seller":1030,"price":294928},
> \{"seller":1066,"price":26839191}, \{"seller":1055,"price":17087173},
> \{"seller":1072,"price":45662210}, \{"seller":1057,"price":4568399},
> \{"seller":1025,"price":29008970}, \{"seller":1064,"price":85810641},
> \{"seller":1040,"price":99819658}, \{"seller":1014,"price":11256690},
> \{"seller":1098,"price":97259323}, \{"seller":1011,"price":20447800},
> \{"seller":1092,"price":77520938}, \{"seller":1010,"price":53323687},
> \{"seller":1060,"price":70032044}, \{"seller":1062,"price":29076960},
> \{"seller":1075,"price":19451464}, \{"seller":1087,"price":27669185},
> \{"seller":1009,"price":22951354}, \{"seller":1065,"price":71875611},
> \{"seller":1063,"price":87596779}, \{"seller":1021,"price":62918185},
> \{"seller":1034,"price":18472448}, \{"seller":1028,"price":68556008},
> \{"seller":1070,"price":92550447}]>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
