[jira] [Commented] (BEAM-4148) Local server api descriptors contain urls that work on Mac and Linux
[ https://issues.apache.org/jira/browse/BEAM-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568949#comment-16568949 ] Ben Sidhom commented on BEAM-4148: -- Basically, if the reference runner is manually creating its own Docker instances, it should stop doing that and start using the Docker factory. > Local server api descriptors contain urls that work on Mac and Linux > > > Key: BEAM-4148 > URL: https://issues.apache.org/jira/browse/BEAM-4148 > Project: Beam > Issue Type: Improvement > Components: runner-core >Reporter: Ben Sidhom >Priority: Minor > > Docker for Mac does not allow host networking and thus will not allow SDK > harnesses to access runner services via `localhost`. Instead, a special DNS > name is used to refer to the host machine: docker.for.mac.host.internal. > (Note that this value sometimes changes between Docker releases). > We should attempt to detect the host operating system and return different > API descriptors based on this. > See > [https://github.com/bsidhom/beam/commit/3adaeb0d33dc26f0910c1f8af2821cce4ee0b965] > for how this might be done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4148) Local server api descriptors contain urls that work on Mac and Linux
[ https://issues.apache.org/jira/browse/BEAM-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568948#comment-16568948 ] Ben Sidhom commented on BEAM-4148: -- The linked PR should have actually solved this for the Docker environment factory (https://github.com/apache/beam/pull/5392). I actually meant to close this since this is ideally the only place where Docker environments will be created. Where are you still seeing this? > Local server api descriptors contain urls that work on Mac and Linux > > > Key: BEAM-4148 > URL: https://issues.apache.org/jira/browse/BEAM-4148 > Project: Beam > Issue Type: Improvement > Components: runner-core >Reporter: Ben Sidhom >Priority: Minor > > Docker for Mac does not allow host networking and thus will not allow SDK > harnesses to access runner services via `localhost`. Instead, a special DNS > name is used to refer to the host machine: docker.for.mac.host.internal. > (Note that this value sometimes changes between Docker releases). > We should attempt to detect the host operating system and return different > API descriptors based on this. > See > [https://github.com/bsidhom/beam/commit/3adaeb0d33dc26f0910c1f8af2821cce4ee0b965] > for how this might be done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4148) Local server api descriptors contain urls that work on Mac and Linux
[ https://issues.apache.org/jira/browse/BEAM-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568933#comment-16568933 ] Daniel Oliveira commented on BEAM-4148: --- I ran into this issue while trying to get Validates Runner tests working for the Reference Runner. This issue prevents running those on Macs, and most likely will also affect the Flink Validates Runner tests since they use Docker similarly. I'm considering taking this bug, but a bit hesitant since I have very little experience with Docker. What's missing from your example commit that's holding it back from being submitted as a PR? PS: For reference, I also found this link relating to the issue: https://docs.docker.com/docker-for-mac/networking/#use-cases-and-workarounds > Local server api descriptors contain urls that work on Mac and Linux > > > Key: BEAM-4148 > URL: https://issues.apache.org/jira/browse/BEAM-4148 > Project: Beam > Issue Type: Improvement > Components: runner-core >Reporter: Ben Sidhom >Priority: Minor > > Docker for Mac does not allow host networking and thus will not allow SDK > harnesses to access runner services via `localhost`. Instead, a special DNS > name is used to refer to the host machine: docker.for.mac.host.internal. > (Note that this value sometimes changes between Docker releases). > We should attempt to detect the host operating system and return different > API descriptors based on this. > See > [https://github.com/bsidhom/beam/commit/3adaeb0d33dc26f0910c1f8af2821cce4ee0b965] > for how this might be done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
