[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-11 Thread Pablo Estrada (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472175#comment-16472175
 ] 

Pablo Estrada commented on BEAM-4268:
-

I've tested this. Fixed.

> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-11 Thread Pablo Estrada (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472176#comment-16472176
 ] 

Pablo Estrada commented on BEAM-4268:
-

PR was https://github.com/apache/beam/pull/5323

> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-10 Thread Pablo Estrada (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470867#comment-16470867
 ] 

Pablo Estrada commented on BEAM-4268:
-

Do you have Pubsub topics available that I could borrow to test this?

> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-10 Thread Udi Meiri (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470761#comment-16470761
 ] 

Udi Meiri commented on BEAM-4268:
-

Yes, if it was broken for DF (I was testing DR). There are these results using 
TestDataflowRunner, but no DirectRunner equivalent:
test_wordcount_fnapi_it (apache_beam.examples.wordcount_it_test.WordCountIT) 
... ok
test_bigquery_tornadoes_it 
(apache_beam.examples.cookbook.bigquery_tornadoes_it_test.BigqueryTornadoesIT) 
... ok
test_streaming_wordcount_it 
(apache_beam.examples.streaming_wordcount_it_test.StreamingWordCountIT) ... ok
test_wordcount_it (apache_beam.examples.wordcount_it_test.WordCountIT) ... ok
For DirectRunner, run_postcommit.sh only runs apache_beam.examples.wordcount.

> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-10 Thread Pablo Estrada (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470738#comment-16470738
 ] 

Pablo Estrada commented on BEAM-4268:
-

Here's a passing postcommit under that PR. It runs streaming w9ordcount correct?
https://builds.apache.org/job/beam_PostCommit_Python_Verify/4915/console


> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-10 Thread Pablo Estrada (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470737#comment-16470737
 ] 

Pablo Estrada commented on BEAM-4268:
-

Here's a passing postcommit under that PR. It runs streaming w9ordcount correct?
https://builds.apache.org/job/beam_PostCommit_Python_Verify/4915/console


> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Blocker
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-4268) Metrics and State Sampler integration is troublesome in Dataflow

2018-05-10 Thread Udi Meiri (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470734#comment-16470734
 ] 

Udi Meiri commented on BEAM-4268:
-

Should fix error:

NameError: global name 'statesampler' is not defined [while running 'split']

> Metrics and State Sampler integration is troublesome in Dataflow
> 
>
> Key: BEAM-4268
> URL: https://issues.apache.org/jira/browse/BEAM-4268
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Pablo Estrada
>Assignee: Pablo Estrada
>Priority: Major
> Fix For: 2.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Improvements on how dependencies import each other should fix this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)