[jira] [Commented] (BEAM-463) BoundedHeapCoder should be a StandardCoder and not a CustomCoder

2017-04-10 Thread Luke Cwik (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963790#comment-15963790
 ] 

Luke Cwik commented on BEAM-463:


The motivation was about getting introspection into the coder components, even 
if a wrapping coder is only understood by some SDKs, the component coder could 
be understood by a runner and/or reused in other places. I can see the argument 
to treat this is an opaque coder that doesn't encode to anything which makes 
sense outside of the context of a specific SDK.

Also brings up a question as to whether all component coders always be listed 
even for CustomCoder like things?

> BoundedHeapCoder should be a StandardCoder and not a CustomCoder
> 
>
> Key: BEAM-463
> URL: https://issues.apache.org/jira/browse/BEAM-463
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Priority: Minor
>  Labels: backward-incompatible
> Fix For: First stable release
>
>
> The issue is that BoundedHeapCoder does not report component encodings which 
> prevents effective runner inspection of the components.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-463) BoundedHeapCoder should be a StandardCoder and not a CustomCoder

2017-03-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947666#comment-15947666
 ] 

ASF GitHub Bot commented on BEAM-463:
-

Github user aviemzur closed the pull request at:

https://github.com/apache/beam/pull/2108


> BoundedHeapCoder should be a StandardCoder and not a CustomCoder
> 
>
> Key: BEAM-463
> URL: https://issues.apache.org/jira/browse/BEAM-463
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Assignee: Aviem Zur
>Priority: Minor
>  Labels: backward-incompatible
>
> The issue is that BoundedHeapCoder does not report component encodings which 
> prevents effective runner inspection of the components.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-463) BoundedHeapCoder should be a StandardCoder and not a CustomCoder

2017-03-02 Thread Kenneth Knowles (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892939#comment-15892939
 ] 

Kenneth Knowles commented on BEAM-463:
--

What is motivating this? BoundedHeapCoder (and a few similar classes) all have 
a serialized Java comparator inside them.

So if we did this, then we could get into a situation that is a new variation 
on a well-defined coder that has some SDK-defined stuff inside it. The other 
common case is like a KvCoder that has a custom coder for the key or value. 
Only in this case it isn't a component coder but one of the parameters in the 
coder's spec.

[~robertwb] and [~tgroh]] this touches on things we've talked about, regarding 
where SDK-specific code should go

> BoundedHeapCoder should be a StandardCoder and not a CustomCoder
> 
>
> Key: BEAM-463
> URL: https://issues.apache.org/jira/browse/BEAM-463
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Assignee: Aviem Zur
>Priority: Minor
>  Labels: backward-incompatible
>
> The issue is that BoundedHeapCoder does not report component encodings which 
> prevents effective runner inspection of the components.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-463) BoundedHeapCoder should be a StandardCoder and not a CustomCoder

2017-02-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884020#comment-15884020
 ] 

ASF GitHub Bot commented on BEAM-463:
-

GitHub user aviemzur opened a pull request:

https://github.com/apache/beam/pull/2108

[BEAM-463] [BEAM-464] [BEAM-466] BoundedHeapCoder, HolderCoder, 
QuantileStateCoder -> StandardCoder

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aviemzur/beam standard-coders

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2108


commit 31cbd17dc51ea4101e4a22f9a9908a24bd529056
Author: Aviem Zur 
Date:   2017-02-25T04:32:45Z

[BEAM-463] BoundedHeapCoder should be a StandardCoder and not a CustomCoder

commit 9e94a7ffa3a82e2b780e2f06295a8640bb6de8d1
Author: Aviem Zur 
Date:   2017-02-25T04:33:09Z

[BEAM-464] HolderCoder should be a StandardCoder and not a CustomCoder

commit 57162682aae60ebf1f2928ffa37d76a5623294b7
Author: Aviem Zur 
Date:   2017-02-25T04:33:33Z

[BEAM-466] QuantileStateCoder should be a StandardCoder




> BoundedHeapCoder should be a StandardCoder and not a CustomCoder
> 
>
> Key: BEAM-463
> URL: https://issues.apache.org/jira/browse/BEAM-463
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Luke Cwik
>Assignee: Davor Bonaci
>Priority: Minor
>  Labels: backward-incompatible
>
> The issue is that BoundedHeapCoder does not report component encodings which 
> prevents effective runner inspection of the components.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)