[jira] [Commented] (BEAM-5028) getPerDestinationOutputFilenames() is getting processed before write is finished
[ https://issues.apache.org/jira/browse/BEAM-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564812#comment-16564812 ] Jozef Vilcek commented on BEAM-5028: This one is already merged to master a while back but did not make it on to 2.6.0 release candidate. Any change it can be picked up or is it too late? > getPerDestinationOutputFilenames() is getting processed before write is > finished > > > Key: BEAM-5028 > URL: https://issues.apache.org/jira/browse/BEAM-5028 > Project: Beam > Issue Type: Bug > Components: io-java-files >Affects Versions: 2.5.0 >Reporter: Jozef Vilcek >Assignee: Jean-Baptiste Onofré >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > I believe I am hitting a race condition on finalising writes vs notification > events about frites being done. > It looks to me that WriteFilesResult.getPerDestinationOutputFilenames() can > announce files before they are finished: > [https://github.com/apache/beam/blob/release-2.5.0/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java#L799] > This is related to BEAM-3268 where it appears to not be fully fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-5028) getPerDestinationOutputFilenames() is getting processed before write is finished
[ https://issues.apache.org/jira/browse/BEAM-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559408#comment-16559408 ] Jozef Vilcek commented on BEAM-5028: This simple pull request seems to do the trick for my case > getPerDestinationOutputFilenames() is getting processed before write is > finished > > > Key: BEAM-5028 > URL: https://issues.apache.org/jira/browse/BEAM-5028 > Project: Beam > Issue Type: Bug > Components: io-java-files >Affects Versions: 2.5.0 >Reporter: Jozef Vilcek >Assignee: Eugene Kirpichov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > I believe I am hitting a race condition on finalising writes vs notification > events about frites being done. > It looks to me that WriteFilesResult.getPerDestinationOutputFilenames() can > announce files before they are finished: > [https://github.com/apache/beam/blob/release-2.5.0/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java#L799] > This is related to BEAM-3268 where it appears to not be fully fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
