[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944304#comment-15944304
 ] 

ASF GitHub Bot commented on BEAM-772:
-

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2290


> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937153#comment-15937153
 ] 

ASF GitHub Bot commented on BEAM-772:
-

Github user pabloem closed the pull request at:

https://github.com/apache/beam/pull/2290


> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937154#comment-15937154
 ] 

ASF GitHub Bot commented on BEAM-772:
-

GitHub user pabloem reopened a pull request:

https://github.com/apache/beam/pull/2290

[BEAM-772] Querying of both structured and unstructured metrics in Dataflow.

This allows for metrics querying to work with structured names and 
unstructured names alike. It's been tested in both cases.
R: @charlesccychen 
Question: Do you think that `_translate_step_name` should be part of 
`DataflowMetrics`? Or should this function be available somewhere else in the 
`DataflowRunner` or `apiclient.Job` classes, so that other components can use 
it?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pabloem/incubator-beam query-structured-python

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2290


commit 5967a3c7807ddf0c308d52b60c4840eae6414904
Author: Pablo 
Date:   2017-03-22T20:22:32Z

Querying of both structured and unstructured metrics in dataflow.

commit 5b28c7d75ff32bc86166d12f5b796285523a80bf
Author: Pablo 
Date:   2017-03-22T20:27:48Z

Adding PyDoc

commit 661f19bee5bb9745de460bd2f4302c3f1c682648
Author: Pablo 
Date:   2017-03-22T21:07:14Z

Fixing lint issues.




> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937064#comment-15937064
 ] 

ASF GitHub Bot commented on BEAM-772:
-

GitHub user pabloem opened a pull request:

https://github.com/apache/beam/pull/2290

[BEAM-772] Querying of both structured and unstructured metrics in Dataflow.

This allows for metrics querying to work with structured names and 
unstructured names alike. It's been tested in both cases.
R: @charlesccychen 
Question: Do you think that `_translate_step_name` should be part of 
`DataflowMetrics`? Or should this function be available somewhere else in the 
`DataflowRunner` or `apiclient.Job` classes, so that other components can use 
it?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pabloem/incubator-beam query-structured-python

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2290


commit 5967a3c7807ddf0c308d52b60c4840eae6414904
Author: Pablo 
Date:   2017-03-22T20:22:32Z

Querying of both structured and unstructured metrics in dataflow.

commit 5b28c7d75ff32bc86166d12f5b796285523a80bf
Author: Pablo 
Date:   2017-03-22T20:27:48Z

Adding PyDoc




> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933696#comment-15933696
 ] 

ASF GitHub Bot commented on BEAM-772:
-

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2223


> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905919#comment-15905919
 ] 

ASF GitHub Bot commented on BEAM-772:
-

GitHub user pabloem opened a pull request:

https://github.com/apache/beam/pull/2223

[BEAM-772] Adding support for metrics querying in Dataflow Runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pabloem/incubator-beam query-metrics-dataflow

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2223


commit 45d3a17ea9ab1ee8e4d8febd02e0f6c49d939877
Author: Pablo 
Date:   2017-03-11T00:10:31Z

Adding support for metrics querying in Dataflow Runner




> Implement Metrics support for Dataflow Runner
> -
>
> Key: BEAM-772
> URL: https://issues.apache.org/jira/browse/BEAM-772
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-dataflow
>Reporter: Ben Chambers
>Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)