[
https://issues.apache.org/jira/browse/BEAM-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993915#comment-15993915
]
ASF GitHub Bot commented on BEAM-818:
-
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2847
[BEAM-818,BEAM-828] Make tempLocation an inaccessible ValueProvider
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is my first foray into `ValueProvider` and `PipelineOptions`
excitement. The goal: allow users to access the `tempLocation` that they
specify but make it inaccessible to `PTransform.expand(..)` implementations.
The natural way to do this would be to clone and alter the pipeline
options, something that runners also ought to be doing when they tweak them
like `TestDataflowRunner` does. I am informed this is not possible or feasible
in a short timeframe.
So this is a hack that might not actually work that lets `get()` succeed
but makes `isAccessible()` false. Throwing it out there as a strawman as I
don't see a way to do this correctly given today's constraints.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam runtime-ValueProvider
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2847
commit ebfb87a93448b05d1bdac1e919d2d83d41f00405
Author: Kenneth Knowles
Date: 2017-05-02T21:36:52Z
Make tempLocation an inaccessible ValueProvider
> ValueProvider for tempLocation, runner, etc, that is unavailable to
> transforms during construction
> --
>
> Key: BEAM-818
> URL: https://issues.apache.org/jira/browse/BEAM-818
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
>Reporter: Thomas Groh
>Assignee: Kenneth Knowles
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> This stops transforms from changing their operation based on
> construction-time options, and instead requires that configuration to be
> explicit, or to obtain the configuration at runtime.
> https://docs.google.com/document/d/1Wr05cYdqnCfrLLqSk--XmGMGgDwwNwWZaFbxLKvPqEQ/edit#
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)