[jira] [Commented] (BEAM-828) Remove PipelineOptions from construction time in BigQueryIO
[ https://issues.apache.org/jira/browse/BEAM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996138#comment-15996138 ] ASF GitHub Bot commented on BEAM-828: - Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/2873 > Remove PipelineOptions from construction time in BigQueryIO > --- > > Key: BEAM-828 > URL: https://issues.apache.org/jira/browse/BEAM-828 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Thomas Groh >Assignee: Vikas Kedigehalli > Labels: backward-incompatible > Fix For: First stable release > > > BigQueryIO uses PipelineOptions to configure itself at construction time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-828) Remove PipelineOptions from construction time in BigQueryIO
[ https://issues.apache.org/jira/browse/BEAM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995834#comment-15995834 ] ASF GitHub Bot commented on BEAM-828: - GitHub user vikkyrk opened a pull request: https://github.com/apache/beam/pull/2873 [BEAM-828] BigQueryIO: Remove tempLocation usage at pipeline construction time Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- No semantic changes, just moves tempLocation access to runtime. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vikkyrk/incubator-beam bq_templocation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2873.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2873 commit 78ed5740ab97cf6daa99fd62c385ef1c7bc10f35 Author: Vikas Kedigehalli Date: 2017-05-03T22:42:50Z BigQueryIO: Remove tempLocation usage at pipeline construction time > Remove PipelineOptions from construction time in BigQueryIO > --- > > Key: BEAM-828 > URL: https://issues.apache.org/jira/browse/BEAM-828 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Thomas Groh >Assignee: Vikas Kedigehalli > Labels: backward-incompatible > Fix For: First stable release > > > BigQueryIO uses PipelineOptions to configure itself at construction time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-828) Remove PipelineOptions from construction time in BigQueryIO
[ https://issues.apache.org/jira/browse/BEAM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995794#comment-15995794 ] ASF GitHub Bot commented on BEAM-828: - Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/2846 > Remove PipelineOptions from construction time in BigQueryIO > --- > > Key: BEAM-828 > URL: https://issues.apache.org/jira/browse/BEAM-828 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Thomas Groh >Assignee: Vikas Kedigehalli > Labels: backward-incompatible > Fix For: First stable release > > > BigQueryIO uses PipelineOptions to configure itself at construction time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-828) Remove PipelineOptions from construction time in BigQueryIO
[
https://issues.apache.org/jira/browse/BEAM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994217#comment-15994217
]
Kenneth Knowles commented on BEAM-828:
--
Actually [~vikasrk] is already in progress just using
{{ProcessContext.getPipelineOptions()}} directly, which was an alternative I
simply missed.
The move to {{ValueProvider}} has only to do with making new transforms unable
to do the wrong thing, which is also important.
> Remove PipelineOptions from construction time in BigQueryIO
> ---
>
> Key: BEAM-828
> URL: https://issues.apache.org/jira/browse/BEAM-828
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-gcp
>Reporter: Thomas Groh
>Assignee: Vikas Kedigehalli
> Labels: backward-incompatible
> Fix For: First stable release
>
>
> BigQueryIO uses PipelineOptions to configure itself at construction time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (BEAM-828) Remove PipelineOptions from construction time in BigQueryIO
[ https://issues.apache.org/jira/browse/BEAM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994180#comment-15994180 ] Kenneth Knowles commented on BEAM-828: -- Current plan is not to necessarily remove them, but to use them only as a conduit for inaccessible ValueProviders. So that makes this a dupe, too. > Remove PipelineOptions from construction time in BigQueryIO > --- > > Key: BEAM-828 > URL: https://issues.apache.org/jira/browse/BEAM-828 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-gcp >Reporter: Thomas Groh >Assignee: Kenneth Knowles > Labels: backward-incompatible > Fix For: First stable release > > > BigQueryIO uses PipelineOptions to configure itself at construction time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
