[jira] [Commented] (BEAM-940) OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod
[ https://issues.apache.org/jira/browse/BEAM-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054898#comment-16054898 ] Kenneth Knowles commented on BEAM-940: -- Ah it has been renamed to {{ByteBuddyOnTimerInvokerFactory}} because actually the thing that is cached is specifically the generated code. > OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod > > > Key: BEAM-940 > URL: https://issues.apache.org/jira/browse/BEAM-940 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Innocent >Priority: Trivial > > Right now it is a {{LoadingCache>}}. > It is correct but just a bit less straightforward then we might like. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-940) OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod
[ https://issues.apache.org/jira/browse/BEAM-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051270#comment-16051270 ] Innocent commented on BEAM-940: --- I could not find any map (reference to the key) or anything matching LoadingCache>. I checked OnTimerInvokers (I think the class should be called OnTimerInvokerGenerator) and ByteBuddyDoFnOnTimerInvokerFactory there is definitely something that I am missing. > OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod > > > Key: BEAM-940 > URL: https://issues.apache.org/jira/browse/BEAM-940 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Innocent >Priority: Trivial > > Right now it is a {{LoadingCache>}}. > It is correct but just a bit less straightforward then we might like. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (BEAM-940) OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod
[ https://issues.apache.org/jira/browse/BEAM-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051271#comment-16051271 ] Innocent commented on BEAM-940: --- I could not find any map (reference to the key) or anything matching LoadingCache>. I checked OnTimerInvokers (I think the class should be called OnTimerInvokerGenerator) and ByteBuddyDoFnOnTimerInvokerFactory there is definitely something that I am missing. > OnTimerInvokers: key the cache with a (Class, id) tuple or OnTimerMethod > > > Key: BEAM-940 > URL: https://issues.apache.org/jira/browse/BEAM-940 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Innocent >Priority: Trivial > > Right now it is a {{LoadingCache>}}. > It is correct but just a bit less straightforward then we might like. -- This message was sent by Atlassian JIRA (v6.4.14#64029)