Mark Liu created BEAM-3841:
------------------------------

             Summary: Python TestDataflowRunner should oeverride run_pipeline
                 Key: BEAM-3841
                 URL: https://issues.apache.org/jira/browse/BEAM-3841
             Project: Beam
          Issue Type: Test
          Components: testing
            Reporter: Mark Liu
            Assignee: Mark Liu


[TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py]
 is inherited from 
[DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py].
 Basically, it wraps DataflowRunner.run_pipeline and provide more test actions. 

However DataflowRunner.run renamed to run_pipeline in [this 
commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635],
 but run function in TestDataflowRunner didn't change.

We should change it accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to