[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=106078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106078 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 26/May/18 00:35 Start Date: 26/May/18 00:35 Worklog Time Spent: 10m Work Description: robertwb commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-392220906 (And actually just taking a dependency causes issues due to shadowing, but copying doesn't seem like the right solution either.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 106078) Time Spent: 4.5h (was: 4h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 4.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=106076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106076 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 26/May/18 00:29 Start Date: 26/May/18 00:29 Worklog Time Spent: 10m Work Description: robertwb commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-392220354 In porting the Flink runner to master, I found it uses the LocalFilesystem artifact server (which was moved in this PR). This is because it does its own staging (after creating the job) based on what was staged through the staging API. Taking a dependency on the DirectRunner is ugly; is that preferable to reverting these changes? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 106076) Time Spent: 4h 20m (was: 4h 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 4h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105774
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 24/May/18 23:20
Start Date: 24/May/18 23:20
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #5370: [BEAM-2885] Move the
ReferenceRunner Job Service, Artifact Services to the DirectRunner module
URL: https://github.com/apache/beam/pull/5370
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/direct-java/build.gradle b/runners/direct-java/build.gradle
index af99b5b5bc2..893f21149b5 100644
--- a/runners/direct-java/build.gradle
+++ b/runners/direct-java/build.gradle
@@ -64,6 +64,7 @@ dependencies {
shadow library.java.slf4j_api
shadow library.java.hamcrest_core
shadow library.java.junit
+ shadow library.java.args4j
testRuntime project(path: ":beam-sdks-java-harness")
shadowTest project(path: ":beam-sdks-java-core", configuration: "shadowTest")
shadowTest project(path: ":beam-runners-core-java", configuration:
"shadowTest")
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
similarity index 97%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
index e11125f75a3..146a091fbbe 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.beam.artifact.local;
+package org.apache.beam.runners.direct.portable.artifact;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
@@ -29,7 +29,7 @@
* A location where the results of an {@link
LocalFileSystemArtifactStagerService} are stored and
* where the retrieval service retrieves them from.
*/
-public class LocalArtifactStagingLocation {
+class LocalArtifactStagingLocation {
/**
* Create a new {@link LocalArtifactStagingLocation} rooted at the specified
location, creating
* any directories or subdirectories as necessary.
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
similarity index 98%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
index 73afcdcba96..7372ce7fb39 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.beam.artifact.local;
+package org.apache.beam.runners.direct.portable.artifact;
import com.google.protobuf.ByteString;
import io.grpc.Status;
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java
similarity index 95%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java
index 049d6147633..6e72737bb84 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java
@@ -16,7 +16,7 @@
* limitations under the License.
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105391 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422565 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServiceTest.java ## @@ -6,17 +6,17 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: whitespace added to license header This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105391) Time Spent: 4h (was: 3h 50m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 4h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105384 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422540 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalServiceTest.java ## @@ -14,9 +15,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: whitespace added to license header This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105384) Time Spent: 3h 20m (was: 3h 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105383 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422545 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerServiceTest.java ## @@ -14,9 +15,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: whitespace added to license header This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105383) Time Spent: 3h 20m (was: 3h 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105388 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422510 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocationTest.java ## @@ -14,9 +15,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: whitespace added to license header This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105388) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105390 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190421992 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java ## @@ -14,9 +15,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: remove added whitespace This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105390) Time Spent: 3h 50m (was: 3h 40m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3h 50m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105385 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422159 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java ## @@ -14,10 +14,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: remove added whitespace This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105385) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105386
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 23/May/18 22:51
Start Date: 23/May/18 22:51
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5370:
[BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the
DirectRunner module
URL: https://github.com/apache/beam/pull/5370#discussion_r190422404
##
File path: runners/direct-java/build.gradle
##
@@ -57,12 +57,14 @@ dependencies {
compile project(path: ":beam-runners-core-java", configuration: "shadow")
compile project(path: ":beam-runners-local-java-core", configuration:
"shadow")
compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile project(path: ":beam-sdks-java-fn-execution", configuration:
"shadow")
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.joda_time
shadow library.java.findbugs_jsr305
shadow library.java.slf4j_api
shadow library.java.hamcrest_core
shadow library.java.junit
+ shadow library.java.args4j
Review comment:
It was the job server that had it which you deleted below.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105386)
Time Spent: 3.5h (was: 3h 20m)
> Support job+artifact APIs locally
> -
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
>Reporter: Henning Rohde
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105387 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190421966 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java ## @@ -1,4 +1,5 @@ /* + * Review comment: nit: remove added whitespace This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105387) Time Spent: 3.5h (was: 3h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=105389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105389 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 23/May/18 22:51 Start Date: 23/May/18 22:51 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190422084 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/package-info.java ## @@ -14,9 +15,9 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: nit: remove added whitespace This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 105389) Time Spent: 3h 40m (was: 3.5h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 3h 40m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104859 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 23:40 Start Date: 22/May/18 23:40 Worklog Time Spent: 10m Work Description: tgroh commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190085785 ## File path: runners/local-artifact-service-java/pom.xml ## @@ -1,137 +0,0 @@ - Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104859) Time Spent: 2h 50m (was: 2h 40m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2h 50m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104860
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 22/May/18 23:40
Start Date: 22/May/18 23:40
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5370:
[BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the
DirectRunner module
URL: https://github.com/apache/beam/pull/5370#discussion_r190085558
##
File path: runners/direct-java/build.gradle
##
@@ -57,12 +57,14 @@ dependencies {
compile project(path: ":beam-runners-core-java", configuration: "shadow")
compile project(path: ":beam-runners-local-java-core", configuration:
"shadow")
compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile project(path: ":beam-sdks-java-fn-execution", configuration:
"shadow")
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.joda_time
shadow library.java.findbugs_jsr305
shadow library.java.slf4j_api
shadow library.java.hamcrest_core
shadow library.java.junit
+ shadow library.java.args4j
Review comment:
It's not a dependency of that module.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104860)
Time Spent: 3h (was: 2h 50m)
> Support job+artifact APIs locally
> -
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
>Reporter: Henning Rohde
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 3h
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104861
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 22/May/18 23:40
Start Date: 22/May/18 23:40
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5370:
[BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the
DirectRunner module
URL: https://github.com/apache/beam/pull/5370#discussion_r190085807
##
File path: settings.gradle
##
@@ -50,8 +50,6 @@ include "beam-runners-google-cloud-dataflow-java"
project(":beam-runners-google-cloud-dataflow-java").dir =
file("runners/google-cloud-dataflow-java")
include "beam-runners-java-fn-execution"
project(":beam-runners-java-fn-execution").dir =
file("runners/java-fn-execution")
-include "beam-local-artifact-service-java"
-project(":beam-local-artifact-service-java").dir =
file("runners/local-artifact-service-java")
include "beam-runners-local-java-core"
project(":beam-runners-local-java-core").dir = file("runners/local-java")
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104861)
Time Spent: 3h 10m (was: 3h)
> Support job+artifact APIs locally
> -
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
>Reporter: Henning Rohde
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104834 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 22:07 Start Date: 22/May/18 22:07 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-391156501 The Job Server proper, as implemented here, is probably going to be ~100 lines of code that's pretty tightly integrated with the `PortableDirectRunner`. If/when we have a more abstract implementation, the DirectRunner can migrate to use that interface, but the current implementation is basically only going to exercise ~5 methods on the `PortableDirectRunner` which don't have a coherent interface. That might be a good followup, though. I would generally not expect to see the `LocalArtifactServer` be reused. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104834) Time Spent: 2h 40m (was: 2.5h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2h 40m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104822 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190064795 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocationTest.java ## @@ -1,22 +1,25 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104822) Time Spent: 1h 50m (was: 1h 40m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h 50m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104821 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190064994 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/package-info.java ## @@ -6,18 +6,18 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104821) Time Spent: 1h 40m (was: 1.5h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h 40m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104830 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190066187 ## File path: runners/local-artifact-service-java/pom.xml ## @@ -1,137 +0,0 @@ - Review comment: remove `local-artifact-service-java` from `runners/pom.xml` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104830) Time Spent: 2.5h (was: 2h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104825 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190065417 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServiceTest.java ## @@ -6,17 +6,17 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104825) Time Spent: 2h 10m (was: 2h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2h 10m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104823 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190065380 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalServiceTest.java ## @@ -1,22 +1,25 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104823) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h 50m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104820 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190064483 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/package-info.java ## @@ -0,0 +1,23 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at Review comment: ditto This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104820) Time Spent: 1.5h (was: 1h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104824 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190065075 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java ## @@ -1,22 +1,25 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104824) Time Spent: 2h (was: 1h 50m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104828
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 22/May/18 21:59
Start Date: 22/May/18 21:59
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5370:
[BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the
DirectRunner module
URL: https://github.com/apache/beam/pull/5370#discussion_r190065176
##
File path: runners/direct-java/build.gradle
##
@@ -57,12 +57,14 @@ dependencies {
compile project(path: ":beam-runners-core-java", configuration: "shadow")
compile project(path: ":beam-runners-local-java-core", configuration:
"shadow")
compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile project(path: ":beam-sdks-java-fn-execution", configuration:
"shadow")
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.joda_time
shadow library.java.findbugs_jsr305
shadow library.java.slf4j_api
shadow library.java.hamcrest_core
shadow library.java.junit
+ shadow library.java.args4j
Review comment:
should we remove args4j from reference runner as a dependency?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104828)
> Support job+artifact APIs locally
> -
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
>Reporter: Henning Rohde
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104826
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 22/May/18 21:59
Start Date: 22/May/18 21:59
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5370:
[BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the
DirectRunner module
URL: https://github.com/apache/beam/pull/5370#discussion_r190065786
##
File path: settings.gradle
##
@@ -50,8 +50,6 @@ include "beam-runners-google-cloud-dataflow-java"
project(":beam-runners-google-cloud-dataflow-java").dir =
file("runners/google-cloud-dataflow-java")
include "beam-runners-java-fn-execution"
project(":beam-runners-java-fn-execution").dir =
file("runners/java-fn-execution")
-include "beam-local-artifact-service-java"
-project(":beam-local-artifact-service-java").dir =
file("runners/local-artifact-service-java")
include "beam-runners-local-java-core"
project(":beam-runners-local-java-core").dir = file("runners/local-java")
Review comment:
remove `beam-runners-reference-job-server`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104826)
Time Spent: 2h 10m (was: 2h)
> Support job+artifact APIs locally
> -
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
>Reporter: Henning Rohde
>Assignee: Thomas Groh
>Priority: Major
> Labels: portability
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104819 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190064453 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java ## @@ -1,22 +1,25 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104819) Time Spent: 1.5h (was: 1h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104829 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190064911 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java ## @@ -14,10 +14,11 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. + * Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104829) Time Spent: 2.5h (was: 2h 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104827 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 21:59 Start Date: 22/May/18 21:59 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#discussion_r190065398 ## File path: runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerServiceTest.java ## @@ -1,22 +1,25 @@ /* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information Review comment: revert license header change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104827) Time Spent: 2h 20m (was: 2h 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 2h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104721 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 17:59 Start Date: 22/May/18 17:59 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-391084551 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104721) Time Spent: 1h 10m (was: 1h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h 10m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104722 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 17:59 Start Date: 22/May/18 17:59 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-391061959 run java precommit - failed in MQTTIO This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104722) Time Spent: 1h 20m (was: 1h 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104677 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 22/May/18 16:49 Start Date: 22/May/18 16:49 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service, Artifact Services to the DirectRunner module URL: https://github.com/apache/beam/pull/5370#issuecomment-391061959 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104677) Time Spent: 1h (was: 50m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 1h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104133
]
ASF GitHub Bot logged work on BEAM-2885:
Author: ASF GitHub Bot
Created on: 21/May/18 17:21
Start Date: 21/May/18 17:21
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #5369: [BEAM-2885] Move the
Local Artifact Services to the DirectRunner
URL: https://github.com/apache/beam/pull/5369
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/direct-java/build.gradle b/runners/direct-java/build.gradle
index f0e6b74de69..220f4fcffb9 100644
--- a/runners/direct-java/build.gradle
+++ b/runners/direct-java/build.gradle
@@ -56,6 +56,7 @@ dependencies {
compile project(path: ":beam-runners-core-construction-java", configuration:
"shadow")
compile project(path: ":beam-runners-core-java", configuration: "shadow")
compile project(path: ":beam-runners-local-java-core", configuration:
"shadow")
+ compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.joda_time
shadow library.java.findbugs_jsr305
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
similarity index 97%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
index e11125f75a3..146a091fbbe 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalArtifactStagingLocation.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalArtifactStagingLocation.java
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.beam.artifact.local;
+package org.apache.beam.runners.direct.portable.artifact;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
@@ -29,7 +29,7 @@
* A location where the results of an {@link
LocalFileSystemArtifactStagerService} are stored and
* where the retrieval service retrieves them from.
*/
-public class LocalArtifactStagingLocation {
+class LocalArtifactStagingLocation {
/**
* Create a new {@link LocalArtifactStagingLocation} rooted at the specified
location, creating
* any directories or subdirectories as necessary.
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
similarity index 98%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
index 73afcdcba96..7372ce7fb39 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalService.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactRetrievalService.java
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.beam.artifact.local;
+package org.apache.beam.runners.direct.portable.artifact;
import com.google.protobuf.ByteString;
import io.grpc.Status;
diff --git
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java
similarity index 95%
rename from
runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
rename to
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerService.java
index 049d6147633..3f84e75c4da 100644
---
a/runners/local-artifact-service-java/src/main/java/org/apache/beam/artifact/local/LocalFileSystemArtifactStagerService.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/arti
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=104132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104132 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 21/May/18 17:21 Start Date: 21/May/18 17:21 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5369: [BEAM-2885] Move the Local Artifact Services to the DirectRunner URL: https://github.com/apache/beam/pull/5369#issuecomment-390722361 Closing this in favor of #5370, which does both artifact and job services. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104132) Time Spent: 40m (was: 0.5h) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 40m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=103494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103494 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 18/May/18 17:37 Start Date: 18/May/18 17:37 Worklog Time Spent: 10m Work Description: tgroh commented on issue #5370: [BEAM-2885] Move the ReferenceRunner Job Service module URL: https://github.com/apache/beam/pull/5370#issuecomment-390279408 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 103494) Time Spent: 0.5h (was: 20m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 0.5h > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=102268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102268 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 15/May/18 20:05 Start Date: 15/May/18 20:05 Worklog Time Spent: 10m Work Description: tgroh opened a new pull request #5370: [BEAM-2885] Move the ReferenceRunner Job Service module URL: https://github.com/apache/beam/pull/5370 Move to the DirectRunner module, for convenience. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `./gradlew build` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 102268) Time Spent: 20m (was: 10m) > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 20m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-2885) Support job+artifact APIs locally
[ https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=102267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102267 ] ASF GitHub Bot logged work on BEAM-2885: Author: ASF GitHub Bot Created on: 15/May/18 20:04 Start Date: 15/May/18 20:04 Worklog Time Spent: 10m Work Description: tgroh opened a new pull request #5369: [BEAM-2885] Move the Local Artifact Services to the DirectRunner URL: https://github.com/apache/beam/pull/5369 This is expected to be the only user, at the current time. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `./gradlew build` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 102267) Time Spent: 10m Remaining Estimate: 0h > Support job+artifact APIs locally > - > > Key: BEAM-2885 > URL: https://issues.apache.org/jira/browse/BEAM-2885 > Project: Beam > Issue Type: Sub-task > Components: runner-dataflow >Reporter: Henning Rohde >Assignee: Thomas Groh >Priority: Major > Labels: portability > Time Spent: 10m > Remaining Estimate: 0h > > As per https://s.apache.org/beam-job-api, use local support for > submission-side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
