[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[
https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=88558=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88558
]
ASF GitHub Bot logged work on BEAM-3910:
Author: ASF GitHub Bot
Created on: 06/Apr/18 18:38
Start Date: 06/Apr/18 18:38
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4941: BEAM-3910: Add
float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/pkg/beam/coder.go b/sdks/go/pkg/beam/coder.go
index c7a2d4cabc5..b7f62186135 100644
--- a/sdks/go/pkg/beam/coder.go
+++ b/sdks/go/pkg/beam/coder.go
@@ -107,6 +107,13 @@ func inferCoder(t FullType) (*coder.Coder, error) {
return nil, err
}
return {Kind: coder.Custom, T: t, Custom:
c}, nil
+ case reflectx.Float32, reflectx.Float64:
+ c, err := coderx.NewFloat(t.Type())
+ if err != nil {
+ return nil, err
+ }
+ return {Kind: coder.Custom, T: t, Custom:
c}, nil
+
case reflectx.String, reflectx.ByteSlice:
// TODO(BEAM-3580): we should stop encoding string
using the bytecoder. It forces
// conversions at runtime in inconvenient places.
diff --git a/sdks/go/pkg/beam/core/runtime/coderx/float.go
b/sdks/go/pkg/beam/core/runtime/coderx/float.go
new file mode 100644
index 000..403cd30ac1d
--- /dev/null
+++ b/sdks/go/pkg/beam/core/runtime/coderx/float.go
@@ -0,0 +1,75 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coderx
+
+import (
+ "fmt"
+ "math"
+ "math/bits"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/coder"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+func init() {
+ runtime.RegisterFunction(encFloat)
+ runtime.RegisterFunction(decFloat)
+}
+
+func encFloat(v typex.T) []byte {
+ var val float64
+ switch n := v.(type) {
+ case float32:
+ val = float64(n)
+ case float64:
+ val = n
+ default:
+ panic(fmt.Sprintf("received unknown value type: want a float,
got %T", n))
+ }
+
+ return encVarUintZ(bits.ReverseBytes64(math.Float64bits(val)))
+}
+
+func decFloat(t reflect.Type, data []byte) (typex.T, error) {
+ uval, err := decVarUintZ(reflectx.Uint64, data)
+ if err != nil {
+ return nil, fmt.Errorf("invalid float encoding for: %v", data)
+ }
+
+ n := math.Float64frombits(bits.ReverseBytes64(uval.(uint64)))
+ switch t.Kind() {
+ case reflect.Float64:
+ return n, nil
+ case reflect.Float32:
+ return float32(n), nil
+ default:
+ panic(fmt.Sprintf("unreachable statement: expected a float, got
%v", t))
+ }
+}
+
+// NewFloat returns a coder for the given float type. It uses the same
+// encoding scheme as the gob package.
+func NewFloat(t reflect.Type) (*coder.CustomCoder, error) {
+ switch t.Kind() {
+ case reflect.Float32, reflect.Float64:
+ return coder.NewCustomCoder("float", t, encFloat, decFloat)
+ default:
+ return nil, fmt.Errorf("not a float type: %v", t)
+ }
+}
diff --git a/sdks/go/pkg/beam/core/runtime/coderx/float_test.go
b/sdks/go/pkg/beam/core/runtime/coderx/float_test.go
new file mode 100644
index 000..460057e900b
--- /dev/null
+++ b/sdks/go/pkg/beam/core/runtime/coderx/float_test.go
@@ -0,0 +1,50 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=88448=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88448 ] ASF GitHub Bot logged work on BEAM-3910: Author: ASF GitHub Bot Created on: 06/Apr/18 15:11 Start Date: 06/Apr/18 15:11 Worklog Time Spent: 10m Work Description: wcn3 commented on issue #4941: BEAM-3910: Add float support for the Go SDK. URL: https://github.com/apache/beam/pull/4941#issuecomment-379283848 @lukecwik please merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88448) Time Spent: 1h 20m (was: 1h 10m) Remaining Estimate: 22h 40m (was: 22h 50m) > Support floating point values in Go SDK > --- > > Key: BEAM-3910 > URL: https://issues.apache.org/jira/browse/BEAM-3910 > Project: Beam > Issue Type: New Feature > Components: sdk-go >Reporter: Bill Neubauer >Assignee: Bill Neubauer >Priority: Major > Original Estimate: 24h > Time Spent: 1h 20m > Remaining Estimate: 22h 40m > > The Go SDK supports all the integer types of the language, but does not > support floats. > My plan for coding is to use the same technique the gob package uses, which > results in a compact encoding for simple values. > [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] > with rationale explained in > https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details > The resulting uint is then encoded using the existing coders in coderx. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=88075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88075 ] ASF GitHub Bot logged work on BEAM-3910: Author: ASF GitHub Bot Created on: 05/Apr/18 15:11 Start Date: 05/Apr/18 15:11 Worklog Time Spent: 10m Work Description: wcn3 commented on issue #4941: BEAM-3910: Add float support for the Go SDK. URL: https://github.com/apache/beam/pull/4941#issuecomment-378970726 PTAL, this is ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88075) Time Spent: 1h 10m (was: 1h) Remaining Estimate: 22h 50m (was: 23h) > Support floating point values in Go SDK > --- > > Key: BEAM-3910 > URL: https://issues.apache.org/jira/browse/BEAM-3910 > Project: Beam > Issue Type: New Feature > Components: sdk-go >Reporter: Bill Neubauer >Assignee: Bill Neubauer >Priority: Major > Original Estimate: 24h > Time Spent: 1h 10m > Remaining Estimate: 22h 50m > > The Go SDK supports all the integer types of the language, but does not > support floats. > My plan for coding is to use the same technique the gob package uses, which > results in a compact encoding for simple values. > [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] > with rationale explained in > https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details > The resulting uint is then encoded using the existing coders in coderx. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=87650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87650 ] ASF GitHub Bot logged work on BEAM-3910: Author: ASF GitHub Bot Created on: 04/Apr/18 17:21 Start Date: 04/Apr/18 17:21 Worklog Time Spent: 10m Work Description: wcn3 commented on issue #4941: BEAM-3910: Add float support for the Go SDK. URL: https://github.com/apache/beam/pull/4941#issuecomment-378678676 Tested this out. The grades example now runs on Cloud Dataflow, exercising all the float serialization machinery. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87650) Time Spent: 1h (was: 50m) Remaining Estimate: 23h (was: 23h 10m) > Support floating point values in Go SDK > --- > > Key: BEAM-3910 > URL: https://issues.apache.org/jira/browse/BEAM-3910 > Project: Beam > Issue Type: New Feature > Components: sdk-go >Reporter: Bill Neubauer >Assignee: Bill Neubauer >Priority: Major > Original Estimate: 24h > Time Spent: 1h > Remaining Estimate: 23h > > The Go SDK supports all the integer types of the language, but does not > support floats. > My plan for coding is to use the same technique the gob package uses, which > results in a compact encoding for simple values. > [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] > with rationale explained in > https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details > The resulting uint is then encoded using the existing coders in coderx. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[
https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=87649=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87649
]
ASF GitHub Bot logged work on BEAM-3910:
Author: ASF GitHub Bot
Created on: 04/Apr/18 17:21
Start Date: 04/Apr/18 17:21
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #4941:
BEAM-3910: Add float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941#discussion_r179219605
##
File path: sdks/go/pkg/beam/core/runtime/coderx/float.go
##
@@ -0,0 +1,75 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coderx
+
+import (
+ "fmt"
+ "math"
+ "math/bits"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/coder"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+func init() {
+ runtime.RegisterFunction(encFloat)
+ runtime.RegisterFunction(decFloat)
+}
+
+func encFloat(v typex.T) []byte {
+ var val float64
+ switch n := v.(type) {
+ case float32:
+ val = float64(n)
+ case float64:
+ val = n
+ default:
+ panic(fmt.Sprintf("received unknown value type: want a float,
got %T", n))
+ }
+
+ return encVarUintZ(bits.ReverseBytes64(math.Float64bits(val)))
+}
+
+func decFloat(t reflect.Type, data []byte) (typex.T, error) {
+ uval, err := decVarUintZ(reflectx.Uint64, data)
+ if err != nil {
+ return nil, fmt.Errorf("invalid float encoding for: %v", data)
+ }
+
+ n := math.Float64frombits(bits.ReverseBytes64(uval.(uint64)))
+ switch t.Kind() {
+ case reflect.Float64:
+ return n, nil
+ case reflect.Float32:
+ return float32(n), nil
+ default:
+ panic(fmt.Sprintf("unreachable statement: expected a float, got
%v", t))
+ }
+}
+
+// NewFloat returns a coder for the given float type. It uses the same
+// encoding scheme as the gob package.
+func NewFloat(t reflect.Type) (*coder.CustomCoder, error) {
Review comment:
If it's faster, I'd like to do it for integer types as well since those are
more prevalent. I'm happy to explore that as future work, but for now, I'd like
to leave it like this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87649)
Time Spent: 50m (was: 40m)
Remaining Estimate: 23h 10m (was: 23h 20m)
> Support floating point values in Go SDK
> ---
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Major
> Original Estimate: 24h
> Time Spent: 50m
> Remaining Estimate: 23h 10m
>
> The Go SDK supports all the integer types of the language, but does not
> support floats.
> My plan for coding is to use the same technique the gob package uses, which
> results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210]
> with rationale explained in
> https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[
https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=83389=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83389
]
ASF GitHub Bot logged work on BEAM-3910:
Author: ASF GitHub Bot
Created on: 22/Mar/18 23:55
Start Date: 22/Mar/18 23:55
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4941:
BEAM-3910: Add float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941#discussion_r176606245
##
File path: sdks/go/pkg/beam/core/runtime/coderx/float.go
##
@@ -0,0 +1,75 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package coderx
+
+import (
+ "fmt"
+ "math"
+ "math/bits"
+ "reflect"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/graph/coder"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+)
+
+func init() {
+ runtime.RegisterFunction(encFloat)
+ runtime.RegisterFunction(decFloat)
+}
+
+func encFloat(v typex.T) []byte {
+ var val float64
+ switch n := v.(type) {
+ case float32:
+ val = float64(n)
+ case float64:
+ val = n
+ default:
+ panic(fmt.Sprintf("received unknown value type: want a float,
got %T", n))
+ }
+
+ return encVarUintZ(bits.ReverseBytes64(math.Float64bits(val)))
+}
+
+func decFloat(t reflect.Type, data []byte) (typex.T, error) {
+ uval, err := decVarUintZ(reflectx.Uint64, data)
+ if err != nil {
+ return nil, fmt.Errorf("invalid float encoding for: %v", data)
+ }
+
+ n := math.Float64frombits(bits.ReverseBytes64(uval.(uint64)))
+ switch t.Kind() {
+ case reflect.Float64:
+ return n, nil
+ case reflect.Float32:
+ return float32(n), nil
+ default:
+ panic(fmt.Sprintf("unreachable statement: expected a float, got
%v", t))
+ }
+}
+
+// NewFloat returns a coder for the given float type. It uses the same
+// encoding scheme as the gob package.
+func NewFloat(t reflect.Type) (*coder.CustomCoder, error) {
Review comment:
Given there are only 2 types, perhaps do them separately to avoid the
reflect.Type everywhere? I.e.,
NewFloat32
NewFloat64
encFloat32
etc
Presumably faster, too, but not sure if it matters.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 83389)
Time Spent: 0.5h (was: 20m)
Remaining Estimate: 23.5h (was: 23h 40m)
> Support floating point values in Go SDK
> ---
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Major
> Original Estimate: 24h
> Time Spent: 0.5h
> Remaining Estimate: 23.5h
>
> The Go SDK supports all the integer types of the language, but does not
> support floats.
> My plan for coding is to use the same technique the gob package uses, which
> results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210]
> with rationale explained in
> https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[
https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=83390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83390
]
ASF GitHub Bot logged work on BEAM-3910:
Author: ASF GitHub Bot
Created on: 22/Mar/18 23:55
Start Date: 22/Mar/18 23:55
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4941:
BEAM-3910: Add float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941#discussion_r176606474
##
File path: sdks/go/pkg/beam/core/runtime/graphx/v1/v1.proto
##
@@ -46,6 +46,8 @@ message Type {
UINT32 = 10;
UINT64 = 11;
STRING = 12;
+FLOAT32 = 13;
Review comment:
Don't we need changes to EncodeType/DecodeType as well that use them?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 83390)
Time Spent: 0.5h (was: 20m)
Remaining Estimate: 23.5h (was: 23h 40m)
> Support floating point values in Go SDK
> ---
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Major
> Original Estimate: 24h
> Time Spent: 0.5h
> Remaining Estimate: 23.5h
>
> The Go SDK supports all the integer types of the language, but does not
> support floats.
> My plan for coding is to use the same technique the gob package uses, which
> results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210]
> with rationale explained in
> https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=83378=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83378 ] ASF GitHub Bot logged work on BEAM-3910: Author: ASF GitHub Bot Created on: 22/Mar/18 23:01 Start Date: 22/Mar/18 23:01 Worklog Time Spent: 10m Work Description: wcn3 commented on issue #4941: BEAM-3910: Add float support for the Go SDK. URL: https://github.com/apache/beam/pull/4941#issuecomment-375485190 @herohde This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 83378) Time Spent: 20m (was: 10m) Remaining Estimate: 23h 40m (was: 23h 50m) > Support floating point values in Go SDK > --- > > Key: BEAM-3910 > URL: https://issues.apache.org/jira/browse/BEAM-3910 > Project: Beam > Issue Type: New Feature > Components: sdk-go >Reporter: Bill Neubauer >Assignee: Bill Neubauer >Priority: Major > Original Estimate: 24h > Time Spent: 20m > Remaining Estimate: 23h 40m > > The Go SDK supports all the integer types of the language, but does not > support floats. > My plan for coding is to use the same technique the gob package uses, which > results in a compact encoding for simple values. > [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] > with rationale explained in > https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details > The resulting uint is then encoded using the existing coders in coderx. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3910) Support floating point values in Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=83377=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83377 ] ASF GitHub Bot logged work on BEAM-3910: Author: ASF GitHub Bot Created on: 22/Mar/18 23:01 Start Date: 22/Mar/18 23:01 Worklog Time Spent: 10m Work Description: wcn3 opened a new pull request #4941: BEAM-3910: Add float support for the Go SDK. URL: https://github.com/apache/beam/pull/4941 Adds support for floating point types with an efficient encoding scheme. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 83377) Time Spent: 10m Remaining Estimate: 23h 50m (was: 24h) > Support floating point values in Go SDK > --- > > Key: BEAM-3910 > URL: https://issues.apache.org/jira/browse/BEAM-3910 > Project: Beam > Issue Type: New Feature > Components: sdk-go >Reporter: Bill Neubauer >Assignee: Bill Neubauer >Priority: Major > Original Estimate: 24h > Time Spent: 10m > Remaining Estimate: 23h 50m > > The Go SDK supports all the integer types of the language, but does not > support floats. > My plan for coding is to use the same technique the gob package uses, which > results in a compact encoding for simple values. > [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] > with rationale explained in > https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details > The resulting uint is then encoded using the existing coders in coderx. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
