[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116846 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 08:36 Start Date: 28/Jun/18 08:36 Worklog Time Spent: 10m Work Description: iemejia commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400957810 Run Java Precommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116846) Time Spent: 2h 40m (was: 2.5h) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116772 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:47 Start Date: 28/Jun/18 04:47 Worklog Time Spent: 10m Work Description: kennknowles commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198706546 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,9 @@ page at http://checkstyle.sourceforge.net/config.html --> - + > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116771 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:46 Start Date: 28/Jun/18 04:46 Worklog Time Spent: 10m Work Description: kennknowles commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198706423 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,9 @@ page at http://checkstyle.sourceforge.net/config.html --> - + > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116769 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:39 Start Date: 28/Jun/18 04:39 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198705614 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,9 @@ page at http://checkstyle.sourceforge.net/config.html --> - + > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[
https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116767
]
ASF GitHub Bot logged work on BEAM-4394:
Author: ASF GitHub Bot
Created on: 28/Jun/18 04:23
Start Date: 28/Jun/18 04:23
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5797: [BEAM-4394] Spotless Java everywhere
URL: https://github.com/apache/beam/pull/5797#discussion_r198704400
##
File path:
examples/java/src/main/java/org/apache/beam/examples/MinimalWordCount.java
##
@@ -104,9 +104,11 @@ public static void main(String[] args) {
.apply(Count.perElement())
// Apply a MapElements transform that formats our PCollection of word
counts into a
// printable string, suitable for writing to an output file.
-.apply(MapElements
Review comment:
The examples have always been a funky place where manual formatting plays a
role. We could back off and make spotless opt-out and let the exampls opt-out.
Or really we should probably not apply the BeamModulePlugin to the examples.
They should be written entirely as user code with self-sufficient build
configuration. That doesn't come free, though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 116767)
Time Spent: 2h (was: 1h 50m)
> Consider enabling spotless java format throughout codebase
> --
>
> Key: BEAM-4394
> URL: https://issues.apache.org/jira/browse/BEAM-4394
> Project: Beam
> Issue Type: New Feature
> Components: build-system
>Reporter: Kenneth Knowles
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> "Spotless" can enforce - and automatically restore - automatic Java
> formatting. Whenever formatting is off, it tells a user the exact command to
> fix it.
> It isn't (just) about code layout, it is about automation. We have pretty
> strict style rules enforced by checkstyle. The most efficient way to fix up a
> file is with autoformat. But if the autoformat hits a bunch of irrelevant
> lines, that is annoying for a reviewer and obscures git blame.
> If we enforce autoformat all the time, then it makes sure that autoformatting
> a particular PR has minimal effects and is always safe to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116765 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:22 Start Date: 28/Jun/18 04:22 Worklog Time Spent: 10m Work Description: kennknowles commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198704224 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -241,20 +241,14 @@ page at http://checkstyle.sourceforge.net/config.html --> --> + > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116766 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:22 Start Date: 28/Jun/18 04:22 Worklog Time Spent: 10m Work Description: kennknowles commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198704216 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,7 @@ page at http://checkstyle.sourceforge.net/config.html --> - + Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116766) Time Spent: 1h 50m (was: 1h 40m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116761 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:13 Start Date: 28/Jun/18 04:13 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198703326 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,7 @@ page at http://checkstyle.sourceforge.net/config.html --> - + Review comment: Can you add context why this needs to be disabled? And maybe a tracking JIRA if it should eventually be re-enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116761) Time Spent: 1.5h (was: 1h 20m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116760 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:13 Start Date: 28/Jun/18 04:13 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198703458 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -117,7 +117,7 @@ page at http://checkstyle.sourceforge.net/config.html --> - Review comment: I recognize some of the checks in this file as covered by ErrorProne as well. I've filed [[BEAM-4668]](https://issues.apache.org/jira/browse/BEAM-4668) to clean-up the redundant rules from ErrorProne. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116760) Time Spent: 1h 20m (was: 1h 10m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116762 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:13 Start Date: 28/Jun/18 04:13 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#discussion_r198703375 ## File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml ## @@ -241,20 +241,14 @@ page at http://checkstyle.sourceforge.net/config.html --> --> + > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116759 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:08 Start Date: 28/Jun/18 04:08 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400904781 @swegner yea I just sent mail about this, because I think getting the 25 checkstyle failures to pass is something that I'd like to do as a follow-up. I have confirmed that they are all `JavadocParagraph` where spotless has revealed real HTML errors or `LineLength` which usually means some IDE formatted a multiline string so that when spotless indented it because > 100 chars. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116759) Time Spent: 1h 10m (was: 1h) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116757 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 04:03 Start Date: 28/Jun/18 04:03 Worklog Time Spent: 10m Work Description: swegner commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400904101 Do you think this plugin will eventually replace checkstyle completely? From glancing over their docs it seems pretty powerful and I can't wait to enable for the webpage markdown. If you think this will replace Checkstyle, would you mind filing a follow-up JIRA to start migrating rules? And if you think we'll still need both, I think it's still preferable to migrate the rules that we can, since this gives auto-fixes and Checkstyle doesn't. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116757) Time Spent: 1h (was: 50m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[
https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116752
]
ASF GitHub Bot logged work on BEAM-4394:
Author: ASF GitHub Bot
Created on: 28/Jun/18 04:00
Start Date: 28/Jun/18 04:00
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5797:
[BEAM-4394] Spotless Java everywhere
URL: https://github.com/apache/beam/pull/5797#discussion_r198701786
##
File path:
examples/java/src/main/java/org/apache/beam/examples/MinimalWordCount.java
##
@@ -104,9 +104,11 @@ public static void main(String[] args) {
.apply(Count.perElement())
// Apply a MapElements transform that formats our PCollection of word
counts into a
// printable string, suitable for writing to an output file.
-.apply(MapElements
Review comment:
It's a bit unfortunate that there's no way to preserve manually formatted
line-breaks like this, particularly for examples. But I think it's a small
price to pay.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 116752)
Time Spent: 50m (was: 40m)
> Consider enabling spotless java format throughout codebase
> --
>
> Key: BEAM-4394
> URL: https://issues.apache.org/jira/browse/BEAM-4394
> Project: Beam
> Issue Type: New Feature
> Components: build-system
>Reporter: Kenneth Knowles
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> "Spotless" can enforce - and automatically restore - automatic Java
> formatting. Whenever formatting is off, it tells a user the exact command to
> fix it.
> It isn't (just) about code layout, it is about automation. We have pretty
> strict style rules enforced by checkstyle. The most efficient way to fix up a
> file is with autoformat. But if the autoformat hits a bunch of irrelevant
> lines, that is annoying for a reviewer and obscures git blame.
> If we enforce autoformat all the time, then it makes sure that autoformatting
> a particular PR has minimal effects and is always safe to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116684 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 00:03 Start Date: 28/Jun/18 00:03 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400868043 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116684) Time Spent: 0.5h (was: 20m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116685 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 28/Jun/18 00:03 Start Date: 28/Jun/18 00:03 Worklog Time Spent: 10m Work Description: vectorijk commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400868081 It seems checkstyle is not happy in some modules. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116685) Time Spent: 40m (was: 0.5h) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116641 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 27/Jun/18 22:36 Start Date: 27/Jun/18 22:36 Worklog Time Spent: 10m Work Description: apilloud commented on issue #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797#issuecomment-400851489 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116641) Time Spent: 20m (was: 10m) > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > "Spotless" can enforce - and automatically restore - automatic Java > formatting. Whenever formatting is off, it tells a user the exact command to > fix it. > It isn't (just) about code layout, it is about automation. We have pretty > strict style rules enforced by checkstyle. The most efficient way to fix up a > file is with autoformat. But if the autoformat hits a bunch of irrelevant > lines, that is annoying for a reviewer and obscures git blame. > If we enforce autoformat all the time, then it makes sure that autoformatting > a particular PR has minimal effects and is always safe to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4394) Consider enabling spotless java format throughout codebase
[ https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116639 ] ASF GitHub Bot logged work on BEAM-4394: Author: ASF GitHub Bot Created on: 27/Jun/18 22:29 Start Date: 27/Jun/18 22:29 Worklog Time Spent: 10m Work Description: kennknowles opened a new pull request #5797: [BEAM-4394] Spotless Java everywhere URL: https://github.com/apache/beam/pull/5797 This turns on spotless Java universally and applies it to all the Java code. When I did it just for the SQL module, one thing that came up was when the license header had a javadoc comments (started with `/**` instead of `/*`) it would get reformatted. So I did a search for that and fix the last two cases. Then I just ran `./gradlew spotlessJava`. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Spark --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116639) Time Spent: 10m Remaining Estimate: 0h > Consider enabling spotless java format throughout codebase > -- > > Key: BEAM-4394 > URL: https://issues.apache.org/jira/browse/BEAM-4394 > Project: Beam > Issue Type: New Feature > Components: build-system >Reporter: Kenneth Knowles >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > "Spotless" can enforce - and a
