[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=124146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124146 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 17/Jul/18 17:28 Start Date: 17/Jul/18 17:28 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-405662285 Thanks for fixing this up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124146) Time Spent: 1.5h (was: 1h 20m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Fix For: 2.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123130 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 14/Jul/18 00:15 Start Date: 14/Jul/18 00:15 Worklog Time Spent: 10m Work Description: tweise closed pull request #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 204f22fde87..8868b6e9f24 100644 --- a/.gitignore +++ b/.gitignore @@ -10,7 +10,8 @@ **/.gogradle/**/* **/gogradle.lock **/build/**/* -sdks/go/**/vendor/**/* +sdks/**/vendor/**/* +runners/**/vendor/**/* **/.gradletasknamecache # Ignore files generated by the Maven build process. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123130) Time Spent: 1h 20m (was: 1h 10m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Fix For: 2.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123084=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123084 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 23:13 Start Date: 13/Jul/18 23:13 Worklog Time Spent: 10m Work Description: angoenka edited a comment on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404975918 Sure, I will add the following to the list. I hope that if we accidentally ignore valid file then we will catch it soon in the build. ``` sdks/**/vendor/**/* runners/**/vendor/**/* ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123084) Time Spent: 1h 10m (was: 1h) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123083 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 23:12 Start Date: 13/Jul/18 23:12 Worklog Time Spent: 10m Work Description: angoenka edited a comment on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404975918 Sure, I will add the following to the list. I hope that if we accidentally ignore valid file then the we will catch it soon in the build. ``` sdks/**/vendor/**/* runners/**/vendor/**/* ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123083) Time Spent: 1h (was: 50m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123081 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 23:11 Start Date: 13/Jul/18 23:11 Worklog Time Spent: 10m Work Description: angoenka edited a comment on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404975918 Sure, I will add the following to the list. I hope that if we accidentally ignore valid file then the we will catch it soon in the build. `sdks/**/vendor/**/* runners/**/vendor/**/*` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123081) Time Spent: 50m (was: 40m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123080 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 23:11 Start Date: 13/Jul/18 23:11 Worklog Time Spent: 10m Work Description: angoenka commented on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404975918 Sure, I will add the following to the list. I hope that if we accidentally ignore valid file then the we will catch it soon in the build. `sdks/**/vendor/**/* runners/**/vendor/**/*` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123080) Time Spent: 40m (was: 0.5h) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123075 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 22:34 Start Date: 13/Jul/18 22:34 Worklog Time Spent: 10m Work Description: tweise commented on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404970402 There are a few more vendor files that should me moved out of sight: ``` runners/gcp/gcemd/vendor/ runners/gcp/gcsproxy/vendor/ sdks/java/container/vendor/ sdks/python/container/vendor/ ``` I think the existing entry `sdks/go/**/vendor/**/*` can be augmented to capture the other sdk container builds also? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123075) Time Spent: 0.5h (was: 20m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123059=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123059 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 21:57 Start Date: 13/Jul/18 21:57 Worklog Time Spent: 10m Work Description: angoenka commented on issue #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950#issuecomment-404964205 R: @aaltay @tweise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123059) Time Spent: 20m (was: 10m) > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor files which should be > ignored in git -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4787) Ignore genrated vendored files for python container
[ https://issues.apache.org/jira/browse/BEAM-4787?focusedWorklogId=123058=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123058 ] ASF GitHub Bot logged work on BEAM-4787: Author: ASF GitHub Bot Created on: 13/Jul/18 21:56 Start Date: 13/Jul/18 21:56 Worklog Time Spent: 10m Work Description: angoenka opened a new pull request #5950: [BEAM-4787] Ignore generated vendor files in python container build URL: https://github.com/apache/beam/pull/5950 Ignore generated files for python container build Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123058) Time Spent: 10m Remaining Estimate: 0h > Ignore genrated vendored files for python container > --- > > Key: BEAM-4787 > URL: https://issues.apache.org/jira/browse/BEAM-4787 > Project: Beam > Issue Type: Bug > Components: dependencies >Reporter: Ankur Goenka >Assignee: Ankur Goenka >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Python container build generates a bunch of vendor
