[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[ https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=152825=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152825 ] ASF GitHub Bot logged work on BEAM-5114: Author: ASF GitHub Bot Created on: 09/Oct/18 17:50 Start Date: 09/Oct/18 17:50 Worklog Time Spent: 10m Work Description: stale[bot] commented on issue #6191: [BEAM-5114] Create example uber jars URL: https://github.com/apache/beam/pull/6191#issuecomment-428286959 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the d...@beam.apache.org list. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 152825) Time Spent: 1h 50m (was: 1h 40m) > Create example uber jars for supported runners > -- > > Key: BEAM-5114 > URL: https://issues.apache.org/jira/browse/BEAM-5114 > Project: Beam > Issue Type: New Feature > Components: examples-java >Reporter: Ben Sidhom >Assignee: Ben Sidhom >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Producing these artifacts results in several benefits > * Gives an example of how to package user code for different runners > * Enables ad-hoc testing of runner changes against real user pipelines easier > * Enables integration testing end-to-end pipelines against different runner > services -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133718=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133718
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 10/Aug/18 17:47
Start Date: 10/Aug/18 17:47
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209336715
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
This is a subset of the maven archetypes functionality that already exists
since the maven archetypes allows people to edit the code and is useful for
them to build their own pipelines.
Also, in my opinion Maven should only contain libraries and not
applications. It is dangerous to release jars that contain code which contains
unrepackaged libraries to Maven. This is an issue in several prominent projects
where they include guava or some other version inside their jar leading to user
confusion because of MethodNotFoundErrors. In that regard I would be fine with
having these available on the Beam website as direct downloads in addition to
the archetypes quickstart.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133718)
Time Spent: 1h 40m (was: 1.5h)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133715=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133715
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 10/Aug/18 17:41
Start Date: 10/Aug/18 17:41
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209335162
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
Yes, its much cleaner as the owner of the testing is really the runner and
not the examples module.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133715)
Time Spent: 1.5h (was: 1h 20m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133353=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133353
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 22:26
Start Date: 09/Aug/18 22:26
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209098073
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
Yeah, I'd like to challenge and ask why we wouldn't want these to be part of
the release. It would already be useful in my integration tests, and I'd
imagine many beginner users would find a known-green fat jar to be useful for
debugging their setups.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133353)
Time Spent: 1h 20m (was: 1h 10m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133078
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 17:29
Start Date: 09/Aug/18 17:29
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209013571
##
File path: examples/java/portable/build.gradle
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {
+dependencies {
Review comment:
That was an oversight. Fixed.
Do you have a recommendation for the module name here? Should it be
"reference" instead? If I end up making these submodules of their respective
runners, I will probably make this an "examples" submodule.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133078)
Time Spent: 1h 10m (was: 1h)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133076
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 17:29
Start Date: 09/Aug/18 17:29
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209011715
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
That might make more sense. However, we aggregating the example classes and
resources here. Is it reasonable to depend on the examples modules from runner
(sub)modules?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133076)
Time Spent: 1h (was: 50m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133077
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 17:29
Start Date: 09/Aug/18 17:29
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r209013157
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
Having release artifacts was actually one of the motivations for this. This
makes it very easy to pull a runner-enabled example binary and run it against
the beam runner of your choice, which is useful for people experimenting with
Beam for the first time or experimenting with different runners.
@axelmagn is working on integration testing for the Flink runner on a real
deployment; having these published binaries facilitates that, though we could
in theory build a custom jar for tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133077)
Time Spent: 1h (was: 50m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[ https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133040=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133040 ] ASF GitHub Bot logged work on BEAM-5114: Author: ASF GitHub Bot Created on: 09/Aug/18 16:32 Start Date: 09/Aug/18 16:32 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #6191: [BEAM-5114] Create example uber jars URL: https://github.com/apache/beam/pull/6191#issuecomment-411818821 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 133040) Time Spent: 50m (was: 40m) > Create example uber jars for supported runners > -- > > Key: BEAM-5114 > URL: https://issues.apache.org/jira/browse/BEAM-5114 > Project: Beam > Issue Type: New Feature > Components: examples-java >Reporter: Ben Sidhom >Assignee: Ben Sidhom >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Producing these artifacts results in several benefits > * Gives an example of how to package user code for different runners > * Enables ad-hoc testing of runner changes against real user pipelines easier > * Enables integration testing end-to-end pipelines against different runner > services -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133038=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133038
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 16:31
Start Date: 09/Aug/18 16:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r208996456
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
It makes a lot of sense to actually place these builds underneath each
runner instead of underneath examples.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133038)
Time Spent: 0.5h (was: 20m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133039=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133039
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 16:31
Start Date: 09/Aug/18 16:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r208996983
##
File path: examples/java/direct/build.gradle
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {})
Review comment:
We should disable publishing as we don't want these artifacts to be part of
the release.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133039)
Time Spent: 40m (was: 0.5h)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[
https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=133037=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133037
]
ASF GitHub Bot logged work on BEAM-5114:
Author: ASF GitHub Bot
Created on: 09/Aug/18 16:31
Start Date: 09/Aug/18 16:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6191:
[BEAM-5114] Create example uber jars
URL: https://github.com/apache/beam/pull/6191#discussion_r208996828
##
File path: examples/java/portable/build.gradle
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+// Disable default shadow jar closure and include all class files and
resources.
+applyJavaNature(shadowClosure: {
+dependencies {
Review comment:
Why not
```
shadowClosure: {}
```
like in all the others?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 133037)
Time Spent: 20m (was: 10m)
> Create example uber jars for supported runners
> --
>
> Key: BEAM-5114
> URL: https://issues.apache.org/jira/browse/BEAM-5114
> Project: Beam
> Issue Type: New Feature
> Components: examples-java
>Reporter: Ben Sidhom
>Assignee: Ben Sidhom
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Producing these artifacts results in several benefits
> * Gives an example of how to package user code for different runners
> * Enables ad-hoc testing of runner changes against real user pipelines easier
> * Enables integration testing end-to-end pipelines against different runner
> services
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5114) Create example uber jars for supported runners
[ https://issues.apache.org/jira/browse/BEAM-5114?focusedWorklogId=132795=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132795 ] ASF GitHub Bot logged work on BEAM-5114: Author: ASF GitHub Bot Created on: 09/Aug/18 00:37 Start Date: 09/Aug/18 00:37 Worklog Time Spent: 10m Work Description: bsidhom commented on issue #6191: [BEAM-5114] Create example uber jars URL: https://github.com/apache/beam/pull/6191#issuecomment-411599250 R: @lukecwik CC: @axelmagn This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 132795) Time Spent: 10m Remaining Estimate: 0h > Create example uber jars for supported runners > -- > > Key: BEAM-5114 > URL: https://issues.apache.org/jira/browse/BEAM-5114 > Project: Beam > Issue Type: New Feature > Components: examples-java >Reporter: Ben Sidhom >Assignee: Ben Sidhom >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Producing these artifacts results in several benefits > * Gives an example of how to package user code for different runners > * Enables ad-hoc testing of runner changes against real user pipelines easier > * Enables integration testing end-to-end pipelines against different runner > services -- This message was sent by Atlassian JIRA (v7.6.3#76005)
