[jira] [Updated] (BEAM-1129) Umbrella JIRA for Fixing Findbugs
[ https://issues.apache.org/jira/browse/BEAM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-1129: -- Summary: Umbrella JIRA for Fixing Findbugs (was: Umbrella JIRA for Fixing Finbugs) > Umbrella JIRA for Fixing Findbugs > - > > Key: BEAM-1129 > URL: https://issues.apache.org/jira/browse/BEAM-1129 > Project: Beam > Issue Type: Bug >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-1129) Umbrella JIRA for Fixing Finbugs
[ https://issues.apache.org/jira/browse/BEAM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-1129: -- Summary: Umbrella JIRA for Fixing Finbugs (was: Umbrealla JIRA for Fixing Finbugs) > Umbrella JIRA for Fixing Finbugs > > > Key: BEAM-1129 > URL: https://issues.apache.org/jira/browse/BEAM-1129 > Project: Beam > Issue Type: Bug >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BEAM-1129) Umbrealla JIRA for Fixing Finbugs
Neelesh Srinivas Salian created BEAM-1129: - Summary: Umbrealla JIRA for Fixing Finbugs Key: BEAM-1129 URL: https://issues.apache.org/jira/browse/BEAM-1129 Project: Beam Issue Type: Bug Reporter: Neelesh Srinivas Salian Assignee: Neelesh Srinivas Salian Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-413) Mean$CountSum tests for floating point equality
[ https://issues.apache.org/jira/browse/BEAM-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738819#comment-15738819 ] Neelesh Srinivas Salian commented on BEAM-413: -- [~lucasamorim] please let me know if you are still working on this? If not, shall I assign it to myself? > Mean$CountSum tests for floating point equality > --- > > Key: BEAM-413 > URL: https://issues.apache.org/jira/browse/BEAM-413 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > FE_FLOATING_POINT_EQUALITY|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L298]: > Test for floating point equality > Applies to: > [Mean$CountSum.equals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Mean.java#L165]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-412) DisplayData is marked Serializable but contains non-serializable field
[ https://issues.apache.org/jira/browse/BEAM-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-412: Assignee: Neelesh Srinivas Salian > DisplayData is marked Serializable but contains non-serializable field > -- > > Key: BEAM-412 > URL: https://issues.apache.org/jira/browse/BEAM-412 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L304]: > Non-transient non-serializable instance field in serializable class > Applies to: > [DisplayData.entries|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java#L58]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-407) Inconsistent synchronization in OffsetRangeTracker.copy
[ https://issues.apache.org/jira/browse/BEAM-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-407: Assignee: Neelesh Srinivas Salian > Inconsistent synchronization in OffsetRangeTracker.copy > --- > > Key: BEAM-407 > URL: https://issues.apache.org/jira/browse/BEAM-407 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > IS2_INCONSISTENT_SYNC|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L148]: > Inconsistent synchronization > Applies to: > [OffsetRangeTracker.copy|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/OffsetRangeTracker.java#L263]. > Its mutating methods are all marked synchronized otherwise. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-1108) Remove deprecated Dataflow Runner options and update documentation
[
https://issues.apache.org/jira/browse/BEAM-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730373#comment-15730373
]
Neelesh Srinivas Salian commented on BEAM-1108:
---
[~dhalp...@google.com] subtasks would be good to have to spread the work if
there are multiple parts to this..
> Remove deprecated Dataflow Runner options and update documentation
> --
>
> Key: BEAM-1108
> URL: https://issues.apache.org/jira/browse/BEAM-1108
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
>Affects Versions: Not applicable
>Reporter: Daniel Halperin
>Assignee: Daniel Halperin
>Priority: Minor
> Fix For: Not applicable
>
>
> Umbrella bug for removing deprecated {{DataflowPipelineXOptions}}
> configurations, plus improving documentation. Will update bug description as
> more tasks arise.
> 1. Remove the {{TEARDOWN_POLICY}} option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BEAM-1105) Adding Beam's pico Wordcount to the existing examples.
[ https://issues.apache.org/jira/browse/BEAM-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729486#comment-15729486 ] Neelesh Srinivas Salian commented on BEAM-1105: --- [~jbonofre] I agree. Makes sense to bundle them up together. I'll start a thread and we can think it over. I'm thinking a user - specific examples bundle / module would be best to gather all of them. Will see if others have ideas. > Adding Beam's pico Wordcount to the existing examples. > --- > > Key: BEAM-1105 > URL: https://issues.apache.org/jira/browse/BEAM-1105 > Project: Beam > Issue Type: Wish >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: examples > > http://www.jesse-anderson.com/2016/12/beams-pico-wordcount/ > Is a good explanation for the WordCount that would encourage users. > Adding this to the examples and subsequently the docs is a good step to help > new users start from a good foundation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BEAM-1105) Adding Beam's pico Wordcount to the existing examples.
Neelesh Srinivas Salian created BEAM-1105: - Summary: Adding Beam's pico Wordcount to the existing examples. Key: BEAM-1105 URL: https://issues.apache.org/jira/browse/BEAM-1105 Project: Beam Issue Type: Wish Reporter: Neelesh Srinivas Salian Assignee: Neelesh Srinivas Salian Priority: Minor http://www.jesse-anderson.com/2016/12/beams-pico-wordcount/ Is a good explanation for the WordCount that would encourage users. Adding this to the examples and subsequently the docs is a good step to help new users start from a good foundation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-1085) Crunch Runner for Beam
[ https://issues.apache.org/jira/browse/BEAM-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-1085: -- Component/s: runner-ideas > Crunch Runner for Beam > -- > > Key: BEAM-1085 > URL: https://issues.apache.org/jira/browse/BEAM-1085 > Project: Beam > Issue Type: Wish > Components: runner-ideas >Reporter: Neelesh Srinivas Salian > > It came up during the BoF Beam talk earlier last month; opening this JIRA as > a placeholder for if there is interest/ desire to add this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-1089) Jenkins comments on PRs are too many & too large
[ https://issues.apache.org/jira/browse/BEAM-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723857#comment-15723857 ] Neelesh Srinivas Salian commented on BEAM-1089: --- [~kenn], I wanted to add that PR verbosity on the JIRA itself can be reduced. Apache Spark has this setup well where just the PR link shows up on the JIRA rather than the pr bot's messages. > Jenkins comments on PRs are too many & too large > > > Key: BEAM-1089 > URL: https://issues.apache.org/jira/browse/BEAM-1089 > Project: Beam > Issue Type: Bug > Components: testing >Reporter: Kenneth Knowles >Assignee: Jason Kuster > > Lately, I've been finding review comments somewhat drowned out by asfbot > copying build results onto a PR. It also generates a lot of needless email. I > have not yet tried to devise just the right filter, hoping we can just return > to the normal practice of leaving just a commit status. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-1089) Jenkins comments on PRs are too many & too large
[ https://issues.apache.org/jira/browse/BEAM-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723702#comment-15723702 ] Neelesh Srinivas Salian commented on BEAM-1089: --- +1 the failure messages clog up the PR completely. > Jenkins comments on PRs are too many & too large > > > Key: BEAM-1089 > URL: https://issues.apache.org/jira/browse/BEAM-1089 > Project: Beam > Issue Type: Bug > Components: testing >Reporter: Kenneth Knowles >Assignee: Jason Kuster > > Lately, I've been finding review comments somewhat drowned out by asfbot > copying build results onto a PR. It also generates a lot of needless email. I > have not yet tried to devise just the right filter, hoping we can just return > to the normal practice of leaving just a commit status. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BEAM-1085) Crunch Runner for Beam
Neelesh Srinivas Salian created BEAM-1085: - Summary: Crunch Runner for Beam Key: BEAM-1085 URL: https://issues.apache.org/jira/browse/BEAM-1085 Project: Beam Issue Type: Wish Reporter: Neelesh Srinivas Salian It came up during the BoF Beam talk earlier last month; opening this JIRA as a placeholder for if there is interest/ desire to add this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BEAM-1083) Deleting the Weblink for the DatastoreWordCount based on BEAM-498
Neelesh Srinivas Salian created BEAM-1083: - Summary: Deleting the Weblink for the DatastoreWordCount based on BEAM-498 Key: BEAM-1083 URL: https://issues.apache.org/jira/browse/BEAM-1083 Project: Beam Issue Type: Sub-task Reporter: Neelesh Srinivas Salian Assignee: Neelesh Srinivas Salian Priority: Minor Since BEAM-498 removes the DatastoreWordCount, it makes sense to remove the GCP link from the README as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-498) Make DoFnWithContext the new DoFn
[ https://issues.apache.org/jira/browse/BEAM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717038#comment-15717038 ] Neelesh Srinivas Salian commented on BEAM-498: -- Hi [~kenn], Since this JIRA ports DatastoreWordCount example to new DoFn, do you think we should update the README.md to DoFn: https://github.com/apache/incubator-beam/blob/master/examples/java/src/main/java/org/apache/beam/examples/cookbook/README.md I noticed this while working on BEAM-1078. > Make DoFnWithContext the new DoFn > - > > Key: BEAM-498 > URL: https://issues.apache.org/jira/browse/BEAM-498 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles > Labels: backward-incompatible > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-995) Apache Pig DSL
[ https://issues.apache.org/jira/browse/BEAM-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714000#comment-15714000 ] Neelesh Srinivas Salian commented on BEAM-995: -- Shall I take this as well? The SQL DSL work will overlap here so it'd be good to have it together. > Apache Pig DSL > -- > > Key: BEAM-995 > URL: https://issues.apache.org/jira/browse/BEAM-995 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: James Malone > > Apache Pig is still popular and the language is not so large. > Providing a DSL using the Pig language would potentially allow more people to > use Beam (at least during a transition period). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-301) Add a Beam SQL DSL
[ https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684253#comment-15684253 ] Neelesh Srinivas Salian commented on BEAM-301: -- This is helpful [~takidau]. Thank you. Allow me to go through them. I'm travelling at the moment so I should have something up by next week. > Add a Beam SQL DSL > -- > > Key: BEAM-301 > URL: https://issues.apache.org/jira/browse/BEAM-301 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Neelesh Srinivas Salian > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-301) Add a Beam SQL DSL
[ https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675765#comment-15675765 ] Neelesh Srinivas Salian commented on BEAM-301: -- Thanks [~jbonofre]. > Add a Beam SQL DSL > -- > > Key: BEAM-301 > URL: https://issues.apache.org/jira/browse/BEAM-301 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Neelesh Srinivas Salian > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (BEAM-301) Add a Beam SQL DSL
[ https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675765#comment-15675765 ] Neelesh Srinivas Salian edited comment on BEAM-301 at 11/18/16 4:49 AM: Thanks [~jbonofre]. Assigned to myself. was (Author: neelesh77): Thanks [~jbonofre]. > Add a Beam SQL DSL > -- > > Key: BEAM-301 > URL: https://issues.apache.org/jira/browse/BEAM-301 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Neelesh Srinivas Salian > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-301) Add a Beam SQL DSL
[ https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-301: Assignee: Neelesh Srinivas Salian (was: James Malone) > Add a Beam SQL DSL > -- > > Key: BEAM-301 > URL: https://issues.apache.org/jira/browse/BEAM-301 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Neelesh Srinivas Salian > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-301) Add a Beam SQL DSL
[ https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675747#comment-15675747 ] Neelesh Srinivas Salian commented on BEAM-301: -- [~jamesmalone], would it be ok to assign this to me? > Add a Beam SQL DSL > -- > > Key: BEAM-301 > URL: https://issues.apache.org/jira/browse/BEAM-301 > Project: Beam > Issue Type: New Feature > Components: sdk-ideas >Reporter: Jean-Baptiste Onofré >Assignee: James Malone > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-892) revamp quickstart
[ https://issues.apache.org/jira/browse/BEAM-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633536#comment-15633536 ] Neelesh Srinivas Salian commented on BEAM-892: -- Big +1. > revamp quickstart > - > > Key: BEAM-892 > URL: https://issues.apache.org/jira/browse/BEAM-892 > Project: Beam > Issue Type: Bug > Components: website >Reporter: Frances Perry >Assignee: James Malone > > We need to make this quickstart actually a quickstart! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-879) Renaming DeDupExample to DistinctExample
[ https://issues.apache.org/jira/browse/BEAM-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-879: - Description: In BEAM-239, we renamed DeDupExampleTest to DistinctExampleTest. Need to modify DeDupExample to DistinctExample as well. > Renaming DeDupExample to DistinctExample > > > Key: BEAM-879 > URL: https://issues.apache.org/jira/browse/BEAM-879 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Trivial > > In BEAM-239, we renamed DeDupExampleTest to DistinctExampleTest. > Need to modify DeDupExample to DistinctExample as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-879) Renaming DeDupExample to DistinctExample
[ https://issues.apache.org/jira/browse/BEAM-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-879: - Summary: Renaming DeDupExample to DistinctExample (was: Renaming DeDupExample.java to DistinctExample.java) > Renaming DeDupExample to DistinctExample > > > Key: BEAM-879 > URL: https://issues.apache.org/jira/browse/BEAM-879 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Trivial > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BEAM-879) Renaming DeDupExample.java to DistinctExample.java
Neelesh Srinivas Salian created BEAM-879: Summary: Renaming DeDupExample.java to DistinctExample.java Key: BEAM-879 URL: https://issues.apache.org/jira/browse/BEAM-879 Project: Beam Issue Type: Sub-task Reporter: Neelesh Srinivas Salian Assignee: Neelesh Srinivas Salian Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-398) JAXBCoder uses incorrect Double-Checked Locking
[ https://issues.apache.org/jira/browse/BEAM-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-398: - Assignee: Thomas Groh > JAXBCoder uses incorrect Double-Checked Locking > --- > > Key: BEAM-398 > URL: https://issues.apache.org/jira/browse/BEAM-398 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Thomas Groh >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > DC_DOUBLECHECK|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L72]: > Possible double check of field > Applies to: > [JAXBCoder.getContext|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java#L113]. > For details on why this is incorrect, see: > http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-398) JAXBCoder uses incorrect Double-Checked Locking
[ https://issues.apache.org/jira/browse/BEAM-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617173#comment-15617173 ] Neelesh Srinivas Salian commented on BEAM-398: -- Assigning to [~tgroh]. Looks like this is resolved. Not sure if it was merged. If yes, can someone close this? > JAXBCoder uses incorrect Double-Checked Locking > --- > > Key: BEAM-398 > URL: https://issues.apache.org/jira/browse/BEAM-398 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Thomas Groh >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > DC_DOUBLECHECK|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L72]: > Possible double check of field > Applies to: > [JAXBCoder.getContext|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java#L113]. > For details on why this is incorrect, see: > http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-29) Bound Instant values used as timestamps at TIMESTAMP_MIN_VALUE and TIMESTAMP_MAX_VALUE
[ https://issues.apache.org/jira/browse/BEAM-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-29: --- Assignee: Neelesh Srinivas Salian > Bound Instant values used as timestamps at TIMESTAMP_MIN_VALUE and > TIMESTAMP_MAX_VALUE > -- > > Key: BEAM-29 > URL: https://issues.apache.org/jira/browse/BEAM-29 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Neelesh Srinivas Salian >Priority: Minor > > Today the Java SDK allows arbitrary Instant values. If large magnitude > Instant values reach a runner with greater precision but the same modulus for > its representation, overflow will occur. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-409) Incorrect use of Math.ceil in ApproximateQuantiles
[ https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-409: Assignee: Neelesh Srinivas Salian > Incorrect use of Math.ceil in ApproximateQuantiles > -- > > Key: BEAM-409 > URL: https://issues.apache.org/jira/browse/BEAM-409 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L274]: > Integral value cast to double and then passed to Math.ceil > Applies to: > [ApproximateQuanitles|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L349]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
[ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605827#comment-15605827 ] Neelesh Srinivas Salian commented on BEAM-410: -- I can take care of both. Thanks [~swegner] for the clarification. Thanks [~jason.white] > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: > Class defines compareTo(...) and uses Object.equals() > Applies to: > [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-419) Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
[ https://issues.apache.org/jira/browse/BEAM-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-419: Assignee: Neelesh Srinivas Salian > Non-transient non-serializable instance field in > CombineFnUtil$NonSerializableBoundedKeyedCombineFn > --- > > Key: BEAM-419 > URL: https://issues.apache.org/jira/browse/BEAM-419 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L363]: > Non-transient non-serializable instance field in serializable class > Applies to: > [CombineFnUtil$NonSerializableBoundedKeyedCombineFn.context|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java#L170]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-421) StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state
[ https://issues.apache.org/jira/browse/BEAM-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-421: Assignee: Neelesh Srinivas Salian > StateTags$CombiningValueStateTag inherits equals from super class but without > incorporating its state > - > > Key: BEAM-421 > URL: https://issues.apache.org/jira/browse/BEAM-421 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_DOESNT_OVERRIDE_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555]: > Class doesn't override equals in superclass > Applies to: > [StateTags$CombiningValueStateTag|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344]. > CombiningValueStateTag inherits its equals implementation from its parent > class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional > fields which are not included in the equality implementation, which may be > incorrect. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
[ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604098#comment-15604098 ] Neelesh Srinivas Salian commented on BEAM-410: -- [~swegner], can we close this in favor of BEAM-409? Or I can take it up if [~jason.white] is alright with it? > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: > Class defines compareTo(...) and uses Object.equals() > Applies to: > [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (BEAM-688) Repeated 'mvn install' fails on beam-sdks-java-maven-archetypes-starter with undeclared dependency error
[
https://issues.apache.org/jira/browse/BEAM-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598380#comment-15598380
]
Neelesh Srinivas Salian edited comment on BEAM-688 at 10/22/16 7:49 PM:
Seeing this as well.
'mvn clean install' helps avoid it.
was (Author: neelesh77):
Seeing this as well.
`mvn clean install` helps avoid it.
> Repeated 'mvn install' fails on beam-sdks-java-maven-archetypes-starter with
> undeclared dependency error
>
>
> Key: BEAM-688
> URL: https://issues.apache.org/jira/browse/BEAM-688
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-java-extensions
>Reporter: Scott Wegner
>Assignee: Scott Wegner
>Priority: Minor
>
> When building repeatedly using {{mvn install}}, the second build will fail on
> target beam-sdks-java-maven-archetypes-starter with error:
> {noformat}
> [INFO] --- maven-dependency-plugin:2.10:analyze-only (default) @
> beam-sdks-java-maven-archetypes-starter ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]org.slf4j:slf4j-api:jar:1.7.14:runtime
> {noformat}
> For some reason this only happens on the second build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BEAM-688) Repeated 'mvn install' fails on beam-sdks-java-maven-archetypes-starter with undeclared dependency error
[
https://issues.apache.org/jira/browse/BEAM-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598380#comment-15598380
]
Neelesh Srinivas Salian commented on BEAM-688:
--
Seeing this as well.
`mvn clean install` helps avoid it.
> Repeated 'mvn install' fails on beam-sdks-java-maven-archetypes-starter with
> undeclared dependency error
>
>
> Key: BEAM-688
> URL: https://issues.apache.org/jira/browse/BEAM-688
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-java-extensions
>Reporter: Scott Wegner
>Assignee: Scott Wegner
>Priority: Minor
>
> When building repeatedly using {{mvn install}}, the second build will fail on
> target beam-sdks-java-maven-archetypes-starter with error:
> {noformat}
> [INFO] --- maven-dependency-plugin:2.10:analyze-only (default) @
> beam-sdks-java-maven-archetypes-starter ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]org.slf4j:slf4j-api:jar:1.7.14:runtime
> {noformat}
> For some reason this only happens on the second build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (BEAM-239) Rename RemoveDuplicates to Distinct
[ https://issues.apache.org/jira/browse/BEAM-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-239: Assignee: Neelesh Srinivas Salian > Rename RemoveDuplicates to Distinct > --- > > Key: BEAM-239 > URL: https://issues.apache.org/jira/browse/BEAM-239 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Jesse Anderson >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: backward-incompatible, newbie, starter > > I had a really tough time finding this transform in the docs. I suggest > changing this class' name to Distinct instead of RemoveDuplicates. At the > very least, the JavaDoc for RemoveDuplicates should have the word distinct in > it to make this more findable/searchable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
[ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-410: Assignee: Neelesh Srinivas Salian > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: > Class defines compareTo(...) and uses Object.equals() > Applies to: > [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-400) Direct/InProcess runner should use Pubsub publish time timestamp if timestampLabel is not set
[ https://issues.apache.org/jira/browse/BEAM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-400: Assignee: Neelesh Srinivas Salian > Direct/InProcess runner should use Pubsub publish time timestamp if > timestampLabel is not set > - > > Key: BEAM-400 > URL: https://issues.apache.org/jira/browse/BEAM-400 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Daniel Mills >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: newbie, starter > > When using system-provided timestamps for PubsubIO, the timestamp should be > the time at which the message was published to Pubsub, not when it was > received by the pipeline. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-420) Non-transient non-serializable instance field in WatermarkHold
[ https://issues.apache.org/jira/browse/BEAM-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-420: Assignee: Neelesh Srinivas Salian > Non-transient non-serializable instance field in WatermarkHold > -- > > Key: BEAM-420 > URL: https://issues.apache.org/jira/browse/BEAM-420 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L477]: > Non-transient non-serializable instance field in serializable class > Applies to: > [WatermarkHold.timerInternals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/runners/core-java/src/main/java/org/apache/beam/sdk/util/WatermarkHold.java#L81]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-526) Mismatched pipelines give unclear error
[ https://issues.apache.org/jira/browse/BEAM-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-526: Assignee: Neelesh Srinivas Salian > Mismatched pipelines give unclear error > --- > > Key: BEAM-526 > URL: https://issues.apache.org/jira/browse/BEAM-526 > Project: Beam > Issue Type: Bug > Components: sdk-py >Reporter: Ahmet Altay >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: starter > > Mistakenly mixing two pipeline gives an unclear error. This is an error, > however we should improve the error message. > This could be reproduced by trying to flatten two things from different > pipelines. > Improve the message for this assert: > https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/transforms/util.py#L135 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-651) Consider making TypedPValue.setTypeDescriptorInternal no longer Internal
[ https://issues.apache.org/jira/browse/BEAM-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-651: Assignee: Neelesh Srinivas Salian > Consider making TypedPValue.setTypeDescriptorInternal no longer Internal > > > Key: BEAM-651 > URL: https://issues.apache.org/jira/browse/BEAM-651 > Project: Beam > Issue Type: Wish > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: easy, easyfix, starter > > This would give fairly pithy answers to StackOverflow questions sometimes. > When choosing between .getOutputCoder() and .getOutputTypeDescriptor() for a > transform/DoFn we often choose the type, so the coder registry can do its > thing. > This would also give a similar choice between .setCoder(...) and > .setTypeDescriptor(...). > And anyhow we have the intention of removing our practice of the "*Internal" > suffix, so this one might be most easily solved by making it public. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-454) Validate Pubsub Topic exists when reading
[ https://issues.apache.org/jira/browse/BEAM-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-454: Assignee: Neelesh Srinivas Salian > Validate Pubsub Topic exists when reading > - > > Key: BEAM-454 > URL: https://issues.apache.org/jira/browse/BEAM-454 > Project: Beam > Issue Type: Improvement > Components: sdk-java-gcp >Reporter: Frances Perry >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: newbie, starter > > When reading from Pubsub, we should validate the pubsub topic exists at graph > construction time (similar to the way we validate a BQ dataset and table > exist). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (BEAM-659) WindowFn#isCompatible should provide a meaningful reason
[
https://issues.apache.org/jira/browse/BEAM-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian reassigned BEAM-659:
Assignee: Neelesh Srinivas Salian
> WindowFn#isCompatible should provide a meaningful reason
>
>
> Key: BEAM-659
> URL: https://issues.apache.org/jira/browse/BEAM-659
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Neelesh Srinivas Salian
>Priority: Minor
> Labels: easy, easyfix, starter
>
> {{WindowFn#isCompatible(...)}} returns a true/false answer without any
> explanation of why; it suffers from a form of [boolean
> blindness|https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/].
> We alleviated this for {{Coder#isDeterministic()}} by switching to
> {{Coder#verifyDeterministic()}} which can raise an exception describing why
> it is not deterministic (it could just as easily have been a return value).
> We should do the same for {{WindowFn#isCompatible(...)}}.
> See here:
> http://stackoverflow.com/questions/39617897/inputs-to-flatten-had-incompatible-window-windowfns-when-cogroupbykey-with-calen
> (a decent {{toString}} would go a long way, for immediate and trivial
> improvement)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BEAM-555) Documentation in BiqQueryIO.java has awkward cut-and-paste error.
[ https://issues.apache.org/jira/browse/BEAM-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580892#comment-15580892 ] Neelesh Srinivas Salian commented on BEAM-555: -- [~fyellin], please let me know if you are posting a PR on this. Else I can take a stab at it to help understand the code a bit better. > Documentation in BiqQueryIO.java has awkward cut-and-paste error. > - > > Key: BEAM-555 > URL: https://issues.apache.org/jira/browse/BEAM-555 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Frank Yellin >Assignee: Frank Yellin >Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > Twice in the documentation, the sample code reads from > samples.weather_stations and called the resulting TableRow "shakespeare". > I suspect that these lines of code were copied from a different example, and > then only partially modified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
