Migrated the beam-sdks-java-extensions-sorter module to TestPipeline as a JUnit rule.
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/63331aa8 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/63331aa8 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/63331aa8 Branch: refs/heads/python-sdk Commit: 63331aa8aa6314e8469c23a4f4a89fbf287cbc5a Parents: 24ad183 Author: Stas Levin <stasle...@gmail.com> Authored: Tue Dec 20 09:54:57 2016 +0200 Committer: Kenneth Knowles <k...@google.com> Committed: Tue Dec 20 09:55:45 2016 -0800 ---------------------------------------------------------------------- .../org/apache/beam/sdk/extensions/sorter/SortValuesTest.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/63331aa8/sdks/java/extensions/sorter/src/test/java/org/apache/beam/sdk/extensions/sorter/SortValuesTest.java ---------------------------------------------------------------------- diff --git a/sdks/java/extensions/sorter/src/test/java/org/apache/beam/sdk/extensions/sorter/SortValuesTest.java b/sdks/java/extensions/sorter/src/test/java/org/apache/beam/sdk/extensions/sorter/SortValuesTest.java index ebfbd0e..4f77100 100644 --- a/sdks/java/extensions/sorter/src/test/java/org/apache/beam/sdk/extensions/sorter/SortValuesTest.java +++ b/sdks/java/extensions/sorter/src/test/java/org/apache/beam/sdk/extensions/sorter/SortValuesTest.java @@ -24,7 +24,6 @@ import static org.hamcrest.Matchers.is; import static org.junit.Assert.assertThat; import java.util.Arrays; -import org.apache.beam.sdk.Pipeline; import org.apache.beam.sdk.testing.PAssert; import org.apache.beam.sdk.testing.TestPipeline; import org.apache.beam.sdk.transforms.Create; @@ -35,6 +34,7 @@ import org.apache.beam.sdk.values.PCollection; import org.hamcrest.Description; import org.hamcrest.Matcher; import org.hamcrest.TypeSafeMatcher; +import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -43,10 +43,11 @@ import org.junit.runners.JUnit4; @RunWith(JUnit4.class) public class SortValuesTest { + @Rule + public final transient TestPipeline p = TestPipeline.create(); + @Test public void testSecondaryKeySorting() throws Exception { - Pipeline p = TestPipeline.create(); - // Create a PCollection of <Key, <SecondaryKey, Value>> pairs. PCollection<KV<String, KV<String, Integer>>> input = p.apply(