[GitHub] incubator-beam pull request #894: Rename TIMESTAMP_MIN/MAX to POSITIVE/NEGAT...

[tgroh]

Github user tgroh closed the pull request at:

https://github.com/apache/incubator-beam/pull/894


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #894: Rename TIMESTAMP_MIN/MAX to POSITIVE/NEGAT...

[tgroh]

GitHub user tgroh opened a pull request:

https://github.com/apache/incubator-beam/pull/894

Rename TIMESTAMP_MIN/MAX to POSITIVE/NEGATIVE_INFINITY

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This more accurately reflects the way a runner should interact with
these special timestamps.

Add documentation about droppability of elements when a watermark is
positive infinity.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tgroh/incubator-beam timestamp_max_value

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #894


commit a8d27bfab248465a07ef1962aae0159bfe4b13fb
Author: Thomas Groh 
Date:   2016-08-26T22:07:41Z

Rename TIMESTAMP_MIN/MAX to POSITIVE/NEGATIVE_INFINITY

This more accurately reflects the way a runner should interact with
these special timestamps.

Add documentation about droppability of elements when a watermark is
positive infinity.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---