[jira] [Commented] (BEAM-1072) Dataflow should reject unset versions

2016-12-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713105#comment-15713105
 ] 

ASF GitHub Bot commented on BEAM-1072:
--

GitHub user dhalperi opened a pull request:

https://github.com/apache/incubator-beam/pull/1483

[BEAM-1072] DataflowRunner: reject job submission when the version has not 
been properly set

R: @davorbonaci 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dhalperi/incubator-beam 
dataflow-runner-require-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1483


commit 6fd0782fbb74d65ee7a535f721804a38badfa1d9
Author: Dan Halperin 
Date:   2016-12-01T19:21:30Z

DataflowRunner: reject job submission when the version has not been 
properly set




> Dataflow should reject unset versions
> -
>
> Key: BEAM-1072
> URL: https://issues.apache.org/jira/browse/BEAM-1072
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Affects Versions: Not applicable
>Reporter: Daniel Halperin
>Assignee: Daniel Halperin
>Priority: Minor
> Fix For: Not applicable
>
>
> A recent change broke the setting of the SDK version in certain execution 
> modes. If it happens again, it will cause a poor user experience when running 
> in the Dataflow runner.
> We should catch this break in the DataflowRunner and prevent job submission 
> if so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-1072) Dataflow should reject unset versions

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715706#comment-15715706
 ] 

ASF GitHub Bot commented on BEAM-1072:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1483


> Dataflow should reject unset versions
> -
>
> Key: BEAM-1072
> URL: https://issues.apache.org/jira/browse/BEAM-1072
> Project: Beam
>  Issue Type: Bug
>  Components: runner-dataflow
>Affects Versions: Not applicable
>Reporter: Daniel Halperin
>Assignee: Daniel Halperin
>Priority: Minor
> Fix For: Not applicable
>
>
> A recent change broke the setting of the SDK version in certain execution 
> modes. If it happens again, it will cause a poor user experience when running 
> in the Dataflow runner.
> We should catch this break in the DataflowRunner and prevent job submission 
> if so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)