[jira] [Commented] (BEAM-736) BigQueryTornadoesIT broken, blocking nightly release.

2016-10-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564019#comment-15564019
 ] 

ASF GitHub Bot commented on BEAM-736:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1078


> BigQueryTornadoesIT broken, blocking nightly release.
> -
>
> Key: BEAM-736
> URL: https://issues.apache.org/jira/browse/BEAM-736
> Project: Beam
>  Issue Type: Bug
>  Components: testing
>Reporter: Jason Kuster
>Assignee: Pei He
>
> Build break begins here: 
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1471/
> listing 3 potential culprit commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-736) BigQueryTornadoesIT broken, blocking nightly release.

2016-10-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563608#comment-15563608
 ] 

ASF GitHub Bot commented on BEAM-736:
-

GitHub user peihe opened a pull request:

https://github.com/apache/incubator-beam/pull/1078

[BEAM-736] Fix BigQueryTornadoesIT, broken by PR-1039

R: @lukecwik 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/peihe/incubator-beam fix-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1078.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1078


commit 72efd95df6bc89648f8c758092cf6e9229fda186
Author: Pei He 
Date:   2016-10-10T21:30:30Z

[BEAM-736] Fix BigQueryTornadoesIT, broken by PR-1039




> BigQueryTornadoesIT broken, blocking nightly release.
> -
>
> Key: BEAM-736
> URL: https://issues.apache.org/jira/browse/BEAM-736
> Project: Beam
>  Issue Type: Bug
>  Components: testing
>Reporter: Jason Kuster
>Assignee: Pei He
>
> Build break begins here: 
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1471/
> listing 3 potential culprit commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-736) BigQueryTornadoesIT broken, blocking nightly release.

2016-10-10 Thread Pei He (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563328#comment-15563328
 ] 

Pei He commented on BEAM-736:
-

NPE comes from here:
https://github.com/apache/incubator-beam/commit/cca861ba82a2e6ba6c6af122be0b8a9932d53cc5#diff-5b2e45465c4a6abd7d59967281b3a8b4R550

bigQueryServices is lazily initialized. It should be accessed through 
getBigQueryServices().
It is easy to fix.
This bug is introduced during the backport, not from Dataflow.

Two things could be improved:
1. better coding pattern to prevent bigQueryServices being accessed before it 
is initialized.
2. better logging in BigQueryTornadoesIT to provide full stack trace.

> BigQueryTornadoesIT broken, blocking nightly release.
> -
>
> Key: BEAM-736
> URL: https://issues.apache.org/jira/browse/BEAM-736
> Project: Beam
>  Issue Type: Bug
>  Components: testing
>Reporter: Jason Kuster
>Assignee: Pei He
>
> Build break begins here: 
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1471/
> listing 3 potential culprit commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)