[jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings
[ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-694: - Priority: Minor (was: Major) > TriggerTester doesn't test timer firings > > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Eugene Kirpichov >Priority: Minor > Labels: easy, starter > > TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is > used to prompt a call to the trigger with the current state of the trigger > tester (Input Watermarks, elements present, etc), and see if the trigger > should fire. > The TriggerTester should automatically call back to the trigger with the > current state whenever a Timer fires, as specified by the current watermarks > and any Timers set by the trigger under test. This ensures that Triggers set > underlying timers properly, so the trigger will fire even if no additional > elements arrive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings
[ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-694: - Component/s: runner-core > TriggerTester doesn't test timer firings > > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Eugene Kirpichov >Priority: Minor > Labels: easy, starter > > TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is > used to prompt a call to the trigger with the current state of the trigger > tester (Input Watermarks, elements present, etc), and see if the trigger > should fire. > The TriggerTester should automatically call back to the trigger with the > current state whenever a Timer fires, as specified by the current watermarks > and any Timers set by the trigger under test. This ensures that Triggers set > underlying timers properly, so the trigger will fire even if no additional > elements arrive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings
[ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles updated BEAM-694: - Labels: easy starter (was: ) > TriggerTester doesn't test timer firings > > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Eugene Kirpichov >Priority: Minor > Labels: easy, starter > > TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is > used to prompt a call to the trigger with the current state of the trigger > tester (Input Watermarks, elements present, etc), and see if the trigger > should fire. > The TriggerTester should automatically call back to the trigger with the > current state whenever a Timer fires, as specified by the current watermarks > and any Timers set by the trigger under test. This ensures that Triggers set > underlying timers properly, so the trigger will fire even if no additional > elements arrive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings
[ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Groh updated BEAM-694: - Description: TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is used to prompt a call to the trigger with the current state of the trigger tester (Input Watermarks, elements present, etc), and see if the trigger should fire. The TriggerTester should automatically call back to the trigger with the current state whenever a Timer fires, as specified by the current watermarks and any Timers set by the trigger under test. This ensures that Triggers set underlying timers properly, so the trigger will fire even if no additional elements arrive. > TriggerTester doesn't test timer firings > > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug >Reporter: Eugene Kirpichov > > TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is > used to prompt a call to the trigger with the current state of the trigger > tester (Input Watermarks, elements present, etc), and see if the trigger > should fire. > The TriggerTester should automatically call back to the trigger with the > current state whenever a Timer fires, as specified by the current watermarks > and any Timers set by the trigger under test. This ensures that Triggers set > underlying timers properly, so the trigger will fire even if no additional > elements arrive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-694) TriggerTester doesn't test timer firings
[ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Groh updated BEAM-694: - Description: (was: Discussion with [~tgroh] E: Are you familiar with TriggerTester in general? I'm confused about it. Seems like it set and deletes timers, but doesn't care about them afterwards (doesn't fire them, nor even inspect when they could have fired). T: It looks like it should e.g. AfterWatermarkTest#testEarlyAndAtWatermark E: I tried removing the code that sets and deletes timers in TriggerTester and the various trigger tests still pass T: Hrm That's worrying Yeah, that actually makes more sense Because fireIfShouldFire is explicitly invoked So we don't need actual callbacks Which is probably broken We should advance the watermark and assert that the trigger did fire instead (e.g. got a callback) *i.e. E: You mean TriggerTester is broken? T: It doesn't actually test that we're registering the appropriate callback so it's not so much broken as it is itself not sufficient to demonstrate proper triggering behavior and/or proper interaction with TimerInternals) > TriggerTester doesn't test timer firings > > > Key: BEAM-694 > URL: https://issues.apache.org/jira/browse/BEAM-694 > Project: Beam > Issue Type: Bug >Reporter: Eugene Kirpichov > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
