Re: [Apache Bloodhound] #501: Convert repository annotations to Bootstrap

[Apache Bloodhound]

#501: Convert repository annotations to Bootstrap
-+-
  Reporter:  olemis  |  Owner:  rjollos
  Type:  task| Status:  review
  Priority:  major   |  Milestone:  Release 8
 Component:  ui design   |Version:
Resolution:  |   Keywords:  vcs browser blame responsive
 |  bootstrap
-+-

Comment (by olemis):

 Replying to [comment:6 rjollos]:
 >
 [...]
 >
 > The CSS for `table.code th.blame a` looks a bit off to me, at least for
 the case of Git changeset IDs. Has something changed in the time since the
 patch was created?
 >

 Well ... I tested with hg changesets and it used to work ok . AFAICT ...

''Git is smart enough to figure out what commit you meant to type if
 you provide the first few characters, as long as your partial SHA-1 is at
 least four characters long and unambiguous — that is, only one object in
 the current repository begins with that partial SHA-1.''

 ,,according to [http://git-scm.com/book/en/Git-Tools-Revision-Selection
 #Short-SHA Git Tools - Revision Selection - Short SHA],,

 For a more generic solution maybe we could just set
 [source:/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css@1536977#L374
 .clip] CSS class in a span inside enclosing brackets to control overflow?

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #708: Use index column to update PostgreSQL sequence

[Apache Bloodhound]

#708: Use index column to update PostgreSQL sequence
+
  Reporter:  olemis |  Owner:
  Type:  defect | Status:  review
  Priority:  critical   |  Milestone:  Release 8
 Component:  trac core  |Version:
Resolution: |   Keywords:  postgresql db, upgrade
+
Changes (by olemis):

 * owner:  olemis =>
 * status:  accepted => review


Comment:

 Please review attached patch . I did not write test cases because the
 change is trivial . Details

 {{{#!sh

 $ hg qapplied
 t708/t708_r1537391_db_pgsql_update_sequence.diff

 $ hg log -r qparent
 changeset:   472:cec1e940716f
 tag: qparent
 tag: svn-1537391
 user:rjollos@13f79535-47bb-0310-9956-ffa450edef68
 date:Thu Oct 31 07:15:42 2013 +
 summary: 0.8dev: Remove unnecessary `env_path` variable (path is
 stored at `env.path`). Use consistent naming for temp dirs.

 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #708: Use index column to update PostgreSQL sequence

[Apache Bloodhound]

#708: Use index column to update PostgreSQL sequence
+
  Reporter:  olemis |  Owner:  olemis
  Type:  defect | Status:  accepted
  Priority:  critical   |  Milestone:  Release 8
 Component:  trac core  |Version:
Resolution: |   Keywords:  postgresql db, upgrade
+
Changes (by olemis):

 * status:  new => accepted
 * component:   => trac core
 * priority:  major => critical
 * keywords:   => postgresql db, upgrade
 * milestone:   => Release 8
 * owner:   => olemis


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #501: Convert repository annotations to Bootstrap

[Apache Bloodhound]

#501: Convert repository annotations to Bootstrap
-+-
  Reporter:  olemis  |  Owner:  rjollos
  Type:  task| Status:  review
  Priority:  major   |  Milestone:  Release 8
 Component:  ui design   |Version:
Resolution:  |   Keywords:  vcs browser blame responsive
 |  bootstrap
-+-

Comment (by rjollos):

 The scrollbar and scrolling buttons on the dialog box look good. A
 possible enhancement would be to size the dialog to the available screen
 height, and that might be an enhancement we could push back to Trac as
 well since the dialog often overflows the screen height in Trac.

 The CSS for `table.code th.blame a` looks a bit off to me, at least for
 the case of Git changeset IDs. Has something changed in the time since the
 patch was created?

 [[Image(BootstrapBlame.png,100%)]]

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #706: Unable to import tests.env module in python 2.6 - after r1536964

[Apache Bloodhound]

#706: Unable to import tests.env module in python 2.6 - after r1536964
---+---
  Reporter:  olemis|  Owner:  rjollos
  Type:  defect| Status:  review
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  qa
---+---
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review


Comment:

 Attached patch will fix this issue , see comment:38:ticket:694 for further
 details

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #707: Log import errors during test discovery

[Apache Bloodhound]

#707: Log import errors during test discovery
---+
  Reporter:  olemis|  Owner:  rjollos
  Type:  enhancement   | Status:  review
  Priority:  minor |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.7.0
Resolution:|   Keywords:  qa, test discovery, loader
---+
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #707: Log import errors during test discovery

[Apache Bloodhound]

#707: Log import errors during test discovery
---+
  Reporter:  olemis|  Owner:  olemis
  Type:  enhancement   | Status:  accepted
  Priority:  minor |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.7.0
Resolution:|   Keywords:  qa, test discovery, loader
---+

Comment (by olemis):

 Attached patch is aimed at logging errors by relying upon the handler
 installed in ''bh.tests'' logging channel. If not previously setup then it
 will be initialized with basic handlers and formatters. The code is
 borrowed from `logging.basicConfig`

 On failure a test report like [http://pastebin.com/HcxabaEJ this one] (vs
 [http://pastebin.com/99tLkfhj previous report] for #694) will be generated

 See comment:38:ticket:694 for further details

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #694: Translations scaffolding

[Apache Bloodhound]

#694: Translations scaffolding
+--
  Reporter:  olemis |  Owner:  olemis
  Type:  task   | Status:  assigned
  Priority:  minor  |  Milestone:
 Component:  trac core  |Version:  0.7.0
Resolution: |   Keywords:  i18n
+--

Comment (by olemis):

 Replying to [comment:37 olemis]:
 > Replying to [comment:34 olemis]:
 > [...]
 > >
 > > To the point ... after all this I ran the multi-product test suite .
 By comparing the [http://pastebin.com/99tLkfhj i18n test report] with the
 [http://pastebin.com/sswYZ4dd former test report] then total count reveals
 that there's something weird happening and some test cases are not
 discovered .
 >
 > The patches submitted before for #706 and #707 will improve the
 situation of the multi-product test suite: see
 [http://pastebin.com/p3MzfbJq report for r1536977] (2013-10-31) and
 [http://pastebin.com/WBjB3Q1E report for r1537391] (2013-11-01).
 >

 I forgot , it's straightforward to apply the patches by checking out the
 patch queue , just move to r1536977 and execute `hg qpush -a` .
 Nevertheless details follow jftr :

 {{{#!sh

 $ hg qapplied
 t707/t707_r1536966_test_discovery_logging.diff
 t706/t706_r1536966_AssertRaisesContext_import.diff
 t694/t694_r1534486_bloodhound_i18n.diff

 $ hg log -r qparent
 changeset:   472:cec1e940716f
 tag: qparent
 tag: svn-1537391
 user:rjollos@13f79535-47bb-0310-9956-ffa450edef68
 date:Thu Oct 31 07:15:42 2013 +
 summary: 0.8dev: Remove unnecessary `env_path` variable (path is
 stored at `env.path`). Use consistent naming for temp dirs.
 }}}

 The evidence provided by the test reports mentioned in comment:37
 indicates that (afaict) everything should be ok with BH multi-product
 plugin . Therefore , @SaintGermain , could you please move forward with
 generating the translation files for this plugin , uploading them onto
 [https://www.transifex.com/projects/p/bloodhound/ bloodhound project @
 transifex] . Once you do so we both could work on Spanish + French
 translations for this plugin and probe the system to assess translation
 coverage .

 Do you think it's a good idea to do so now that we know that patches do
 not introduce regressions in the MP test suite?

 > On the other hand with i18n patches applied I got ''Unknown widget
 '' all over the site in each and every dashboard. These are the
 relevant entries I found in the logs
 >

 In the mean time this is still a pending task ... but we can proceed with
 dashboard and other plugins later should similar issues be detected . It
 is necessary to run the test suite of all other BH plugins **using
 python2.6** to ensure that patches do not introduce regressions.

 [...]
 >
 > Besides `bhdashboard.widgets.containers` the same goes for
 `bhdashboard.widgets.product`, `bhdashboard.widgets.query`,
 `bhdashboard.widgets.report`, `bhdashboard.widgets.ticket`,
 `bhdashboard.widgets.timeline`, `bhrelations.widgets.ticketrelations` ,
 and every other module implementing widgets. So it seems a few more
 adjustments are still needed.
 >

 ... and these are good candidates , just to start ;)

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #694: Translations scaffolding

[Apache Bloodhound]

#694: Translations scaffolding
+--
  Reporter:  olemis |  Owner:  olemis
  Type:  task   | Status:  assigned
  Priority:  minor  |  Milestone:
 Component:  trac core  |Version:  0.7.0
Resolution: |   Keywords:  i18n
+--

Comment (by olemis):

 Replying to [comment:34 olemis]:
 [...]
 >
 > To the point ... after all this I ran the multi-product test suite . By
 comparing the [http://pastebin.com/99tLkfhj i18n test report] with the
 [http://pastebin.com/sswYZ4dd former test report] then total count reveals
 that there's something weird happening and some test cases are not
 discovered .

 The patches submitted before for #706 and #707 will improve the situation
 of the multi-product test suite: see [http://pastebin.com/p3MzfbJq report
 for r1536977] (2013-10-31) and [http://pastebin.com/WBjB3Q1E report for
 r1537391] (2013-11-01).

 On the other hand with i18n patches applied I got ''Unknown widget '' all over the site in each and every dashboard. These are the
 relevant entries I found in the logs

 [[span(Log entry, class=label label-info)]]
 {{{
 2013-10-31 18:44:26,809 Trac[loader] ERROR: Skipping
 "bhdashboard.widgets.containers = bhdashboard.widgets.containers":
 }}}

 [[span(Traceback, class=label label-info)]]
 {{{#!py
 Traceback (most recent call last):
   File "/path/to/bloodhound/trac/trac/loader.py", line 68, in _load_eggs
 entry.load(require=True)
   File "build/bdist.linux-x86_64/egg/pkg_resources.py", line 1994, in load
 entry = __import__(self.module_name, globals(),globals(),
 ['__name__'])
   File
 "/path/to/bloodhound/bloodhound_dashboard/bhdashboard/widgets/containers.py",
 line 31, in 
 from bhdashboard.util import WidgetBase, check_widget_name, \
 ImportError: cannot import name WidgetBase
 }}}

 Besides `bhdashboard.widgets.containers` the same goes for
 `bhdashboard.widgets.product`, `bhdashboard.widgets.query`,
 `bhdashboard.widgets.report`, `bhdashboard.widgets.ticket`,
 `bhdashboard.widgets.timeline`, `bhrelations.widgets.ticketrelations` ,
 and every other module implementing widgets. So it seems a few more
 adjustments are still needed.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #707: Log import errors during test discovery

[Apache Bloodhound]

#707: Log import errors during test discovery
---+
  Reporter:  olemis|  Owner:  olemis
  Type:  enhancement   | Status:  accepted
  Priority:  minor |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.7.0
Resolution:|   Keywords:  qa, test discovery, loader
---+
Changes (by olemis):

 * status:  new => accepted
 * component:   => multiproduct
 * priority:  major => minor
 * owner:   => olemis
 * milestone:   => Release 8
 * keywords:   => qa, test discovery, loader


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #654: Rows in ticket query result set not sorted by column

[Apache Bloodhound]

#654: Rows in ticket query result set not sorted by column
---+---
  Reporter:  olemis|  Owner:  gjm
  Type:  defect| Status:  accepted
  Priority:  blocker   |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  ticket query, sorting
---+---

Comment (by gjm):

 I've been considering this one for a while now. The immediate problem is
 that lists of enums (Type, Status, Resolution, Priority and Severity for
 example) are not available as the query to select them is restricted to
 the product that they are performed in. This makes a bit less sense at the
 top level where there are none.

 There are a number of ways to deal with this, one of which includes
 providing an extra variable on the env object to determine whether to
 force a db_direct_query and decorate the !AbstractEnum.select method to
 choose when no product is selected. This would look something like:
 {{{
 #!python
 import copy
 from trac.ticket import model

 from functools import wraps

 def direct_query_override(f):
 @classmethod
 @wraps(f)
 def decorator(cls, env, *args, **kwargs):
 kwargs.pop('db', None)
 denv = copy.copy(env)
 if not getattr(denv, 'product', None):
 denv._db_direct_override = True
 return f.__get__(True).im_func(cls, denv, *args, **kwargs)
 return decorator

 model.AbstractEnum.select =
 direct_query_override(model.AbstractEnum.select)
 }}}

 That still leaves a bit to do about including:
  * duplicate removal
  * restricting returned values based on permissions
  * decide whether we care that enums may end up with different priorities
 in different products

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #694: Translations scaffolding

[Apache Bloodhound]

#694: Translations scaffolding
+--
  Reporter:  olemis |  Owner:  olemis
  Type:  task   | Status:  assigned
  Priority:  minor  |  Milestone:
 Component:  trac core  |Version:  0.7.0
Resolution: |   Keywords:  i18n
+--

Comment (by olemis):

 Replying to [comment:35 rjollos]:
 > Replying to [comment:34 olemis]:
 > > ...  total count reveals that there's something weird happening and
 some test cases are not discovered .
 >
 > Since you mention test case discovery, it's probably good to keep an eye
 out for potential issues with #624, [1536966] committed just last evening.

 No , it's actually related to [1536964] , see #706

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #707: Log import errors during test discovery

[Apache Bloodhound]

#707: Log import errors during test discovery
--+-
  Reporter:  olemis   |Owner:
  Type:  enhancement  |   Status:  new
  Priority:  major|  Version:  0.7.0
Resolution:   |
--+-
 The initial package discovery strategy skips silently all (sub)modules
 that fail to be imported. This behavior actually hides a number of
 potential bugs like those related to comment:34:ticket:694 and #706 .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #708: Use index column to update PostgreSQL sequence

[Apache Bloodhound]

#708: Use index column to update PostgreSQL sequence
-+---
  Reporter:  olemis  |Owner:
  Type:  defect  |   Status:  new
  Priority:  major   |  Version:
Resolution:  |
-+---
 In `trac.db.postgres_backend:PostgreSQLConnection.update_sequence` it is
 necesssary to expand the value supplied in `column` argument rather than
 using static reference to `id` column.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #706: Unable to import tests.env module in python 2.6 - after r1536964

[Apache Bloodhound]

#706: Unable to import tests.env module in python 2.6 - after r1536964
---+---
  Reporter:  olemis|  Owner:  olemis
  Type:  defect| Status:  accepted
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  qa
---+---
Changes (by olemis):

 * owner:   => olemis
 * status:  new => accepted
 * component:   => multiproduct
 * keywords:   => qa
 * milestone:   => Release 8


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #706: Unable to import tests.env module in python 2.6 - after r1536964

[Apache Bloodhound]

#706: Unable to import tests.env module in python 2.6 - after r1536964
-+---
  Reporter:  olemis  |Owner:
  Type:  defect  |   Status:  new
  Priority:  major   |  Version:
Resolution:  |
-+---
 After the unification of `unittest` imports made in r1536964 it is
 impossible to import in python 2.6 the module `tests.env` since the
 statement `from unittest.case import _AssertRaisesContext` will fail.

 {{{#!sh

 $ python setup.py test -m tests.env
 running test
 running egg_info
 writing requirements to BloodhoundTheme.egg-info/requires.txt
 writing BloodhoundTheme.egg-info/PKG-INFO
 writing top-level names to BloodhoundTheme.egg-info/top_level.txt
 writing dependency_links to BloodhoundTheme.egg-info/dependency_links.txt
 writing entry points to BloodhoundTheme.egg-info/entry_points.txt
 writing requirements to BloodhoundTheme.egg-info/requires.txt
 writing BloodhoundTheme.egg-info/PKG-INFO
 writing top-level names to BloodhoundTheme.egg-info/top_level.txt
 writing dependency_links to BloodhoundTheme.egg-info/dependency_links.txt
 writing entry points to BloodhoundTheme.egg-info/entry_points.txt
 reading manifest file 'BloodhoundTheme.egg-info/SOURCES.txt'
 reading manifest template 'MANIFEST.in'
 warning: no directories found matching 'bhtheme/htdocs/images'
 writing manifest file 'BloodhoundTheme.egg-info/SOURCES.txt'
 running build_ext
 Traceback (most recent call last):
   File "setup.py", line 64, in 
 **extra
   File "/usr/lib/python2.6/distutils/core.py", line 152, in setup
 dist.run_commands()
   File "/usr/lib/python2.6/distutils/dist.py", line 975, in run_commands
 self.run_command(cmd)
   File "/usr/lib/python2.6/distutils/dist.py", line 995, in run_command
 cmd_obj.run()
   File "build/bdist.linux-x86_64/egg/setuptools/command/test.py", line
 121, in run
   File "build/bdist.linux-x86_64/egg/setuptools/command/test.py", line
 101, in with_project_on_sys_path
   File "build/bdist.linux-x86_64/egg/setuptools/command/test.py", line
 135, in run_tests
   File "/usr/lib/python2.6/unittest.py", line 816, in __init__
 self.parseArgs(argv)
   File "/usr/lib/python2.6/unittest.py", line 843, in parseArgs
 self.createTests()
   File "/usr/lib/python2.6/unittest.py", line 849, in createTests
 self.module)
   File "/usr/lib/python2.6/unittest.py", line 613, in loadTestsFromNames
 suites = [self.loadTestsFromName(name, module) for name in names]
   File "/usr/lib/python2.6/unittest.py", line 584, in loadTestsFromName
 parent, obj = obj, getattr(obj, part)
 AttributeError: 'module' object has no attribute 'env'

 $ python
 Python 2.6.5 (r265:79063, Apr 16 2010, 13:57:41)
 [GCC 4.4.3] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 >>> import bhrelations.tests
 Traceback (most recent call last):
   File "", line 1, in 
   File "bhrelations/tests/__init__.py", line 28, in 
 from bhrelations.tests import api, notification, search, validation,
 web_ui
   File "bhrelations/tests/api.py", line 26, in 
 from bhrelations.tests.base import BaseRelationsTestCase
   File "bhrelations/tests/base.py", line 19, in 
 from tests.env import MultiproductTestCase
   File "/path/to/bloodhound/bloodhound_multiproduct/tests/env.py", line
 29, in 
 from unittest.case import _AssertRaisesContext
 ImportError: No module named case
 >>>
 }}}

 In version 2.6 `unittest` is still a single .py file and thereby there's
 no such module `unittest.case` . The correct name would be
 `unittest2.case` instead.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #564: Inconsistencies in dashboard widgets

[Apache Bloodhound]

#564: Inconsistencies in dashboard widgets
-+-
  Reporter:  olemis  |  Owner:  olemis
  Type:  defect  | Status:  accepted
  Priority:  major   |  Milestone:
 Component:  dashboard   |Version:
Resolution:  |   Keywords:  version, component, milestone,
 |  widgets
-+-
Changes (by olemis):

 * status:  new => accepted
 * owner:  nobody => olemis


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker