Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped commands in console admin

[Apache Bloodhound]

#756: Unhelpful errors from product-scoped commands in console admin
---+---
  Reporter:  rjollos   |  Owner:  olemis
  Type:  enhancement   | Status:  accepted
  Priority:  major |  Milestone:  Release 9
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  console admin
---+---
Changes (by olemis):

 * owner:  nobody => olemis
 * status:  new => accepted
 * type:  defect => enhancement
 * milestone:   => Release 9


Comment:

 I'll start working on this with an initial schedule for
 [milestone:"Release 9"] but maybe ready sooner than that ... depending on
 scheduled release deadline for [milestone:"Release 8"] .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1567988 - /bloodhound/branches/trac-1.0-stable-integration/

[rjollos]

Author: rjollos
Date: Thu Feb 13 17:57:01 2014
New Revision: 1567988

URL: http://svn.apache.org/r1567988
Log:
Created branch for integrating changes from Trac 1.0-stable. Refs #660.

Added:
bloodhound/branches/trac-1.0-stable-integration/   (props changed)
  - copied from r1567987, bloodhound/trunk/

Propchange: bloodhound/branches/trac-1.0-stable-integration/
--
--- svn:auto-props (added)
+++ svn:auto-props Thu Feb 13 17:57:01 2014
@@ -0,0 +1,5 @@
+*.html = svn:eol-style=native
+*.js = svn:eol-style=native
+*.css = svn:eol-style=native
+*.py = svn:eol-style=native
+*.xml = svn:eol-style=native

Propchange: bloodhound/branches/trac-1.0-stable-integration/
--
--- svn:ignore (added)
+++ svn:ignore Thu Feb 13 17:57:01 2014
@@ -0,0 +1,7 @@
+*.DS_Store
+.idea
+.project
+.pydevproject
+.git
+.gitignore
+.hg

Propchange: bloodhound/branches/trac-1.0-stable-integration/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Thu Feb 13 17:57:01 2014
@@ -0,0 +1,3 @@
+/bloodhound/branches/bep_0003_multiproduct:1461360-1463488
+/bloodhound/branches/bep_0010_ticket_numbering:1506462-1517786
+/incubator/bloodhound/branches/bep_0003_multiproduct:1420073-1461359

Re: [Apache Bloodhound] #660: Integrate changes from Trac 1.0.2

[Apache Bloodhound]

#660: Integrate changes from Trac 1.0.2
+
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:  Release 9
 Component:  trac core  |Version:
Resolution: |   Keywords:  trac-1.0.2
+

Comment (by rjollos):

 Created branch for integration work in [1567988].

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #694: Translations scaffolding

[Apache Bloodhound]

#694: Translations scaffolding
+--
  Reporter:  olemis |  Owner:  olemis
  Type:  task   | Status:  assigned
  Priority:  minor  |  Milestone:
 Component:  trac core  |Version:  0.7.0
Resolution: |   Keywords:  i18n
+--

Comment (by olemis):

 Replying to [comment:77 SaintGermain]:
 > > > If translation consistency is important in the mainnav, we can
 remove the browser.label and tickets.label from the generated base.ini
 (and replace 'Browse Source' by 'Source' in the code if you think it is a
 better label).
 > > >
 > >
 > > IMO that'd be nice .
 > >
 >
 > Hum ok but it requires to manually add the 'Source' in the Trac catalog
 (currently only 'Browse Source' is there):
 > - If the repo is connected/configured, it will look in bloodhound_theme
 catalog
 > - If the repo is not connected/configured, it will look in Trac catalog
 >
 > I am a bit reluctant to modify Trac code or Trac catalog manually.

 I'm not suggesting to do so ... for obvious reasons , we both agree .

 > So it seems that either we have a consistent mainnav translation with
 'Browse Source' or we keep 'Source' and it will be only translated when
 repo is connected/configured.
 >

 I do not get it very well . In Trac when the repository is not connected
 there is no mainnav item , so BH is adding that link (not Trac) . Now I
 wonder why is the translation retrieved from Trac catalog in that case ?

 [...]

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped commands in console admin

[Apache Bloodhound]

#756: Unhelpful errors from product-scoped commands in console admin
---+---
  Reporter:  rjollos   |  Owner:  olemis
  Type:  enhancement   | Status:  accepted
  Priority:  major |  Milestone:  Release 9
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  console admin
---+---

Comment (by olemis):

 Replying to [ticket:756 rjollos]:
 > For example, omitting the //owner// argument (which is currently
 required, but not after trac:#11344):

 The updates in the trac-admin command itself are beyond the scope of this
 ticket and will be merged into /trunk once the corresponding Trac branch
 will be updated in our vendor branch .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #757: [Regression] TracAdmin help command 0.8-dev

[Apache Bloodhound]

#757: [Regression] TracAdmin help command 0.8-dev
-+
  Reporter:  olemis  |Owner:
  Type:  defect  |   Status:  new
  Priority:  major   |  Version:  0.8.0dev
Resolution:  |
-+
 The behavior described in comment:3:ticket:518 is not happening in /trunk
 (0.8-dev) .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #757: [Regression] TracAdmin help command 0.8-dev

[Apache Bloodhound]

#757: [Regression] TracAdmin help command 0.8-dev
---+---
  Reporter:  olemis|  Owner:  olemis
  Type:  defect| Status:  accepted
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.8.0dev
Resolution:|   Keywords:  admin
---+---
Changes (by olemis):

 * status:  new => accepted
 * owner:   => olemis
 * component:   => multiproduct
 * keywords:   => admin
 * milestone:   => Release 8


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #757: [Regression] TracAdmin help command 0.8-dev

[Apache Bloodhound]

#757: [Regression] TracAdmin help command 0.8-dev
---+---
  Reporter:  olemis|  Owner:  olemis
  Type:  defect| Status:  accepted
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.8.0dev
Resolution:|   Keywords:  admin
---+---

Comment (by olemis):

 This patch will fix this issue

 {{{#!diff

 diff -r 7c71bd9e5fe5 bloodhound_multiproduct/multiproduct/product_admin.py
 --- a/bloodhound_multiproduct/multiproduct/product_admin.py Wed Feb 12
 23:17:59 2014 +
 +++ b/bloodhound_multiproduct/multiproduct/product_admin.py Thu Feb 13
 15:56:19 2014 -0500
 @@ -302,7 +302,7 @@
  mgr = self.product_admincmd_mgr(args[0])
  return mgr.complete_command(args[1:])

 -GLOBAL_COMMANDS = ('deploy', 'help', 'hotcopy', 'initenv', 'upgrade')
 +GLOBAL_COMMANDS = ('deploy', 'hotcopy', 'initenv', 'upgrade')

  def _do_product_admin(self, prefix, *args):
  mgr = self.product_admincmd_mgr(prefix)

 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #757: [Regression] TracAdmin help command 0.8-dev

[Apache Bloodhound]

#757: [Regression] TracAdmin help command 0.8-dev
---+---
  Reporter:  olemis|  Owner:  rjollos
  Type:  defect| Status:  review
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:  0.8.0dev
Resolution:|   Keywords:  admin
---+---
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped commands in console admin

[Apache Bloodhound]

#756: Unhelpful errors from product-scoped commands in console admin
---+---
  Reporter:  rjollos   |  Owner:  olemis
  Type:  enhancement   | Status:  accepted
  Priority:  major |  Milestone:  Release 9
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  console admin
---+---

Comment (by olemis):

 Attached patch is aimed at improving error messages when product admin
 commands are executed .

 This is a typical trac-admin session in product context

 {{{#!sh

 $ trac-admin /path/to/trac/env/
 Welcome to trac-admin 1.0.1
 Interactive Trac administration console.
 Copyright (C) 2003-2013 Edgewall Software

 Type:  '?' or 'help' for help on commands.

 Trac [/path/to/trac/env]> product admin default component add c3
 Error: Invalid arguments

 Admin command failed in product : default

 component add  

 Add a new component
 }}}

 Details :

 {{{#!sh
 $ hg qapplied
 t756/t756_r1567795_product_admin_failmsg.diff

 $ hg log -r qparent --template="{svnrev}\n"
 1567795
 }}}

 Open question :

   - Should suggested command be «product admin  » ?

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped commands in console admin

[Apache Bloodhound]

#756: Unhelpful errors from product-scoped commands in console admin
---+---
  Reporter:  rjollos   |  Owner:  rjollos
  Type:  enhancement   | Status:  review
  Priority:  major |  Milestone:  Release 9
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  console admin
---+---
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review


Comment:

 Test cases needed ...

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

svn commit: r1568172 - in /bloodhound/trunk/trac/trac: ticket/query.py util/introspection.py util/tests/introspection.py

[rjollos]

Author: rjollos
Date: Fri Feb 14 00:09:21 2014
New Revision: 1568172

URL: http://svn.apache.org/r1568172
Log:
0.8dev: Reverse merge [1301696]. Equivalent changes will be implemented in 
`multiproduct.ticket.web_ui:ProductQueryModule`.

Removed:
bloodhound/trunk/trac/trac/util/introspection.py
bloodhound/trunk/trac/trac/util/tests/introspection.py
Modified:
bloodhound/trunk/trac/trac/ticket/query.py

Modified: bloodhound/trunk/trac/trac/ticket/query.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/trac/trac/ticket/query.py?rev=1568172&r1=1568171&r2=1568172&view=diff
==
--- bloodhound/trunk/trac/trac/ticket/query.py (original)
+++ bloodhound/trunk/trac/trac/ticket/query.py Fri Feb 14 00:09:21 2014
@@ -40,7 +40,6 @@ from trac.util.datefmt import format_dat
 from trac.util.presentation import Paginator
 from trac.util.text import empty, shorten_line, quote_query_string
 from trac.util.translation import _, tag_, cleandoc_
-from trac.util.introspection import get_enabled_component_subclass
 from trac.web import arg_list_to_args, parse_arg_list, IRequestHandler
 from trac.web.href import Href
 from trac.web.chrome import (INavigationContributor, Chrome,
@@ -873,7 +872,7 @@ class QueryModule(Component):
 def get_navigation_items(self, req):
 from trac.ticket.report import ReportModule
 if 'TICKET_VIEW' in req.perm and \
-get_enabled_component_subclass(self.env, ReportModule) is None:
+not self.env.is_component_enabled(ReportModule):
 yield ('mainnav', 'tickets',
tag.a(_('View Tickets'), href=req.href.query()))
 

svn commit: r1568197 - in /bloodhound/trunk: bloodhound_dashboard/bhdashboard/templates/ bloodhound_multiproduct/ bloodhound_multiproduct/multiproduct/ bloodhound_multiproduct/multiproduct/templates/

[rjollos]

Author: rjollos
Date: Fri Feb 14 04:21:59 2014
New Revision: 1568197

URL: http://svn.apache.org/r1568197
Log:
0.8dev: Normalized license headers. Prevent rendering license headers in 
templates.

Modified:

bloodhound/trunk/bloodhound_dashboard/bhdashboard/templates/bh_model_view.html
bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/api.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/config.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/core.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/dbcursor.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/hooks.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/model.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/perm.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py

bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html

bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/repository_links.html
bloodhound/trunk/bloodhound_multiproduct/multiproduct/ticket/__init__.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/ticket/batch.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/ticket/query.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/ticket/web_ui.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/util.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/versioncontrol.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/web_ui.py
bloodhound/trunk/bloodhound_multiproduct/setup.py
bloodhound/trunk/bloodhound_search/bhsearch/templates/bhsearch.html

bloodhound/trunk/bloodhound_search/bhsearch/templates/bhsearch_breadcrumbs.html

Modified: 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/templates/bh_model_view.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_dashboard/bhdashboard/templates/bh_model_view.html?rev=1568197&r1=1568196&r2=1568197&view=diff
==
--- 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/templates/bh_model_view.html 
(original)
+++ 
bloodhound/trunk/bloodhound_dashboard/bhdashboard/templates/bh_model_view.html 
Fri Feb 14 04:21:59 2014
@@ -1,7 +1,3 @@
-http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
-
 
 
+http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 http://www.w3.org/1999/xhtml";
   xmlns:py="http://genshi.edgewall.org/";
   xmlns:i18n="http://genshi.edgewall.org/i18n";

Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py?rev=1568197&r1=1568196&r2=1568197&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py Fri Feb 
14 04:21:59 2014
@@ -1,4 +1,5 @@
-
+# -*- coding: UTF-8 -*-
+#
 #  Licensed to the Apache Software Foundation (ASF) under one
 #  or more contributor license agreements.  See the NOTICE file
 #  distributed with this work for additional information
@@ -16,8 +17,7 @@
 #  specific language governing permissions and limitations
 #  under the License.
 
-"""multiproduct module"""
+import multiproduct.ticket
 from multiproduct.api import MultiProductSystem
 from multiproduct.product_admin import ProductAdminPanel
-import multiproduct.ticket
 from multiproduct.web_ui import ProductModule

Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/api.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/api.py?rev=1568197&r1=1568196&r2=1568197&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/api.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/api.py Fri Feb 14 
04:21:59 2014
@@ -1,4 +1,5 @@
-
+# -*- coding: UTF-8 -*-
+#
 #  Licensed to the Apache Software Foundation (ASF) under one
 #  or more contributor license agreements.  See the NOTICE file
 #  distributed with this work for additional information
@@ -16,8 +17,6 @@
 #  specific language governing permissions and limitations
 #  under the License.
 
-"""Core components to support multi-product"""
-
 import copy
 import os
 import shutil

Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/config.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/config.py?rev=1568197&r1=1568196&r2=1568197&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/config.py (original)
+++ bloodhound/trunk/blo

svn commit: r1568198 - /bloodhound/trunk/bloodhound_dashboard/void/

[rjollos]

Author: rjollos
Date: Fri Feb 14 04:23:32 2014
New Revision: 1568198

URL: http://svn.apache.org/r1568198
Log:
0.8dev: Removed empty directory in `bloodhound_dashboard`.

Removed:
bloodhound/trunk/bloodhound_dashboard/void/

svn commit: r1568199 - /bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py

[rjollos]

Author: rjollos
Date: Fri Feb 14 04:52:43 2014
New Revision: 1568199

URL: http://svn.apache.org/r1568199
Log:
0.8dev: Fixed import issue introduced in [1568197].

Modified:
bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py

Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py?rev=1568199&r1=1568198&r2=1568199&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/__init__.py Fri Feb 
14 04:52:43 2014
@@ -17,7 +17,7 @@
 #  specific language governing permissions and limitations
 #  under the License.
 
-import multiproduct.ticket
 from multiproduct.api import MultiProductSystem
 from multiproduct.product_admin import ProductAdminPanel
+from multiproduct.ticket import *
 from multiproduct.web_ui import ProductModule