Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: matevzb Type: enhancement | Status: closed Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: fixed| Keywords: --+--- Changes (by matevzb): * status: accepted = closed * resolution: = fixed Comment: The improvements and fixes planned for Release 6 have been implemented, further improvements should be raised in separate tickets. Closing this ticket. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:13 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: matevzb Type: enhancement | Status: accepted Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: | Keywords: --+--- Comment (by olemis): Replying to [comment:10 rjollos]: (In [1492525]) Refs #544: Check for existence of `qct` variable before rendering the visible-phone Quick-ticket-create. This resolves a traceback under various circumstances that `qct` isn't passed to the template, such as when a !TracError is rendered on navigating to a non-existing ticket. I was trying to look into similar error I detected yesterday but was not sure if it was really an issue . Thanks for fixing . I haven't yet looked closely into why the `qct` variable isn't passed to the template when the !TracError is present, Depends on the exact point failure is detected and whether request could be fully post processed or not . or if that is proper behavior. However, we clearly don't get a Create ticket button: I guess that under certain circumstances there's no hope ... [...] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:11 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay
--+---
Reporter: jdreimann| Owner: matevzb
Type: enhancement | Status: accepted
Priority: major| Milestone: Release 6
Component: ui design|Version:
Resolution: | Keywords:
--+---
Comment (by rjollos):
There are tracebacks such as the one shown below under various
circumstances. One easy way to reproduce is to navigate to a non-existing
ticket. It looks like we just need to check for the existence of the `qct`
variable in the visible-phone Quick-ticket-create code, as is already
done in the hidden-phone Quick-ticket-create code.
{{{
Traceback (most recent call last):
File /home/user/Workspace/bh201/bloodhound/trac/trac/web/api.py, line
514, in send_error
data, 'text/html')
File /home/user/Workspace/bh201/bloodhound/trac/trac/web/chrome.py,
line 1019, in render_template
encoding='utf-8')
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 184, in render
return encode(generator, method=method, encoding=encoding, out=out)
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 58, in encode
for chunk in iterator:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 350, in __call__
for kind, data, pos in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 829, in __call__
for kind, data, pos in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 669, in __call__
for kind, data, pos in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 774, in __call__
for kind, data, pos in chain(stream, [(None, None, None)]):
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/output.py, line 594, in __call__
for ev in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 289, in _ensure
for event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 289, in _ensure
for event in stream:
File /home/user/Workspace/bh201/bloodhound/trac/trac/web/chrome.py,
line 1156, in _strip_accesskeys
for kind, data, pos in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 289, in _ensure
for event in stream:
File /home/user/Workspace/bh201/bloodhound/trac/trac/web/chrome.py,
line 1145, in _generate
for kind, data, pos in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 289, in _ensure
for event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/core.py, line 289, in _ensure
for event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 706, in _unmark
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 974, in __call__
for mark, (kind, data, pos) in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 734, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 799, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 974, in __call__
for mark, (kind, data, pos) in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 734, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 799, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 1195, in __call__
for mark, (kind, data, pos) in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 734, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 799, in __call__
for mark, event in stream:
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 746, in __call__
mark, subevent = next()
File /home/user/Workspace/bh201/bh/local/lib/python2.7/site-
packages/genshi/filters/transform.py, line 702, in _mark
for event in stream:
File
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: matevzb Type: enhancement | Status: accepted Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: | Keywords: --+--- Comment (by matevzb): Replying to [comment:6 jdreimann]: I've attached a screenshot of the current state of trunk on my phone. The Create Ticket button (+) moves place when clicked, from next to the search button to the next line below. Not sure yet what the best way to fix that is. This looks very strange - the dropdown caret is missing on the button, there is a shadow around the inline form (which should be absent) and the other controls - e.g. search form - are not disabled (they should be). From the attached screenshot I'm assuming it's running on an iPhone, could you specify which model and iOS version you're using? I've tested against a normal and a retina + iOS 6.1 in the Simulator, and both seem to work fine. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:7 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: matevzb Type: enhancement | Status: accepted Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: | Keywords: --+--- Comment (by jdreimann): I've attached a screenshot of the current state of trunk on my phone. The Create Ticket button (+) moves place when clicked, from next to the search button to the next line below. Not sure yet what the best way to fix that is. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay -+--- Reporter: jdreimann| Owner: nobody Type: enhancement | Status: new Priority: major| Milestone: Release 6 Component: dashboard|Version: Keywords: | -+--- On mobile devices the quick ticket overlay is not usable because it is offset to the right. It also overlays more meaningful content than it does on larger screens. I suggest that we make it expand in-place instead, pushing content that comes later in the DOM down, rather than overlaying it. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: jdreimann Type: enhancement | Status: assigned Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: | Keywords: --+--- Changes (by jdreimann): * owner: nobody = jdreimann * status: new = assigned * component: dashboard = ui design -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #544: Inline expansion for quick ticket overlay
#544: Inline expansion for quick ticket overlay --+--- Reporter: jdreimann| Owner: Type: enhancement | Status: new Priority: major| Milestone: Release 6 Component: ui design|Version: Resolution: | Keywords: --+--- Comment (by olemis): Replying to [ticket:544 jdreimann]: On mobile devices the quick ticket overlay is not usable because it is offset to the right. definitely true [...] I suggest that we make it expand in-place instead, pushing content that comes later in the DOM down, rather than overlaying it. Bootstrap responsive nav bar solution might serve as inspiration to get this done . @jdreimann : is something like that what you have in mind ? -- Ticket URL: https://issues.apache.org/bloodhound/ticket/544#comment:3 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
