Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Comment (by rjollos): #845 also closed as a duplicate. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:19 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Comment (by rjollos): #846 closed as a duplicate. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:18 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Comment (by olemis): Both #653 and #744 marked as duplicates of this ticket . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:17 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Comment (by rjollos): The patch from comment:12 is included in changes for trac:#2311, so it appears there is nothing left to do here. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:15 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Changes (by rjollos): * status: review = closed * resolution: = fixed -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:16 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: rjollos Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * owner: olemis = rjollos * status: accepted = review -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:14 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by rjollos): * owner: = olemis Comment: I'll leave for you to decide whether to close the ticket or investigate the underlying issue further in this ticket. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: review = closed * resolution: = fixed Comment: Replying to [comment:8 rjollos]: I'll leave for you to decide whether to close the ticket or investigate the underlying issue further in this ticket. Let's better close this one and defer root cause investigation to be tracked in a separate ticket . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:9 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: new Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: closed = new * resolution: fixed = Comment: hmmm ... let's better find out what's the `UnboundLocalError` about . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:10 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: accepted Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: new = accepted -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:11 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs
---+---
Reporter: olemis| Owner: olemis
Type: defect| Status: accepted
Priority: blocker | Milestone: Release 8
Component: multiproduct |Version:
Resolution:| Keywords: bep-0010 , postgresql
---+---
Comment (by rjollos):
It looks like the `UnboundLocalError` may just be a side-effect of the
ticket not existing. Perhaps we should push this patch to Trac:
{{{#!diff
diff --git a/trac/trac/ticket/notification.py
b/trac/trac/ticket/notification.py
index 2de8ec9..5c52982 100644
--- a/trac/trac/ticket/notification.py
+++ b/trac/trac/ticket/notification.py
@@ -80,6 +80,7 @@ def get_ticket_notification_recipients(env, config,
tktid, prev_cc):
ccrecipients = prev_cc
torecipients = []
+reporter = owner = None
with env.db_query as db:
# Harvest email addresses from the cc, reporter, and owner fields
for row in db(SELECT cc, reporter, owner FROM ticket WHERE
id=%s,
}}}
Note however that I'm reworking the entire function in trac:#2311
(proposed stages are changed, but I'm doing some additional refactoring
before pushing them), which may prevent issues such as this.
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:12
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: accepted Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Comment (by olemis): Replying to [comment:12 rjollos]: [...] Perhaps we should push this patch to Trac: [...] +1 [...] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:13 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Comment (by rjollos): (In [1554000]) 0.8dev: Do not populate tickets with negative IDs. Refs #668. Patch by Olemis. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:7 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * owner: olemis = * status: accepted = review -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
[Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs
-+-
Reporter: olemis |Owner:
Type: defect | Status: new
Priority: major | Version: 0.7.0
Resolution: |
-+-
In an environment (DB=postgresql) upgraded to work against 0.8-dev (i.e.
current /trunk) I've executed an RPC request to invoke `ticket.create`
method in batch (i.e. using `system.multicall`). The ticket IDs I got are
all set to `-1` instead of expected positive integers in product-specific
sequence. In the log s I also notice this error.
[[span(Log entry, class=label label-success)]]
{{{
2013-09-24 07:54:53,489 Trac[ticket] ERROR: Failure sending notification
on creation of ticket #-1: local variable 'reporter' referenced before
assignment
}}}
[[span(Log entry, class=label label-success)]]
{{{#!py
Traceback (most recent call last):
File /path/to/bloodhound_rpc/trunk/tracrpc/ticket.py, line 175, in
create
tn.notify(t, newticket=True)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 156,
in notify
self._notify(ticket, newticket, modtime)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 270,
in _notify
NotifyEmail.notify(self, ticket.id, subject, author)
File /path/to/bloodhound/trac/trac/notification.py, line 344, in
notify
Notify.notify(self, resid)
File /path/to/bloodhound/trac/trac/notification.py, line 230, in
notify
(torcpts, ccrcpts) = self.get_recipients(resid)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 388,
in get_recipients
tktid, self.prev_cc)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 129,
in get_ticket_notification_recipients
return (torecipients, ccrecipients, reporter, owner)
UnboundLocalError: local variable 'reporter' referenced before assignment
}}}
This is working fine in my local working copy with an environment
DB=sqlite .
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/668
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs
---+---
Reporter: olemis| Owner: nobody
Type: defect| Status: new
Priority: blocker | Milestone: Release 8
Component: multiproduct |Version:
Resolution:| Keywords: bep-0010
---+---
Changes (by olemis):
* component: = multiproduct
* priority: major = blocker
* owner: = nobody
* version: 0.7.0 =
* milestone: = Release 8
* keywords: = bep-0010
Old description:
In an environment (DB=postgresql) upgraded to work against 0.8-dev (i.e.
current /trunk) I've executed an RPC request to invoke `ticket.create`
method in batch (i.e. using `system.multicall`). The ticket IDs I got are
all set to `-1` instead of expected positive integers in product-specific
sequence. In the log s I also notice this error.
[[span(Log entry, class=label label-success)]]
{{{
2013-09-24 07:54:53,489 Trac[ticket] ERROR: Failure sending notification
on creation of ticket #-1: local variable 'reporter' referenced before
assignment
}}}
[[span(Log entry, class=label label-success)]]
{{{#!py
Traceback (most recent call last):
File /path/to/bloodhound_rpc/trunk/tracrpc/ticket.py, line 175, in
create
tn.notify(t, newticket=True)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 156,
in notify
self._notify(ticket, newticket, modtime)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 270,
in _notify
NotifyEmail.notify(self, ticket.id, subject, author)
File /path/to/bloodhound/trac/trac/notification.py, line 344, in
notify
Notify.notify(self, resid)
File /path/to/bloodhound/trac/trac/notification.py, line 230, in
notify
(torcpts, ccrcpts) = self.get_recipients(resid)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 388,
in get_recipients
tktid, self.prev_cc)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 129,
in get_ticket_notification_recipients
return (torecipients, ccrecipients, reporter, owner)
UnboundLocalError: local variable 'reporter' referenced before assignment
}}}
This is working fine in my local working copy with an environment
DB=sqlite .
New description:
In an environment (DB=postgresql) upgraded to work against 0.8-dev (i.e.
current /trunk) I've executed an RPC request to invoke `ticket.create`
method in batch (i.e. using `system.multicall`). The ticket IDs I got are
all set to `-1` instead of expected positive integers in product-specific
sequence. In the logs I also notice this error.
[[span(Log entry, class=label label-success)]]
{{{
2013-09-24 07:54:53,489 Trac[ticket] ERROR: Failure sending notification
on creation of ticket #-1: local variable 'reporter' referenced before
assignment
}}}
[[span(Traceback, class=label label-success)]]
{{{#!py
Traceback (most recent call last):
File /path/to/bloodhound_rpc/trunk/tracrpc/ticket.py, line 175, in
create
tn.notify(t, newticket=True)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 156,
in notify
self._notify(ticket, newticket, modtime)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 270,
in _notify
NotifyEmail.notify(self, ticket.id, subject, author)
File /path/to/bloodhound/trac/trac/notification.py, line 344, in
notify
Notify.notify(self, resid)
File /path/to/bloodhound/trac/trac/notification.py, line 230, in
notify
(torcpts, ccrcpts) = self.get_recipients(resid)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 388,
in get_recipients
tktid, self.prev_cc)
File /path/to/bloodhound/trac/trac/ticket/notification.py, line 129,
in get_ticket_notification_recipients
return (torecipients, ccrecipients, reporter, owner)
UnboundLocalError: local variable 'reporter' referenced before assignment
}}}
This is working fine in my local working copy with an environment
DB=sqlite .
--
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
