Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 9
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by rjollos):

 * milestone:  Release 8 => Release 9


Comment:

 Deferring so that we can push out Release 8.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 I've refreshed patches for this ticket in spite of :

   1. reimplementing commit ticket updater in /bloodhound_multiproduct
   2. rename classes by adding multiproduct prefix
   3. ensure that {{{post_commit}}} hook file +x flag is set
  * otherwise test run fails (at least) on certain versions of Ubuntu
  * but this might lead to failure anyways if using some specific file
 systems
under certain circumstances e.g. ntfs on linux
   4. suggest a patch for the issue described in trac:ticket:11448
  * related to 3. above

 I have updated [comment:3 patch order] accordingly .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 see trac:ticket:11448

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 Replying to [comment:21 olemis]:
 > Replying to [comment:20 rjollos]:
 > > Replying to [comment:19 olemis]:
 > > > but ... why bother if the component is already aware of multi-
 product architecture ?
 > >
 > > The patch is against the Trac core
 `trac/tracopt/ticket/commit_updater.py`, and we aim to modify that code as
 little as possible since it make merging and maintenance easier.
 >
 > Yes , I know . I'll be more specific my point is : if we are going to
 sub-class anyway then let's better keep {{{CommitTicketUpdater}}} in /trac
 unchanged and implement **all** patches in /bloodhound_multiproduct

 Previous solution finally has been rewritten to keep tracopt components
 untouched . Please see the [http://pastebin.com/g4s7nPZg test results] .
 I'll provide further details later today .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by rjollos):

 Okay, we are thinking the same.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 Replying to [comment:20 rjollos]:
 > Replying to [comment:19 olemis]:
 > > but ... why bother if the component is already aware of multi-product
 architecture ?
 >
 > The patch is against the Trac core
 `trac/tracopt/ticket/commit_updater.py`, and we aim to modify that code as
 little as possible since it make merging and maintenance easier.

 Yes , I know . I'll be more specific my point is : if we are going to sub-
 class anyway then let's better keep {{{CommitTicketUpdater}}} in /trac
 unchanged and implement **all** patches in /bloodhound_multiproduct

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by rjollos):

 Replying to [comment:19 olemis]:
 > but ... why bother if the component is already aware of multi-product
 architecture ?

 The patch is against the Trac core
 `trac/tracopt/ticket/commit_updater.py`, and we aim to modify that code as
 little as possible since it make merging and maintenance easier.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 Replying to [comment:18 rjollos]:
 >  * [attachment:t695_r1545950_twill_write_html.diff] will be included in
 [trac:milestone:1.0.2 Trac 1.0.2] (trac:#11440, trac:#10018).
 >  * Part of
 [attachment:t695_r1534486_commit_ticket_update.tests.func.diff] committed
 to Trac in [trac 12434] for inclusion in Trac 1.0.2 (trac:#11440).
 >
 > I think we should see if it is possible to subclass
 `CommitTicketUpdater` rather than modifying it
 ([attachment:t695_r1534486_commit_ticket_update_checklinks.diff]). At
 least, this approach has worked well for other situations: trac:#11349,
 trac:#10755.

 Well , the fact is that the notion of multi-product has been there since
 the beginning . I mean , all previous patches are built under the
 assumption that the component is operating in a multi-product environment
 . Subclassing may be an option , and I'm not against doing so , but ...
 why bother if the component is already aware of multi-product architecture
 ?

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by rjollos):

 * [attachment:t695_r1545950_twill_write_html.diff] will be included in
 [trac:milestone:1.0.2 Trac 1.0.2] (trac:#11440, trac:#10018).
  * Part of [attachment:t695_r1534486_commit_ticket_update.tests.func.diff]
 committed to Trac in [trac 12434] for inclusion in Trac 1.0.2
 (trac:#11440).

 I think we should see if it is possible to subclass `CommitTicketUpdater`
 rather than modifying it
 ([attachment:t695_r1534486_commit_ticket_update_checklinks.diff]). At
 least, this approach has worked well for other situations: trac:#11349,
 trac:#10755.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by rjollos):

 [attachment:t695_r1545950_functester_mp_ticket_count.diff] applied in
 [1557631] to fix the issue noted in comment:4:ticket:671.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by olemis):

 * owner:  cqli, rjollos => rjollos


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  cqli, rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 Replying to [comment:11 rjollos]:
 > Replying to [comment:9 olemis]:
 > > Note: We could propose for backporting into Trac the changes submitted
 in both [attachment:t695_r1545950_twill_write_html.diff] as well as the
 portions of
 [attachment:t695_r1534486_commit_ticket_update.tests.func.diff] extending
 the signature of functional test env's `svn_*` methods.
 >
 > That sounds great. Could you briefly explain the change in
 [attachment:t695_r1545950_twill_write_html.diff] to help me understand?

 See trac:#11440
 ;)

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  cqli, rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by cqli):

 * owner:  rjollos => cqli, rjollos


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by cqli):

 * owner:  cqli => rjollos


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  cqli
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by cqli):

 * owner:  rjollos => cqli


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by rjollos):

 Replying to [comment:9 olemis]:
 > Note: We could propose for backporting into Trac the changes submitted
 in both [attachment:t695_r1545950_twill_write_html.diff] as well as the
 portions of
 [attachment:t695_r1534486_commit_ticket_update.tests.func.diff] extending
 the signature of functional test env's `svn_*` methods.

 That sounds great. Could you briefly explain the change in
 [attachment:t695_r1545950_twill_write_html.diff] to help me understand?

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  rjollos
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:  Release 8
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by rjollos):

 * owner:   => rjollos
 * milestone:   => Release 8


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 Note: We could propose for backporting into Trac the changes submitted in
 both [attachment:t695/t695_r1545950_twill_write_html.diff] as well as the
 portions of
 [attachment:t695_r1534486_commit_ticket_update.tests.func.diff] extending
 the signature of functional test env's `svn_*` methods.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:
  Type:  enhancement  | Status:  review
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by olemis):

 * owner:  olemis =>
 * status:  accepted => review


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 I've updated patches for commit ticket updater component . It's stable now
 and ready to use after fixing errors present in corresponding macro .
 [comment:3 Patch order] updated accordingly , see [comment:3 details
 above] as well as the [http://pastebin.com/TFQs1LkJ test report] for
 further details.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 I've been writing some functional test cases for the multi-product upgrade
 of commit updater script . In the process I've also needed to apply these
 additional modifications:

   1. [attachment:t695_r1545950_twill_write_html.diff Improve
 better_twill], more preciely
  `twill_write_html` function, to detect test case methods having a
 name starting with
  `test_` prefix
   2. Upgrade ticket count tracking code in functional tests because the
 former approach
  failed to keep track of next ticket ID in scenarios where tickets for
 multiple products
  were created in a single test run

 There is still a few more work to do on this direction e.g. performance
 improvements are welcome.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Description changed by olemis:

Old description:

> The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket
> Updater] is an optional component that allows commit messages to
> reference tickets, adding comments to them and (potentially) changing
> their state.
>
> This isn't 'product aware', so currently does not work with Bloodhound
> (tested with version 0.7).
>
> Tickets are referred to by number (e.g. see/closes/fixes !#123); some
> thought will be needed if ticket numbers will be re-used across different
> products in the future.
>
> This was discussed on the [http://markmail.org/message/5e5crv7sn4fhu6oz
> mailing list].

New description:

 The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket
 Updater] is an optional component that allows commit messages to reference
 tickets, adding comments to them and (potentially) changing their state.

 This isn't 'product aware', so currently does not work with Bloodhound
 (tested with version 0.7). Besides the updates should be consistent with
 the environment's ticket workflow .

 Tickets are referred to by number (e.g. see/closes/fixes !#123); some
 thought will be needed if ticket numbers will be re-used across different
 products in the future.

 This was discussed on the [http://markmail.org/message/5e5crv7sn4fhu6oz
 mailing list].

--

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Description changed by rjollos:

Old description:

> The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket
> Updater] is an optional component that allows commit messages to
> reference tickets, adding comments to them and (potentially) changing
> their state.
>
> This isn't 'product aware', so currently does not work with Bloodhound
> (tested with version 0.7).
>
> Tickets are referred to by number (e.g. see/closes/fixes !#123); some
> thought will be needed if ticket numbers will be re-used across different
> products in the future.

New description:

 The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket
 Updater] is an optional component that allows commit messages to reference
 tickets, adding comments to them and (potentially) changing their state.

 This isn't 'product aware', so currently does not work with Bloodhound
 (tested with version 0.7).

 Tickets are referred to by number (e.g. see/closes/fixes !#123); some
 thought will be needed if ticket numbers will be re-used across different
 products in the future.

 This was discussed on the [http://markmail.org/message/5e5crv7sn4fhu6oz
 mailing list].

--

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---

Comment (by olemis):

 I have added two patches (upgrade + test cases) for commit ticket updater
 . I'd like to encourage users to review it so as to gather early feedback
 about it , but it's still WiP until functional test cases will be written
 for it . For volunteers interested in trying this out details follow :

 {{{#!sh

 $ hg qapplied
 t695/t695_r1529237_commit_ticket_update.diff
 t695/t695_r1529237_commit_ticket_update.tests.diff

 $ hg log -r qparent
 changeset:   462:83711e80eaca
 tag: qparent
 tag: svn-1529237
 parent:  459:830ce7f6f3a5
 user:gjm@13f79535-47bb-0310-9956-ffa450edef68
 date:Fri Oct 04 17:46:05 2013 +
 summary: updating the ticket timeline arrow of time and event grouping
 - towards #687
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+
  Reporter:  bsmithers|  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs
--+
Changes (by olemis):

 * keywords:   => vcs
 * version:   => 0.7.0
 * component:  multiproduct => trac core


Comment:

 I've updated ticket component because "technically" this class belongs in
 our patched copy of Trac

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+---
  Reporter:  bsmithers|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  major|  Milestone:
 Component:  trac core|Version:  0.7.0
Resolution:   |   Keywords:  vcs hooks
--+---
Changes (by olemis):

 * owner:  nobody => olemis
 * keywords:  vcs => vcs hooks
 * status:  new => accepted


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

[Apache Bloodhound] #695: Add support for the CommitTicketUpdater component

[Apache Bloodhound]

#695: Add support for the CommitTicketUpdater component
--+
 Reporter:  bsmithers |  Owner:  nobody
 Type:  enhancement   | Status:  new
 Priority:  major |  Milestone:
Component:  multiproduct  |Version:
 Keywords:|
--+
 The [http://trac.edgewall.org/wiki/CommitTicketUpdater Commit Ticket
 Updater] is an optional component that allows commit messages to reference
 tickets, adding comments to them and (potentially) changing their state.

 This isn't 'product aware', so currently does not work with Bloodhound
 (tested with version 0.7).

 Tickets are referred to by number (e.g. see/closes/fixes !#123); some
 thought will be needed if ticket numbers will be re-used across different
 products in the future.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker