[Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
-+
  Reporter:  olemis  |Owner:
  Type:  defect  |   Status:  new
  Priority:  major   |  Version:  0.8.0dev
Resolution:  |
-+
 Issue detected using PostgreSQL . Steps to reproduce :

   - Create product P1
   - Create product P2
   - Create ticket T1 in P1
   - Create ticket T2 in P2
   - Manage relations for T2
   - Add relation
 * type = refers to
 * ticket ID = P1-T1
   - Error : {{{ "Invalid ticket number \nTicket T1 does not exist." }}}

 There's also a warning

 {{{
 The relation has been added, but an error occurred while
 sendingnotifications: local variable 'dbrel' referenced before assignment
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--
Changes (by olemis):

 * owner:   => nobody
 * component:   => relations


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--
Changes (by olemis):

 * priority:  major => critical


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by astaric):

 I have attached a patch that fixes the issue for me. Could you try it out?

 (It fixes the crash, not the warning.)

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by astaric):

 Warning was a result of trying to send notifications even when an error
 occurred during creation of relation. This was fixed in r1564692.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by olemis):

 I can't apply the patch on top of recent versions including i18n support .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by rjollos):

 The patch seems to fix the issue. For reference, here is the traceback
 seen prior to the patch (at r1568745),
 {{{#!pycon
 10:36:00 PM Trac[main] ERROR: Exception caught while post-processing
 request:
 Traceback (most recent call last):
   File "/home/user/Workspace/bhdev/bloodhound.git/trac/trac/web/main.py",
 line 243, in dispatch
 self._post_process_request(req)
   File "/home/user/Workspace/bhdev/bloodhound.git/trac/trac/web/main.py",
 line 340, in _post_process_request
 f.post_process_request(req, *(None,)*extra_arg_count)
   File
 
"/home/user/Workspace/bhdev/bloodhound.git/bloodhound_relations/bhrelations/web_ui.py",
 line 151, in post_process_request
 ticket = data['ticket']
 TypeError: 'NoneType' object has no attribute '__getitem__'
 10:36:00 PM Trac[main] WARNING: [127.0.0.1] HTTPNotFound: 404 Invalid
 ticket number (Ticket 23 does not exist.)
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by rjollos):

 [attachment:0001-Fix-crash-on-inter-product-relations-001.patch] applies
 cleanly on r1568745 (although I was finding [attachment:0001-Fix-crash-on-
 inter-product-relations.patch] applied cleanly as well).

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--

Comment (by olemis):

 I'll take a look and provide you with feedback in a while ...

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  rjollos
  Type:  defect | Status:  assigned
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution: |   Keywords:
+--
Changes (by olemis):

 * status:  new => assigned
 * owner:  nobody => rjollos


Comment:

 yeah ! it's working as expected , the patch fixes this issue . I'm
 assigning this ticket to @rjollos in case this need any further review or
 to finally commit it into /trunk , cmiiw .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  rjollos
  Type:  defect | Status:  closed
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution:  fixed  |   Keywords:
+--
Changes (by rjollos):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 (In [1570152])

 0.8dev: Intraproduct ticket relation would result in an error when
 rendering the resource links because the proper envirionment was not being
 used. Refs #750.

 Patch by Anze.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+--
  Reporter:  olemis |  Owner:  astaric
  Type:  defect | Status:  closed
  Priority:  critical   |  Milestone:
 Component:  relations  |Version:  0.8.0dev
Resolution:  fixed  |   Keywords:
+--
Changes (by rjollos):

 * owner:  rjollos => astaric


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #750: Invalid ticket ID in relation makes ticket view crash

[Apache Bloodhound]

#750: Invalid ticket ID in relation makes ticket view crash
+---
  Reporter:  olemis |  Owner:  astaric
  Type:  defect | Status:  closed
  Priority:  critical   |  Milestone:  Release 8
 Component:  relations  |Version:  0.8.0dev
Resolution:  fixed  |   Keywords:
+---
Changes (by rjollos):

 * milestone:   => Release 8


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker