Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: closed Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: fixed | Keywords: +--- Comment (by rjollos): Brief upgrade documentation added in BloodhoundUpgrade@4. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:12 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: closed Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: fixed | Keywords: +--- Changes (by rjollos): * status: accepted = closed * resolution: = fixed -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:11 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: accepted Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: | Keywords: +--- Comment (by olemis): It is possible to deal with this in a separate ticket . This should not be a blocker looking forward to [milestone:Release 8] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:9 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: accepted Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: | Keywords: +--- Comment (by rjollos): (In [1616400]) 0.8dev: Use fully-qualified name for `request_factory` and `environment_factory`. Refs #795. * For the typically multiproduct environment, `[trac] environment_factory = multiproduct.hooks.MultiProductEnvironmentFactory` and `[trac] request_factory = multiproduct.hooks.ProductRequestFactory`. * Use `abc` module for abstract base classes. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: accepted Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: | Keywords: +--- Comment (by olemis): IMO these should be expressed using [http://pythonhosted.org/setuptools/pkg_resources.html#entry-points entry point notation] (see also stackoverflow:774824) . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:7 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: accepted Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: | Keywords: +--- Changes (by rjollos): * status: new = accepted Comment: Proposed change is to use a fully-qualified name for `[trac] environment_factory` and `[trac] request_factory`. Patch in [attachment:t795.diff]. `load_class` is from SO:547867/121694, with exception handling added. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory
#795: request_factory and environment_factory options point to files in the bloodhound source directory +--- Reporter: rjollos| Owner: rjollos Type: defect | Status: accepted Priority: major | Milestone: Release 8 Component: installer |Version: Resolution: | Keywords: +--- Comment (by rjollos): Replying to [ticket:795 rjollos]: ... or instead refer to component classes. More specifically, `EnvironmentFactoryBase` and `RequestFactoryBase` would be component classes. `[trac] request_factory` and `[trac] environment_factory` would be `ExtensionOptions`, and `self.request_factory`/ `self.environment_factory` would return instances. `BootstrapHandlerBase` would also need to be a `Component` class. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/795#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
