Re: [Apache Bloodhound] #842: On BatchModify form workflow controls should be disabled until action is selected
#842: On BatchModify form workflow controls should be disabled until action is selected +-- Reporter: rjollos| Owner: nobody Type: defect | Status: new Priority: major | Milestone: Release 9 Component: ui design |Version: Resolution: | Keywords: batch-modify +-- Comment (by rjollos): The patch in trac:#11931 has been committed and will be included in trac:milestone:1.1.4. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/842#comment:2 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #842: On BatchModify form workflow controls should be disabled until action is selected
#842: On BatchModify form workflow controls should be disabled until action is
selected
+--
Reporter: rjollos| Owner: nobody
Type: defect | Status: new
Priority: major | Milestone: Release 9
Component: ui design |Version:
Resolution: | Keywords: batch-modify
+--
Comment (by rjollos):
The patch looks good. There are a few minor things that could be
optimized:
* `jQuery` should be used in the outer scope to avoid conflicts with
other !JavaScript libraries, but within
`jQuery(document).ready(function($) { ...` the symbol `$` can be used in
place of `jQuery` without needing to worry about conflicts. This is
because `$` is passed as an argument and will only be visible in the scope
of the function.
* `$('#batchmod_action').find('input[name=action]')` can be replaced by
`$('#batchmod_action input[name=action]')`.
* We can use a function to avoid code duplication.
I've proposed a patch for Trac that also attempts to reduce some code
duplication between the `batch_modify.html` and `ticket.html`. I'll commit
after getting feedback from the other Trac devs, and then make similar
changes to Bloodhound.
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/842#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
[Apache Bloodhound] #842: On BatchModify form workflow controls should be disabled until action is selected
#842: On BatchModify form workflow controls should be disabled until action is selected --+--- Reporter: rjollos | Owner: nobody Type: defect| Status: new Priority: major | Milestone: Release 9 Component: ui design |Version: Keywords: batch-modify | --+--- The change described in trac:#11931 should be fixed in Bloodhound as well. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/842 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
