Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract ---+--- Reporter: olemis| Owner: gjm Type: enhancement | Status: closed Priority: major | Milestone: Release 8 Component: multiproduct |Version: 0.7.0 Resolution: fixed | Keywords: product env, bep-0003 ---+--- Changes (by gjm): * status: review = closed * resolution: = fixed Comment: Calling this done. Thanks for the help olemis. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract ---+--- Reporter: olemis| Owner: gjm Type: enhancement | Status: review Priority: major | Milestone: Release 8 Component: multiproduct |Version: 0.7.0 Resolution:| Keywords: product env, bep-0003 ---+--- Changes (by gjm): * owner: = gjm Comment: Taking this ticket on to commit patches from olemis (with some modifications) -- Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:6 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract
---+---
Reporter: olemis| Owner: gjm
Type: enhancement | Status: review
Priority: major | Milestone: Release 8
Component: multiproduct |Version: 0.7.0
Resolution:| Keywords: product env, bep-0003
---+---
Comment (by gjm):
r1527743 modifies {{{ProductEnvironment}}} instantiation to allow a
{{{ProductEnvironment}}}'s parent to be used
r1527747 updates a test that expected failure prior to r1527743
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:7
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract ---+--- Reporter: olemis| Owner: nobody Type: enhancement | Status: new Priority: major | Milestone: Release 8 Component: multiproduct |Version: 0.7.0 Resolution:| Keywords: product env, bep-0003 ---+--- Description changed by olemis: Old description: When invoking `multiproduct.ProductEnvironment` the initial versions of bep:0003 limited the type of the first argument to `trac.env.Environment`. In spite of uniformity and simplicity the following enhancements are needed : - The meta-class `__call__` method has to be wrapped with logic similar to `lookup_env` class method * The initializer must still restrict argument type for cache consistency - Both `ProductEnvironment.lookup_env` and `lookup_product_env` should be phased out and replaced with direct calls to `ProductEnvironment` class for instantiation - Test cases needed New description: When invoking `multiproduct.ProductEnvironment` the initial versions of bep:0003 limited the type of the first argument to `trac.env.Environment`. Eventually this led to a considerable number [https://gist.github.com/olemis/6639783 failures] . In spite of uniformity and simplicity the following enhancements are needed : - The meta-class `__call__` method has to be wrapped with logic similar to `lookup_env` class method * The initializer must still restrict argument type for cache consistency - Both `ProductEnvironment.lookup_env` and `lookup_product_env` should be phased out and replaced with direct calls to `ProductEnvironment` class. - Test cases -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:1 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract ---+--- Reporter: olemis| Owner: olemis Type: enhancement | Status: accepted Priority: major | Milestone: Release 8 Component: multiproduct |Version: 0.7.0 Resolution:| Keywords: product env, bep-0003 ---+--- Description changed by olemis: Old description: When invoking `multiproduct.ProductEnvironment` the initial versions of bep:0003 limited the type of the first argument to `trac.env.Environment`. Eventually this led to a considerable number [http://goo.gl/dGZvcE failures] . In spite of uniformity and simplicity the following enhancements are needed : - The meta-class `__call__` method has to be wrapped with logic similar to `lookup_env` class method * The initializer must still restrict argument type for cache consistency - Both `ProductEnvironment.lookup_env` and `lookup_product_env` should be phased out and replaced with direct calls to `ProductEnvironment` class. - Test cases New description: When invoking `multiproduct.ProductEnvironment` the initial versions of bep:0003 limited the type of the first argument to `trac.env.Environment`. Eventually this led to a considerable number of [http://goo.gl/dGZvcE failures] . In spite of uniformity and simplicity the following enhancements are needed : - The first argument in a call to `multiproduct.ProductEnvironment` class may be an instance of either `multiproduct.ProductEnvironment` or `trac.env.Environment` - The meta-class `__call__` method has to be wrapped with logic similar to `lookup_env` class method * The initializer must still restrict argument type for cache consistency - Both `ProductEnvironment.lookup_env` and `lookup_product_env` should be phased out and replaced with direct calls to `ProductEnvironment` class. - Test cases -- -- Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:3 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #676: Relax constraints on ProductEnvironment callable contract
#676: Relax constraints on ProductEnvironment callable contract
---+---
Reporter: olemis| Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 8
Component: multiproduct |Version: 0.7.0
Resolution:| Keywords: product env, bep-0003
---+---
Old description:
When invoking `multiproduct.ProductEnvironment` the initial versions of
bep:0003 limited the type of the first argument to
`trac.env.Environment`. Eventually this led to a considerable number of
[http://goo.gl/dGZvcE failures] .
In spite of uniformity and simplicity the following enhancements are
needed :
- The first argument in a call to `multiproduct.ProductEnvironment`
class
may be an instance of either `multiproduct.ProductEnvironment` or
`trac.env.Environment`
- The meta-class `__call__` method has to be wrapped with logic
similar to `lookup_env` class method
* The initializer must still restrict argument type for cache
consistency
- Both `ProductEnvironment.lookup_env` and `lookup_product_env`
should be phased out and replaced with direct calls to
`ProductEnvironment` class.
- Test cases
New description:
When invoking `multiproduct.ProductEnvironment` the initial versions of
bep:0003 limited the type of the first argument to `trac.env.Environment`.
Eventually this led to a considerable number of [http://goo.gl/dGZvcE
failures] .
In spite of uniformity and simplicity the following enhancements are
needed :
- The first argument in a call to `multiproduct.ProductEnvironment`
class
may be an instance of either `multiproduct.ProductEnvironment` or
`trac.env.Environment`
- The meta-class `__call__` method has to be wrapped with logic
similar to `lookup_env` class method
* The initializer must still restrict argument type for cache
consistency
- ~~Both `ProductEnvironment.lookup_env` and `lookup_product_env` should
be phased out and replaced with direct calls to `ProductEnvironment`
class.~~
- Test cases
--
Comment (by olemis):
Attached patches will solve current issues . Details
{{{#!sh
$ hg qapplied
t676/t676_r1526822_product_env_typecheck.diff
t676/t676_r1526822_product_env_typecheck.tests.diff
$ hg log -r qparent
changeset: 449:ec411de59e61
tag: qparent
tag: svn-1526822
user:astaric@13f79535-47bb-0310-9956-ffa450edef68
date:Fri Sep 27 07:59:57 2013 +
summary: Display relation type in all rows.
}}}
PS: `lookup_env` should not be deprecated because it also performs
environment lookup by name , so it's ok to keep it as an integral part of
the API .
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/676#comment:4
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
