[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

2020-03-26 Thread GitBox 
DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function
URL: https://github.com/apache/calcite/pull/1862#issuecomment-604812196
 
 
   In [CALCITE-3235](https://issues.apache.org/jira/browse/CALCITE-3235), 
`CONCAT` function with var args is added but not implemented (i.e., the query 
can only pass validation).
   This PR focuses on:
   (1) adding Oracle's `CONCAT` function, it accepts only two operands
   (2) implementing `CONCAT` function in runtime
   (3) fixing the return type inference issue
   
   Personally, I think "Implement CONCAT function" is ok. 
   @chunweilei @wenhuitang Do you have any suggestions to cover the topics 
above?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

2020-03-26 Thread GitBox 
DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function
URL: https://github.com/apache/calcite/pull/1862#issuecomment-604791073
 
 
   Close and reopen to trigger the checks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function

2020-03-25 Thread GitBox 
DonnyZone commented on issue #1862: [CALCITE-3864] Implement Concat function
URL: https://github.com/apache/calcite/pull/1862#issuecomment-603832001
 
 
   +1, LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services