[GitHub] [calcite] asolimando commented on a diff in pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

[GitBox]

asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1028128040


##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
 return mq.getExpressionLineage(rel.getInput(), outputExpression);
   }
 
+  /**
+   * Expression lineage from Snapshot.
+   */

Review Comment:
   It's better to keep the PR focused on the topic I guess, but thanks for 
volunteering



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] asolimando commented on a diff in pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

[GitBox]

asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1028126808


##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,18 @@ protected RelMdExpressionLineage() {}
 return mq.getExpressionLineage(rel.getInput(), outputExpression);
   }
 
+  /**
+   * Expression lineage from Snapshot.
+   * @param rel Relational expression which is Snapshot
+   * @param mq Metadata query
+   * @param outputExpression Expression which need be inferred
+   * @return If the lineage cannot be inferred, we return null.
+   */

Review Comment:
   Thanks for adding the javadoc, in general the sentence starts with 
lower-case letters, I have taken the liberty to also rephrase a couple of 
sentences. No problem if you want to keep the original sentences, but please 
fix the first letter casing if you do so.
   
   ```suggestion
 /**
  * Expression lineage from Snapshot.
  * @param rel Snapshot relational expression
  * @param mq metadata query
  * @param outputExpression expression which needs to be inferred
  * @return the inferred lineage, possibly null.
  */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] asolimando commented on a diff in pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

[GitBox]

asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1027756107


##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
 return mq.getExpressionLineage(rel.getInput(), outputExpression);
   }
 
+  /**
+   * Expression lineage from Snapshot.
+   */

Review Comment:
   I know that none of the other methods in the class have it, but I think it's 
important to have proper javadoc for public methods of this kind, something 
along this format:
   ```
 /**
  * Expression lineage from Snapshot.
  * @param rel
  * @param mq
  * @param outputExpression
  * @return
  */
   ```
   What do you think Jiajun?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org