[GitHub] [calcite] asolimando commented on pull request #2947: [MINOR] Add default catalog link to test fixtures
asolimando commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288630911 Thanks @JiajunBernoulli, I agree on your reasoning. Can I ask you to squash the commits? Once done, I will merge it in the next 24 hours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [calcite] asolimando commented on pull request #2947: [MINOR] Add default catalog link to test fixtures
asolimando commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1287672624 I have recently had the same issue, so +1 on the change. I noticed that the comments for the `sql()` method are all different for these three classes, maybe we can try to provide a single description, so that it's clear that the three methods are doing the same thing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
