[GitHub] [calcite] asolimando commented on pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

2022-11-22 Thread GitBox


asolimando commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1323315072

   @JiajunBernoulli it's good to me, if you can squash to a single commit I 
will merge, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [calcite] asolimando commented on pull request #2976: [CALCITE-5392] Support Snapshot in RelMdExpressionLineage

2022-11-21 Thread GitBox


asolimando commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1322134305

   @JiajunBernoulli, until the review process is over please don't force-push, 
it destroys the "link" to the old comments and it makes incremental reviewing 
impossible (checking just the delta from the latest review). In this case the 
PR is small-sized, but let's avoid it altogether


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org